From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniele Ceraolo Spurio Subject: Re: [PATCH 2/6] drm/i915/icl: Correctly initialize the Gen11 engines Date: Tue, 6 Mar 2018 14:07:23 -0800 Message-ID: <2641ca98-3866-af7e-c34b-94d514e2f98d@intel.com> References: <20180302161501.28594-1-mika.kuoppala@linux.intel.com> <20180302161501.28594-2-mika.kuoppala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 62E566E342 for ; Tue, 6 Mar 2018 22:07:24 +0000 (UTC) In-Reply-To: <20180302161501.28594-2-mika.kuoppala@linux.intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Mika Kuoppala , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org CgpPbiAwMi8wMy8xOCAwODoxNCwgTWlrYSBLdW9wcGFsYSB3cm90ZToKPiBGcm9tOiBPc2NhciBN YXRlbyA8b3NjYXIubWF0ZW9AaW50ZWwuY29tPgo+IAo+IEdlbjExIGhhcyB1cCB0byA0IFZDUyBh bmQgdXAgdG8gMiBWRUNTIGVuZ2luZXMsIHRoaXMgcGF0Y2ggYWRkcyBtbWlvCj4gYmFzZSBkZWZp bml0aW9ucyBmb3IgYWxsIG9mIHRoZW0uCj4gCj4gQnNwZWM6IDIwOTQ0Cj4gQnNwZWM6IDcwMjEK PiAKPiB2MjogU2V0IHRoZSBjb3JyZWN0IG1taW9fYmFzZSBpbiBpbnRlbF9lbmdpbmVzX2luaXRf bW1pbzsgdXBkYXRpbmcgdGhlCj4gYmFzZSBtbWlvIHZhbHVlcyBhbnkgbGF0ZXIgd291bGQgY2F1 c2UgaW5jb3JyZWN0IHJlYWRzIGluCj4gaTkxNV9nZW1fc2FuaXRpemUgKE1pY2hlbCkuCj4gCj4g Q2M6IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+Cj4gQ2M6IENlcmFv bG8gU3B1cmlvLCBEYW5pZWxlIDxkYW5pZWxlLmNlcmFvbG9zcHVyaW9AaW50ZWwuY29tPgo+IFNp Z25lZC1vZmYtYnk6IE9zY2FyIE1hdGVvIDxvc2Nhci5tYXRlb0BpbnRlbC5jb20+Cj4gU2lnbmVk LW9mZi1ieTogTWljaGVsIFRoaWVycnkgPG1pY2hlbC50aGllcnJ5QGludGVsLmNvbT4KPiAtLS0K PiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmggICAgICAgIHwgIDYgKysrKysKPiAg IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2VuZ2luZV9jcy5jIHwgNDQgKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrLQo+ICAgMiBmaWxlcyBjaGFuZ2VkLCA0OSBpbnNlcnRpb25z KCspLCAxIGRlbGV0aW9uKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2k5MTVfcmVnLmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oCj4gaW5kZXggMjU4 ZTg2ZWIzN2Q1Li40NWFlMDVkMGZlNzggMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV9yZWcuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmgKPiBA QCAtMjM0NSw3ICsyMzQ1LDEzIEBAIGVudW0gaTkxNV9wb3dlcl93ZWxsX2lkIHsKPiAgICNkZWZp bmUgQlNEX1JJTkdfQkFTRQkJMHgwNDAwMAo+ICAgI2RlZmluZSBHRU42X0JTRF9SSU5HX0JBU0UJ MHgxMjAwMAo+ICAgI2RlZmluZSBHRU44X0JTRDJfUklOR19CQVNFCTB4MWMwMDAKPiArI2RlZmlu ZSBHRU4xMV9CU0RfUklOR19CQVNFCTB4MWMwMDAwCj4gKyNkZWZpbmUgR0VOMTFfQlNEMl9SSU5H X0JBU0UJMHgxYzQwMDAKPiArI2RlZmluZSBHRU4xMV9CU0QzX1JJTkdfQkFTRQkweDFkMDAwMAo+ ICsjZGVmaW5lIEdFTjExX0JTRDRfUklOR19CQVNFCTB4MWQ0MDAwCj4gICAjZGVmaW5lIFZFQk9Y X1JJTkdfQkFTRQkJMHgxYTAwMAo+ICsjZGVmaW5lIEdFTjExX1ZFQk9YX1JJTkdfQkFTRQkJMHgx YzgwMDAKPiArI2RlZmluZSBHRU4xMV9WRUJPWDJfUklOR19CQVNFCQkweDFkODAwMAo+ICAgI2Rl ZmluZSBCTFRfUklOR19CQVNFCQkweDIyMDAwCj4gICAjZGVmaW5lIFJJTkdfVEFJTChiYXNlKQkJ X01NSU8oKGJhc2UpKzB4MzApCj4gICAjZGVmaW5lIFJJTkdfSEVBRChiYXNlKQkJX01NSU8oKGJh c2UpKzB4MzQpCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2VuZ2lu ZV9jcy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZW5naW5lX2NzLmMKPiBpbmRleCAz ZTExMDdlY2I2ZWUuLjkxMWZjMDg2NThjNSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9lbmdpbmVfY3MuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2VuZ2luZV9jcy5jCj4gQEAgLTEyMyw2ICsxMjMsMjIgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBl bmdpbmVfaW5mbyBpbnRlbF9lbmdpbmVzW10gPSB7Cj4gICAJCS5tbWlvX2Jhc2UgPSBHRU44X0JT RDJfUklOR19CQVNFLAo+ICAgCQkuaXJxX3NoaWZ0ID0gR0VOOF9WQ1MyX0lSUV9TSElGVCwKPiAg IAl9LAo+ICsJW1ZDUzNdID0gewo+ICsJCS5od19pZCA9IFZDUzNfSFcsCj4gKwkJLnVhYmlfaWQg PSBJOTE1X0VYRUNfQlNELAo+ICsJCS5jbGFzcyA9IFZJREVPX0RFQ09ERV9DTEFTUywKPiArCQku aW5zdGFuY2UgPSAyLAo+ICsJCS5tbWlvX2Jhc2UgPSBHRU4xMV9CU0QzX1JJTkdfQkFTRSwKPiAr CQkuaXJxX3NoaWZ0ID0gMCwgLyogbm90IHVzZWQgKi8KPiArCX0sCj4gKwlbVkNTNF0gPSB7Cj4g KwkJLmh3X2lkID0gVkNTNF9IVywKPiArCQkudWFiaV9pZCA9IEk5MTVfRVhFQ19CU0QsCj4gKwkJ LmNsYXNzID0gVklERU9fREVDT0RFX0NMQVNTLAo+ICsJCS5pbnN0YW5jZSA9IDMsCj4gKwkJLm1t aW9fYmFzZSA9IEdFTjExX0JTRDRfUklOR19CQVNFLAo+ICsJCS5pcnFfc2hpZnQgPSAwLCAvKiBu b3QgdXNlZCAqLwo+ICsJfSwKPiAgIAlbVkVDU10gPSB7Cj4gICAJCS5od19pZCA9IFZFQ1NfSFcs Cj4gICAJCS51YWJpX2lkID0gSTkxNV9FWEVDX1ZFQk9YLAo+IEBAIC0xMzEsNiArMTQ3LDE0IEBA IHN0YXRpYyBjb25zdCBzdHJ1Y3QgZW5naW5lX2luZm8gaW50ZWxfZW5naW5lc1tdID0gewo+ICAg CQkubW1pb19iYXNlID0gVkVCT1hfUklOR19CQVNFLAo+ICAgCQkuaXJxX3NoaWZ0ID0gR0VOOF9W RUNTX0lSUV9TSElGVCwKPiAgIAl9LAo+ICsJW1ZFQ1MyXSA9IHsKPiArCQkuaHdfaWQgPSBWRUNT Ml9IVywKPiArCQkudWFiaV9pZCA9IEk5MTVfRVhFQ19WRUJPWCwKPiArCQkuY2xhc3MgPSBWSURF T19FTkhBTkNFTUVOVF9DTEFTUywKPiArCQkuaW5zdGFuY2UgPSAxLAo+ICsJCS5tbWlvX2Jhc2Ug PSBHRU4xMV9WRUJPWDJfUklOR19CQVNFLAo+ICsJCS5pcnFfc2hpZnQgPSAwLCAvKiBub3QgdXNl ZCAqLwo+ICsJfSwKPiAgIH07Cj4gICAKPiAgIC8qKgo+IEBAIC0yMzAsNyArMjU0LDI1IEBAIGlu dGVsX2VuZ2luZV9zZXR1cChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gICAJ CQkgY2xhc3NfaW5mby0+bmFtZSwgaW5mby0+aW5zdGFuY2UpID49Cj4gICAJCXNpemVvZihlbmdp bmUtPm5hbWUpKTsKPiAgIAllbmdpbmUtPmh3X2lkID0gZW5naW5lLT5ndWNfaWQgPSBpbmZvLT5o d19pZDsKPiAtCWVuZ2luZS0+bW1pb19iYXNlID0gaW5mby0+bW1pb19iYXNlOwo+ICsJaWYgKElO VEVMX0dFTihkZXZfcHJpdikgPj0gMTEpIHsKPiArCQlzd2l0Y2ggKGVuZ2luZS0+aWQpIHsKPiAr CQljYXNlIFZDUzoKPiArCQkJZW5naW5lLT5tbWlvX2Jhc2UgPSBHRU4xMV9CU0RfUklOR19CQVNF Owo+ICsJCQlicmVhazsKPiArCQljYXNlIFZDUzI6Cj4gKwkJCWVuZ2luZS0+bW1pb19iYXNlID0g R0VOMTFfQlNEMl9SSU5HX0JBU0U7Cj4gKwkJCWJyZWFrOwo+ICsJCWNhc2UgVkVDUzoKPiArCQkJ ZW5naW5lLT5tbWlvX2Jhc2UgPSBHRU4xMV9WRUJPWF9SSU5HX0JBU0U7Cj4gKwkJCWJyZWFrOwo+ ICsJCWRlZmF1bHQ6Cj4gKwkJCS8qIHRha2UgdGhlIG9yaWdpbmFsIHZhbHVlIGZvciBhbGwgb3Ro ZXIgZW5naW5lcyAgKi8KPiArCQkJZW5naW5lLT5tbWlvX2Jhc2UgPSBpbmZvLT5tbWlvX2Jhc2U7 Cj4gKwkJCWJyZWFrOwo+ICsJCX0KCkknbSBzbGlnaHRseSB1bmNvbnZpbmNlZCBieSB0aGUgZmFj dCB0aGF0IHdlIGhhdmUgYSBzdGF0aWMgdGFibGUgd2l0aCAKc29tZSB2YWx1ZXMgYW5kIHRoZW4g d2UgdXNlIG90aGVyIHZhbHVlcyBoZXJlLiBNYXliZSB3ZSBjb3VsZCBpbnN0ZWFkIAp1c2UgYW5k IGFycmF5IG9mIFtzdGFydGluZ19nZW4sIG1taW9fYmFzZV0gcGFpcnMgaW4gdGhlIHRhYmxlIGFu ZCBkZXJpdmUgCnRoZSBjb3JyZWN0IHZhbHVlIGhlcmU/IEFueXdheSwgc2luY2UgdGhpcyBpcyBu b3QgdGhlIG9ubHkgcGxhY2Ugd2hlcmUgCndlIGRvbid0IHVzZSB0aGUgbW1pb19iYXNlIHZhbHVl IGZyb20gdGhlIHRhYmxlIChzYW1lIGhhcHBlbnMgZm9yIApwcmUtZ2VuNiBCU0QgaW4gaW50ZWxf aW5pdF9ic2RfcmluZ19idWZmZXIpIEkgZG9uJ3QgY29uc2lkZXIgdGhpcyBhIApibG9ja2luZyBp c3N1ZS4gQWxsIHRoZSB2YWx1ZXMgbWF0Y2ggdGhlIHNwZWNzLCBzbzoKClJldmlld2VkLWJ5OiBE YW5pZWxlIENlcmFvbG8gU3B1cmlvIDxkYW5pZWxlLmNlcmFvbG9zcHVyaW9AaW50ZWwuY29tPgoK SSdsbCBwcm9iYWJseSBjaGVjayBob3cgdXNpbmcgdGhlIHRhYmxlIEkgbWVudGlvbmVkIGFib3Zl IGxvb2tzIGxpa2UgCmFmdGVyIHRoaXMgaXMgbWVyZ2VkIGFuZCBJJ2xsIHNlbmQgYW4gUkZDIGlm IGl0IHNlZW1zIG5pY2UuCgpUaGFua3MsCkRhbmllbGUKCj4gKwl9IGVsc2Ugewo+ICsJCWVuZ2lu ZS0+bW1pb19iYXNlID0gaW5mby0+bW1pb19iYXNlOwo+ICsJfQo+ICAgCWVuZ2luZS0+aXJxX3No aWZ0ID0gaW5mby0+aXJxX3NoaWZ0Owo+ICAgCWVuZ2luZS0+Y2xhc3MgPSBpbmZvLT5jbGFzczsK PiAgIAllbmdpbmUtPmluc3RhbmNlID0gaW5mby0+aW5zdGFuY2U7Cj4gCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QK SW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=