From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Date: Tue, 31 Jul 2018 10:45:15 +0000 Subject: Re: [PATCH v3 1/2] console: Replace #if 0 with atomic var 'ignore_console_lock_warning' Message-Id: <2644500.Kme8HshdzX@amdc3058> List-Id: References: <20180719101601.25076-1-tzimmermann@suse.de> <20180719101601.25076-2-tzimmermann@suse.de> In-Reply-To: <20180719101601.25076-2-tzimmermann@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Thomas Zimmermann Cc: pmladek@suse.com, linux-fbdev@vger.kernel.org, sergey.senozhatsky.work@gmail.com, sergey.senozhatsky@gmail.com, dri-devel@lists.freedesktop.org, hdegoede@redhat.com, rostedt@goodmis.org, akpm@linux-foundation.org On Thursday, July 19, 2018 12:16:00 PM Thomas Zimmermann wrote: > The macro WARN_CONSOLE_UNLOCKED prints a warning when a thread enters > the console's critical section without having acquired the console > lock. The console lock can be ignored when debugging the console using > printk, but this makes WARN_CONSOLE_UNLOCKED generate unnecessary > warnings. > > The variable ignore_console_lock_warning temporarily disables > WARN_CONSOLE_UNLOCKED. Developers interested in debugging the console's > critical sections should increment it before entering the CS and > decrement it after leaving the CS. Setting ignore_console_lock_warning > is only for debugging. Regular operation should not manipulate it. > > Acknoledgements: This patch is based on an earlier version by Steven > Rostedt. The use of atomic increment/decrement was suggested by Petr > Mladek. > > Link: http://lkml.kernel.org/r/717e6337-e7a6-7a92-1c1b-8929a25696b5@suse.de > Signed-off-by: Thomas Zimmermann Patch queued for 4.19 (w/ -> fixup), thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Subject: Re: [PATCH v3 1/2] console: Replace #if 0 with atomic var 'ignore_console_lock_warning' Date: Tue, 31 Jul 2018 12:45:15 +0200 Message-ID: <2644500.Kme8HshdzX@amdc3058> References: <20180719101601.25076-1-tzimmermann@suse.de> <20180719101601.25076-2-tzimmermann@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1A43A6E349 for ; Tue, 31 Jul 2018 10:45:19 +0000 (UTC) In-reply-to: <20180719101601.25076-2-tzimmermann@suse.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Thomas Zimmermann Cc: pmladek@suse.com, linux-fbdev@vger.kernel.org, sergey.senozhatsky.work@gmail.com, sergey.senozhatsky@gmail.com, dri-devel@lists.freedesktop.org, hdegoede@redhat.com, rostedt@goodmis.org, akpm@linux-foundation.org List-Id: dri-devel@lists.freedesktop.org T24gVGh1cnNkYXksIEp1bHkgMTksIDIwMTggMTI6MTY6MDAgUE0gVGhvbWFzIFppbW1lcm1hbm4g d3JvdGU6Cj4gVGhlIG1hY3JvIFdBUk5fQ09OU09MRV9VTkxPQ0tFRCBwcmludHMgYSB3YXJuaW5n IHdoZW4gYSB0aHJlYWQgZW50ZXJzCj4gdGhlIGNvbnNvbGUncyBjcml0aWNhbCBzZWN0aW9uIHdp dGhvdXQgaGF2aW5nIGFjcXVpcmVkIHRoZSBjb25zb2xlCj4gbG9jay4gVGhlIGNvbnNvbGUgbG9j ayBjYW4gYmUgaWdub3JlZCB3aGVuIGRlYnVnZ2luZyB0aGUgY29uc29sZSB1c2luZwo+IHByaW50 aywgYnV0IHRoaXMgbWFrZXMgV0FSTl9DT05TT0xFX1VOTE9DS0VEIGdlbmVyYXRlIHVubmVjZXNz YXJ5Cj4gd2FybmluZ3MuCj4gCj4gVGhlIHZhcmlhYmxlIGlnbm9yZV9jb25zb2xlX2xvY2tfd2Fy bmluZyB0ZW1wb3JhcmlseSBkaXNhYmxlcwo+IFdBUk5fQ09OU09MRV9VTkxPQ0tFRC4gRGV2ZWxv cGVycyBpbnRlcmVzdGVkIGluIGRlYnVnZ2luZyB0aGUgY29uc29sZSdzCj4gY3JpdGljYWwgc2Vj dGlvbnMgc2hvdWxkIGluY3JlbWVudCBpdCBiZWZvcmUgZW50ZXJpbmcgdGhlIENTIGFuZAo+IGRl Y3JlbWVudCBpdCBhZnRlciBsZWF2aW5nIHRoZSBDUy4gU2V0dGluZyBpZ25vcmVfY29uc29sZV9s b2NrX3dhcm5pbmcKPiBpcyBvbmx5IGZvciBkZWJ1Z2dpbmcuIFJlZ3VsYXIgb3BlcmF0aW9uIHNo b3VsZCBub3QgbWFuaXB1bGF0ZSBpdC4KPiAKPiBBY2tub2xlZGdlbWVudHM6IFRoaXMgcGF0Y2gg aXMgYmFzZWQgb24gYW4gZWFybGllciB2ZXJzaW9uIGJ5IFN0ZXZlbgo+IFJvc3RlZHQuIFRoZSB1 c2Ugb2YgYXRvbWljIGluY3JlbWVudC9kZWNyZW1lbnQgd2FzIHN1Z2dlc3RlZCBieSBQZXRyCj4g TWxhZGVrLgo+IAo+IExpbms6IGh0dHA6Ly9sa21sLmtlcm5lbC5vcmcvci83MTdlNjMzNy1lN2E2 LTdhOTItMWMxYi04OTI5YTI1Njk2YjVAc3VzZS5kZQo+IFNpZ25lZC1vZmYtYnk6IFRob21hcyBa aW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmRlPgoKUGF0Y2ggcXVldWVkIGZvciA0LjE5ICh3 LyA8YXNtL2F0b21pYy5oPiAtPiA8bGludXgvYXRvbWljLmg+IGZpeHVwKSwgdGhhbmtzLgoKQmVz dCByZWdhcmRzLAotLQpCYXJ0bG9taWVqIFpvbG5pZXJraWV3aWN6ClNhbXN1bmcgUiZEIEluc3Rp dHV0ZSBQb2xhbmQKU2Ftc3VuZyBFbGVjdHJvbmljcwoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vZHJpLWRldmVsCg==