From: Anton Ivanov <anton.ivanov@cambridgegreys.com>
To: linux-um@lists.infradead.org
Cc: richard@nod.at, 938962@bugs.debian.org
Subject: Re: [PATCH] um: Fix pcap and vde driver builds
Date: Wed, 16 Oct 2019 10:12:20 +0100 [thread overview]
Message-ID: <2645291b-0bc4-86e9-bba1-4866a00d6650@cambridgegreys.com> (raw)
In-Reply-To: <20191016075343.28564-2-anton.ivanov@cambridgegreys.com>
On 16/10/2019 08:53, Anton Ivanov wrote:
> Signed-off-by: Anton Ivanov <anton.ivanov@cambridgegreys.com>
> ---
> arch/um/drivers/Makefile | 8 ++++++++
> scripts/link-vmlinux.sh | 2 +-
> 2 files changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/arch/um/drivers/Makefile b/arch/um/drivers/Makefile
> index 693319839f69..34355057ec85 100644
> --- a/arch/um/drivers/Makefile
> +++ b/arch/um/drivers/Makefile
> @@ -24,6 +24,14 @@ LDFLAGS_vde.o := -r $(shell $(CC) $(CFLAGS) -print-file-name=libvdeplug.a)
>
> targets := pcap_kern.o pcap_user.o vde_kern.o vde_user.o
>
> +ifeq ($(CONFIG_UML_NET_PCAP),y)
> + export UML_EXTRA_LIBS += -lpcap
> +endif
> +ifeq ($(CONFIG_UML_NET_VDE),y)
> + export UML_EXTRA_LIBS += -lvde -lvdeplug
> +endif
> +
> +
> $(obj)/pcap.o: $(obj)/pcap_kern.o $(obj)/pcap_user.o
> $(LD) -r -dp -o $@ $^ $(ld_flags)
>
> diff --git a/scripts/link-vmlinux.sh b/scripts/link-vmlinux.sh
> index 915775eb2921..d3e6a6cdfc13 100755
> --- a/scripts/link-vmlinux.sh
> +++ b/scripts/link-vmlinux.sh
> @@ -86,7 +86,7 @@ vmlinux_link()
> ${CC} ${CFLAGS_vmlinux} -o ${2} \
> -Wl,-T,${lds} \
> ${objects} \
> - -lutil -lrt -lpthread
> + -lutil -lrt -lpthread ${UML_EXTRA_LIBS}
> rm -f linux
> fi
> }
This will not work as advertised unfortunately - I have to write out the
libs list somewhere and load it again in the link script instead of
passing it as an environment variable.
A fixed patch will follow shortly.
--
Anton R. Ivanov
Cambridgegreys Limited. Registered in England. Company Number 10273661
https://www.cambridgegreys.com/
_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
prev parent reply other threads:[~2019-10-16 9:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-16 7:53 Build fix for VDE and PCAP drivers Anton Ivanov
2019-10-16 7:53 ` [PATCH] um: Fix pcap and vde driver builds Anton Ivanov
2019-10-16 9:12 ` Anton Ivanov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2645291b-0bc4-86e9-bba1-4866a00d6650@cambridgegreys.com \
--to=anton.ivanov@cambridgegreys.com \
--cc=938962@bugs.debian.org \
--cc=linux-um@lists.infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.