From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v3 06/16] vfio: generalize
	pci_vfio_has_supported_extensions
Date: Sun, 10 Jul 2016 19:36:57 +0200
Message-ID: <2658506.JKWTbPl3g7@xps13>
References: <1467645411-15494-1-git-send-email-viktorin@rehivetech.com>
 <1467645411-15494-7-git-send-email-viktorin@rehivetech.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org, Anatoly Burakov <anatoly.burakov@intel.com>,
 David Marchand <david.marchand@6wind.com>, Keith Wiles <keith.wiles@intel.com>,
 Santosh Shukla <sshukla@mvista.com>,
 Stephen Hemminger <stephen@networkplumber.org>,
 Shreyansh Jain <shreyansh.jain@nxp.com>
To: Jan Viktorin <viktorin@rehivetech.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48])
 by dpdk.org (Postfix) with ESMTP id D12B419F5
 for <dev@dpdk.org>; Sun, 10 Jul 2016 19:36:59 +0200 (CEST)
Received: by mail-wm0-f48.google.com with SMTP id o80so23860224wme.1
 for <dev@dpdk.org>; Sun, 10 Jul 2016 10:36:59 -0700 (PDT)
In-Reply-To: <1467645411-15494-7-git-send-email-viktorin@rehivetech.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

There is a small error in this patch:

2016-07-04 17:16, Jan Viktorin:
> The pci_vfio_has_supported_extensions is not PCI-specific and it is a=
 private
> function of the eal_pci_vfio.c. We just rename the function and make =
it
> available even for non-PCI devices.
|...]
|> --- a/lib/librte_eal/linuxapp/eal/eal_vfio.c
> +++ b/lib/librte_eal/linuxapp/eal/eal_vfio.c
> @@ -62,6 +62,39 @@ vfio_set_iommu_type(int vfio_container_fd) {
>  }
> =20
>  int
> +vfio_has_supported_extensions(int vfio_container_fd) {
> +=09int ret;
> +=09unsigned idx, n_extensions =3D 0;
> +=09for (idx =3D 0; idx < RTE_DIM(iommu_types); idx++) {
> +=09=09const struct vfio_iommu_type *t =3D &iommu_types[idx];
> +
> +=09=09ret =3D ioctl(vfio_container_fd, VFIO_CHECK_EXTENSION,
> +=09=09=09=09t->type_id);
> +=09=09if (ret < 0) {
> +=09=09=09RTE_LOG(ERR, EAL, "  could not get IOMMU type, "
> +=09=09=09=09"error %i (%s)\n", errno,
> +=09=09=09=09strerror(errno));
> +=09=09=09close(vfio_container_fd);

lib/librte_eal/linuxapp/eal/eal_vfio.c:77:4: error:
implicit declaration of function =E2=80=98close=E2=80=99

It is fixed in patch 8 with "#include <unistd.h>".