From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB121C433DB for ; Wed, 30 Dec 2020 11:21:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B711420759 for ; Wed, 30 Dec 2020 11:21:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726356AbgL3LVR (ORCPT ); Wed, 30 Dec 2020 06:21:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52678 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726290AbgL3LVQ (ORCPT ); Wed, 30 Dec 2020 06:21:16 -0500 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F7D4C061799 for ; Wed, 30 Dec 2020 03:20:36 -0800 (PST) Received: by mail-wm1-x32c.google.com with SMTP id c133so4728731wme.4 for ; Wed, 30 Dec 2020 03:20:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=colorfullife-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=vlIz8qKLh0Mw7iBe3bCfYd5T/mgfgcIicaaUGuMkXoc=; b=zMixGQS5qZCTipik7qggixwFj+pf/zIdzivxDO7JRRn7YFX6rkiw6muEsaxov0Gi/R 4DQCgZ6Pf+5Lei7EgPLF/bf8CV4ZQbDmCIm5q7MANMkUisdnjIuudE+iQ5e9mckT7jVf ruQ0/gvRsF2lqZug9kUpcgbx7FFYKhSwiionCmSk+dB2alowxzr6gG6AayY9/lRNhRO1 xpkCmi/dS607YMIJBKCBemnr5Lo5KNEScb1WpaDUZO/t9V9gQT3pjlpbndDI388UnRNY UlwexZEs5X4+tMCjiEpIWSYN31WfWNjVJhjLIna/vRALJNB3OWWpeG8dsffj0Kjvosp9 Q8Qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=vlIz8qKLh0Mw7iBe3bCfYd5T/mgfgcIicaaUGuMkXoc=; b=cKk/Km34Wvk4dLlSr68nL++xO5NFIJeLKqRb2SNaF6OSftWcXUxKEWlcxKDCBv9+mV jxo8sne299QXKGsC/wHt1gckza7OMYMu8ctn15jF3HmCX+UGj6mDjY1fDIu5CAG/vR1+ dLut/72tQ/BDqw0rd6wTsRLD/RChUb0dnY9WxKdV5NQygWSCAKkzuEtC+r5WkTtGLM0W zeq49/DbRJUkPzoDMEyj/r/JTaNCkzIvE/SldzSzsi5Her6s6tN9yh+pX4sLSXv/AXpe 5l1xtGJkIALDLKmPsBbjBaL3d+QfaAcaxJBbOevfvUlaKPiXkyp0EkQR5kLtu2i0kDxq QzuQ== X-Gm-Message-State: AOAM531amgSQkqShOFLiOi8haSS4tHqqqRjVHIGAsvXnvQEc4obQqP50 gCXVbWfYIlm1TUd04MWPhdt8ig== X-Google-Smtp-Source: ABdhPJyuVaSEgEKR6ROcrbmwr1F4I0ENAbiU1rryjoaFy8pSSgVAFslJAX4huipx95sguz43AKRwTA== X-Received: by 2002:a1c:e083:: with SMTP id x125mr7466613wmg.0.1609327234996; Wed, 30 Dec 2020 03:20:34 -0800 (PST) Received: from localhost.localdomain (p200300d9970348005c94200a58b3c908.dip0.t-ipconnect.de. [2003:d9:9703:4800:5c94:200a:58b3:c908]) by smtp.googlemail.com with ESMTPSA id v20sm6781622wml.34.2020.12.30.03.20.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Dec 2020 03:20:34 -0800 (PST) Subject: Re: [PATCH] semctl.2: Correct SEM_STAT_ANY description To: Yang Xu Cc: "Alejandro Colomar (mailing lists, readonly)" , mtk.manpages@gmail.com, Davidlohr Bueso , linux-man@vger.kernel.org, Joe Lawrence , Robert Kettler , "Eric W. Biederman" , Kees Cook , Michal Hocko References: <1608616543-21436-1-git-send-email-xuyang2018.jy@cn.fujitsu.com> <746deff0-e919-173b-25f6-34fc465a7ba0@gmail.com> <5FEBDFF3.7020606@cn.fujitsu.com> From: Manfred Spraul Message-ID: <265f82a2-42e7-45a4-1f80-8d24d66fceda@colorfullife.com> Date: Wed, 30 Dec 2020 12:20:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <5FEBDFF3.7020606@cn.fujitsu.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-man@vger.kernel.org On 12/30/20 3:03 AM, Yang Xu wrote: > Hi Manfred >> Hi, >> >> >> On 12/22/20 12:55 PM, Alejandro Colomar (mailing lists; readonly) wrote: >>> Hi Yang, >>> >>> It looks good to me. >>> I'll add a few people that might want to comment. >> >> The code returns a semid_ds structure, and if I take strace as reference >> implementation, then user space expects a semid_ds as well. >> https://github.com/strace/strace/commit/8f0870a780bfd8cd9a91c3b7ad05baccda10bc84 >> >> >> >> In addition, the current page is self-inconsistent: seminfo doesn't >> contain sem_perm. > semctl manpage doesn't say seminfo contain sem_perm. Or, I miss something? The current man page says that SEM_STAT_ANY returns a seminfo structure, without checking sem_perm. This is self-inconsistent: struct seminfo contains global (per-namespace) information, sem_perm.mode is a per-array information. I.e.: It is clear that the man page needs to be updated, and not the code. > $rpm -qf /usr/share/man/man2/semctl.2.gz > $ man-pages-5.07-3.fc33.noarch >        SEM_STAT_ANY (Linux-specific, since Linux 4.17) >               Return a seminfo structure containing the same > information as for SEM_STAT.  However, sem_perm.mode is not checked > for read access for semid meaning >               that any user can employ this operation (just as any > user may read /proc/sysvipc/sem to obtain the same information). > >