From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A422FC433FE for ; Mon, 18 Oct 2021 10:41:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8632E610A3 for ; Mon, 18 Oct 2021 10:41:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230350AbhJRKnK convert rfc822-to-8bit (ORCPT ); Mon, 18 Oct 2021 06:43:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51536 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229590AbhJRKnH (ORCPT ); Mon, 18 Oct 2021 06:43:07 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 03E48C061768 for ; Mon, 18 Oct 2021 03:40:55 -0700 (PDT) Received: from lupine.hi.pengutronix.de ([2001:67c:670:100:3ad5:47ff:feaf:1a17] helo=lupine) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mcQ4U-0002SF-9S; Mon, 18 Oct 2021 12:40:46 +0200 Received: from pza by lupine with local (Exim 4.92) (envelope-from ) id 1mcQ4T-0006AV-MT; Mon, 18 Oct 2021 12:40:45 +0200 Message-ID: <26612614156b53a3c1798f86177a69f613f210b7.camel@pengutronix.de> Subject: Re: [PATCH v3 1/2] dt-bindings: reset: Add lan966x support From: Philipp Zabel To: Horatiu Vultur Cc: robh+dt@kernel.org, andrew@lunn.ch, lars.povlsen@microchip.com, Steen.Hegelund@microchip.com, UNGLinuxDriver@microchip.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Date: Mon, 18 Oct 2021 12:40:45 +0200 In-Reply-To: <20211015141404.5eiylskcfy2fxi42@soft-dev3-1.localhost> References: <20211013073807.2282230-1-horatiu.vultur@microchip.com> <20211013073807.2282230-2-horatiu.vultur@microchip.com> <838af7b574968fc55d517a3becede5fa106ed896.camel@pengutronix.de> <20211014152016.wuwaesswc5iiil42@soft-dev3-1.localhost> <20211015141404.5eiylskcfy2fxi42@soft-dev3-1.localhost> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2021-10-15 at 16:14 +0200, Horatiu Vultur wrote: [...] > Were you thinking to have just another reset driver('phy-reset') and then > the switch to refer to both of them? > I like this idea because then is more clear what is doing each driver. Yes, especially if there is no requirement to handle switch and PHY resets at the same time: this would allow the sgpio driver to trigger the required switch reset without already releasing the PHYs from reset. regards Philipp From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12D95C433F5 for ; Mon, 18 Oct 2021 11:04:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D34D660F56 for ; Mon, 18 Oct 2021 11:04:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D34D660F56 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DPVlo5uS9yTA8ziRo7tGIUHqXbs3V7glMUplIjjEgmM=; b=MHZ+RIMBwugHAs uCBniJFVRxY4tESp7FozfJiM/Gl8NuwzTsCQIRFkIRu18Cwb8O6TW5ErVbluwQwCGQo9NNVRydKGZ wrnHh76siOU6lCaFR3EIJB7vb/7idM5N9Gz+K8B/w3IaTq5/y7zvmU3PZfD1AYvArRZzNeBbVKCkF Pm7O1Hc1oR76H5CrsgyraN2nyObLlAew8/rakivBBNxqkpXFSiHn3qouYro0A2WCSiADdNoyb8jDM R3nvneswKpi4yO5mW8rLUdXkrrcm4ZlYAacOMjeOkH6lcHD09KyN24yYxAu+ixxgWv+lxtbIXFzGl hm1TxFx+j7u1sDcuJcEA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mcQPS-00FDSp-OR; Mon, 18 Oct 2021 11:02:27 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mcQ4e-00F4l8-TO for linux-arm-kernel@lists.infradead.org; Mon, 18 Oct 2021 10:40:58 +0000 Received: from lupine.hi.pengutronix.de ([2001:67c:670:100:3ad5:47ff:feaf:1a17] helo=lupine) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mcQ4U-0002SF-9S; Mon, 18 Oct 2021 12:40:46 +0200 Received: from pza by lupine with local (Exim 4.92) (envelope-from ) id 1mcQ4T-0006AV-MT; Mon, 18 Oct 2021 12:40:45 +0200 Message-ID: <26612614156b53a3c1798f86177a69f613f210b7.camel@pengutronix.de> Subject: Re: [PATCH v3 1/2] dt-bindings: reset: Add lan966x support From: Philipp Zabel To: Horatiu Vultur Cc: robh+dt@kernel.org, andrew@lunn.ch, lars.povlsen@microchip.com, Steen.Hegelund@microchip.com, UNGLinuxDriver@microchip.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Date: Mon, 18 Oct 2021 12:40:45 +0200 In-Reply-To: <20211015141404.5eiylskcfy2fxi42@soft-dev3-1.localhost> References: <20211013073807.2282230-1-horatiu.vultur@microchip.com> <20211013073807.2282230-2-horatiu.vultur@microchip.com> <838af7b574968fc55d517a3becede5fa106ed896.camel@pengutronix.de> <20211014152016.wuwaesswc5iiil42@soft-dev3-1.localhost> <20211015141404.5eiylskcfy2fxi42@soft-dev3-1.localhost> User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211018_034057_021508_37C7A3E0 X-CRM114-Status: GOOD ( 10.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 2021-10-15 at 16:14 +0200, Horatiu Vultur wrote: [...] > Were you thinking to have just another reset driver('phy-reset') and then > the switch to refer to both of them? > I like this idea because then is more clear what is doing each driver. Yes, especially if there is no requirement to handle switch and PHY resets at the same time: this would allow the sgpio driver to trigger the required switch reset without already releasing the PHYs from reset. regards Philipp _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel