All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: Mikael Magnusson <mikael.kernel@lists.m7n.se>,
	netdev@vger.kernel.org, Martin KaFai Lau <kafai@fb.com>,
	Wei Wang <weiwan@google.com>
Subject: Re: IPv6 PMTU discovery fails with source-specific routing
Date: Mon, 13 May 2019 21:35:37 -0600	[thread overview]
Message-ID: <2667a075-7a51-d1e0-c4e7-cf0d011784b9@gmail.com> (raw)
In-Reply-To: <71e7331f-d528-430e-f880-e995ff53d362@lists.m7n.se>

On 5/13/19 1:22 PM, Mikael Magnusson wrote:
> Hello list,
> 
> I think I have found a regression in 4.15+ kernels. IPv6 PMTU discovery
> doesn't seem to work with source-specific routing (AKA source-address
> dependent routing, SADR).
> 
> I made a test script (see attachment). It sets up a test environment
> with three network namespaces (a, b and c) using SADR. The link between
> b and c is configured with MTU 1280. It then runs a ping test with large
> packets.
> 
> I have tested a couple of kernels on Ubuntu 19.04 with the following
> results.
> 
> mainline 4.14.117-0414117-generic SUCCESS
> ubuntu   4.15.0-1036-oem          FAIL
> mainline 5.1.0-050100-generic     FAIL
> 

git bisect shows

good: 38fbeeeeccdb38d0635398e8e344d245f6d8dc52
bad:  2b760fcf5cfb34e8610df56d83745b2b74ae1379

Those are back to back commits so
    2b760fcf5cfb ipv6: hook up exception table to store dst cache

has to be the bad commit.

Your patch may work, but does not seem logical relative to code at the
time of 4.15 and the commit that caused the failure. cc'ing authors of
the changes referenced above.

  reply	other threads:[~2019-05-14  3:35 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-13 19:22 IPv6 PMTU discovery fails with source-specific routing Mikael Magnusson
2019-05-14  3:35 ` David Ahern [this message]
2019-05-14  6:12   ` Wei Wang
2019-05-14 14:33     ` Stefano Brivio
2019-05-14 19:33       ` Wei Wang
2019-05-15 15:43         ` David Ahern
2019-05-15 18:06         ` Martin Lau
2019-05-15 18:31           ` Wei Wang
2019-05-15 21:54             ` Martin Lau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2667a075-7a51-d1e0-c4e7-cf0d011784b9@gmail.com \
    --to=dsahern@gmail.com \
    --cc=kafai@fb.com \
    --cc=mikael.kernel@lists.m7n.se \
    --cc=netdev@vger.kernel.org \
    --cc=weiwan@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.