Re: [PATCH 3/7] perf report: create real callchain entries for inlined frames

From: Milian Wolff <milian.wolff@kdab.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	David Ahern <dsahern@gmail.com>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Yao Jin <yao.jin@linux.intel.com>,
	kernel-team@lge.com
Subject: Re: [PATCH 3/7] perf report: create real callchain entries for inlined frames
Date: Wed, 24 May 2017 13:41:54 +0200	[thread overview]
Message-ID: <2671838.bjlk31QMkC@milian-kdab2> (raw)
In-Reply-To: <20170522121946.GD20009@sejong>

[-- Attachment #1: Type: text/plain, Size: 676 bytes --]

On Monday, May 22, 2017 2:19:46 PM CEST Namhyung Kim wrote:
> On Thu, May 18, 2017 at 09:34:07PM +0200, Milian Wolff wrote:
> > +
> > +	if (strcmp(funcname, base_sym->name) == 0) {
> > +		// reuse the real, existing symbol
> 
> I don't know whether it's required by coding style guide but please
> use C-style block comment if possible (especially for multiline comments).

OK. Since the patch check script didn't complain I thought it was OK to use 
this style here.

I'll update the patch series accordingly.

Thanks

-- 
Milian Wolff | milian.wolff@kdab.com | Software Engineer
KDAB (Deutschland) GmbH&Co KG, a KDAB Group company
Tel: +49-30-521325470
KDAB - The Qt Experts

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 3826 bytes --]