From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751696AbcGSS47 (ORCPT ); Tue, 19 Jul 2016 14:56:59 -0400 Received: from gloria.sntech.de ([95.129.55.99]:38357 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750998AbcGSS44 convert rfc822-to-8bit (ORCPT ); Tue, 19 Jul 2016 14:56:56 -0400 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Uwe =?ISO-8859-1?Q?Kleine=2DK=F6nig?= Cc: Brian Norris , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Brian Norris , linux-arm-kernel@lists.infradead.org, Caesar Wang Subject: Re: [PATCH] arm64: dts: rockchip: add spiX aliases for rk3399 Date: Tue, 19 Jul 2016 20:56:47 +0200 Message-ID: <2679180.WfB7C6de5F@diego> User-Agent: KMail/4.14.10 (Linux/4.5.0-2-amd64; KDE/4.14.14; x86_64; ; ) In-Reply-To: <20160719063955.GE5368@pengutronix.de> References: <1468545873-134339-1-git-send-email-briannorris@chromium.org> <20160719063955.GE5368@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="iso-8859-1" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Uwe, Am Dienstag, 19. Juli 2016, 08:39:55 schrieb Uwe Kleine-König: > On Thu, Jul 14, 2016 at 06:24:33PM -0700, Brian Norris wrote: > > It's nicer to see this: > > # ls -l /sys/bus/spi/devices/ > > total 0 > > lrwxrwxrwx 1 root root 0 Dec 31 1969 spi0.0 -> > > ../../../devices/platform/ff1c0000.spi/spi_master/spi0/spi0.0 > > lrwxrwxrwx 1 root root 0 Dec 31 1969 spi1.0 -> > > ../../../devices/platform/ff1d0000.spi/spi_master/spi1/spi1.0 > > lrwxrwxrwx 1 root root 0 Dec 31 1969 spi2.0 -> > > ../../../devices/platform/ff1e0000.spi/spi_master/spi2/spi2.0 > > lrwxrwxrwx 1 root root 0 Dec 31 1969 spi5.0 -> > > ../../../devices/platform/ff200000.spi/spi_master/spi5/spi5.0> > > than this: > > # ls -l /sys/bus/spi/devices/ > > total 0 > > lrwxrwxrwx 1 root root 0 Dec 31 1969 spi32763.0 -> > > ../../../devices/platform/ff200000.spi/spi_master/spi32763/spi32763.0 > > lrwxrwxrwx 1 root root 0 Dec 31 1969 spi32764.0 -> > > ../../../devices/platform/ff1e0000.spi/spi_master/spi32764/spi32764.0 > > lrwxrwxrwx 1 root root 0 Dec 31 1969 spi32765.0 -> > > ../../../devices/platform/ff1d0000.spi/spi_master/spi32765/spi32765.0 > > lrwxrwxrwx 1 root root 0 Dec 31 1969 spi32766.0 -> > > ../../../devices/platform/ff1c0000.spi/spi_master/spi32766/spi32766.0> > > With the latter, it's much clearer which bus devices are on. > > > > Signed-off-by: Brian Norris > > --- > > > > arch/arm64/boot/dts/rockchip/rk3399.dtsi | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi > > b/arch/arm64/boot/dts/rockchip/rk3399.dtsi index > > 4c84229789ef..b04abbfd4898 100644 > > --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi > > +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > > @@ -70,6 +70,12 @@ > > > > serial2 = &uart2; > > serial3 = &uart3; > > serial4 = &uart4; > > > > + spi0 = &spi0; > > + spi1 = &spi1; > > + spi2 = &spi2; > > + spi3 = &spi3; > > + spi4 = &spi4; > > + spi5 = &spi5; > > Note that Rob Herring (with his dt-maintainer hat on) doesn't like these > aliases. > See for example: > http://mid.gmane.org/20160705140546.GA10601@rob-hp-laptop thanks for the heads up on this. I've dropped this patch again. Thanks Heiko From mboxrd@z Thu Jan 1 00:00:00 1970 From: heiko@sntech.de (Heiko =?ISO-8859-1?Q?St=FCbner?=) Date: Tue, 19 Jul 2016 20:56:47 +0200 Subject: [PATCH] arm64: dts: rockchip: add spiX aliases for rk3399 In-Reply-To: <20160719063955.GE5368@pengutronix.de> References: <1468545873-134339-1-git-send-email-briannorris@chromium.org> <20160719063955.GE5368@pengutronix.de> Message-ID: <2679180.WfB7C6de5F@diego> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Uwe, Am Dienstag, 19. Juli 2016, 08:39:55 schrieb Uwe Kleine-K?nig: > On Thu, Jul 14, 2016 at 06:24:33PM -0700, Brian Norris wrote: > > It's nicer to see this: > > # ls -l /sys/bus/spi/devices/ > > total 0 > > lrwxrwxrwx 1 root root 0 Dec 31 1969 spi0.0 -> > > ../../../devices/platform/ff1c0000.spi/spi_master/spi0/spi0.0 > > lrwxrwxrwx 1 root root 0 Dec 31 1969 spi1.0 -> > > ../../../devices/platform/ff1d0000.spi/spi_master/spi1/spi1.0 > > lrwxrwxrwx 1 root root 0 Dec 31 1969 spi2.0 -> > > ../../../devices/platform/ff1e0000.spi/spi_master/spi2/spi2.0 > > lrwxrwxrwx 1 root root 0 Dec 31 1969 spi5.0 -> > > ../../../devices/platform/ff200000.spi/spi_master/spi5/spi5.0> > > than this: > > # ls -l /sys/bus/spi/devices/ > > total 0 > > lrwxrwxrwx 1 root root 0 Dec 31 1969 spi32763.0 -> > > ../../../devices/platform/ff200000.spi/spi_master/spi32763/spi32763.0 > > lrwxrwxrwx 1 root root 0 Dec 31 1969 spi32764.0 -> > > ../../../devices/platform/ff1e0000.spi/spi_master/spi32764/spi32764.0 > > lrwxrwxrwx 1 root root 0 Dec 31 1969 spi32765.0 -> > > ../../../devices/platform/ff1d0000.spi/spi_master/spi32765/spi32765.0 > > lrwxrwxrwx 1 root root 0 Dec 31 1969 spi32766.0 -> > > ../../../devices/platform/ff1c0000.spi/spi_master/spi32766/spi32766.0> > > With the latter, it's much clearer which bus devices are on. > > > > Signed-off-by: Brian Norris > > --- > > > > arch/arm64/boot/dts/rockchip/rk3399.dtsi | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi > > b/arch/arm64/boot/dts/rockchip/rk3399.dtsi index > > 4c84229789ef..b04abbfd4898 100644 > > --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi > > +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > > @@ -70,6 +70,12 @@ > > > > serial2 = &uart2; > > serial3 = &uart3; > > serial4 = &uart4; > > > > + spi0 = &spi0; > > + spi1 = &spi1; > > + spi2 = &spi2; > > + spi3 = &spi3; > > + spi4 = &spi4; > > + spi5 = &spi5; > > Note that Rob Herring (with his dt-maintainer hat on) doesn't like these > aliases. > See for example: > http://mid.gmane.org/20160705140546.GA10601 at rob-hp-laptop thanks for the heads up on this. I've dropped this patch again. Thanks Heiko