From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C2CA3C433F5 for ; Mon, 3 Oct 2022 07:55:24 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4C50610E243; Mon, 3 Oct 2022 07:55:23 +0000 (UTC) Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by gabe.freedesktop.org (Postfix) with ESMTPS id A115F10E223 for ; Mon, 3 Oct 2022 07:55:17 +0000 (UTC) Received: by mail-lj1-x22d.google.com with SMTP id d26so2604003ljl.2 for ; Mon, 03 Oct 2022 00:55:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=AWWik7Ro2WMW3rP3zuTmOKWCoTINy486UbZe1BIOJ30=; b=jCc986gDVQOoJgz1tTSNWFlwcc7cwQUEYkuAkDH+Wwv/85G7GPheB8Q/gKpngA7LoW jOUYnmTNK9Idr/6yd2PkrpuIlZSg1F+cndMsuV0XBsl+0Mw1iRZyzH1rtt9Bp6zbbdsU yJqrpV9nZPfd87H+S89HyLHj/kF/gUF0AOb1QbD0U6Uq94NExN7tQ9MeWNLW3IwwPkVX E8L+D0XW1A/m/Ih//TlBtd+5c4aG8gE40FGFOAsiSJ60ySelzvnOEaqIIZ3NRyyfjh7l fNgXk8O7szMe1hqfPpMYHyhTOyvNJ3eEvqskNibXrPVVSPytOuLWwnAnBgoFdHNeRQxf GevA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=AWWik7Ro2WMW3rP3zuTmOKWCoTINy486UbZe1BIOJ30=; b=P4oiuUvrJckeZ4K+v2bO1dGxeCCDahDqJ14UpOJToBMFoMopu9SNTHNgSRUZby0ReC LBjoIf86e16go3DQKCaOArDlaYjmv/etZKGMXqgrCMpS4qbAdd31yai/qKFGn7IpieUx O+n+gy6ZegiBZjgAawelLd/JtLtXjW6l9x36O0ZDRz8C2/CfV8nb9neOYFkHpxAEWzMB fbcUI0sLYpYdNLTmUYVmuiRZtuGaVNjXO3nxEH9K8hfPkuM47zxAGRcRBMgXZwBLxWDQ pmOfKEKWe+9nG+VDGU5f2ZDG933464sMH4L0DbSaf6y3I/Wbzq84i8evTG5qzCJbKq4G Yu/w== X-Gm-Message-State: ACrzQf3GSV4s+k4mM/xcF0j+8xAvw5Wuql4A5kgFF8lDAW15uW4Iwc0d SJib9WRmiLQtaXEiaNAvX2Qplw== X-Google-Smtp-Source: AMsMyM6LazJpQxrBqhJQfb1vXbRFSUvDVP+Ts25muHd1R+0kQHdtCegacUeEqpXvowYR45JtZpfUqQ== X-Received: by 2002:a05:651c:11cc:b0:26c:16cd:f1ae with SMTP id z12-20020a05651c11cc00b0026c16cdf1aemr5941193ljo.59.1664783715938; Mon, 03 Oct 2022 00:55:15 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id s7-20020a2eb8c7000000b0026ddf39da47sm194830ljp.81.2022.10.03.00.55.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Oct 2022 00:55:15 -0700 (PDT) Message-ID: <267c17b6-070c-8b77-8f52-75368c74d59d@linaro.org> Date: Mon, 3 Oct 2022 09:55:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v7 05/12] dt-bindings: display/msm: move common MDSS properties to mdss-common.yaml Content-Language: en-US To: Dmitry Baryshkov , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Clark , Sean Paul , Abhinav Kumar , Rob Herring , Krzysztof Kozlowski References: <20220915133742.115218-1-dmitry.baryshkov@linaro.org> <20220915133742.115218-6-dmitry.baryshkov@linaro.org> <02b60bf8-70ac-eb7b-33d7-1c9b7a6f0a54@linaro.org> <168a46c3-2c0e-cd5c-e6f1-1e072c67d162@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, David Airlie , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, Stephen Boyd , freedreno@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 23/09/2022 22:32, Dmitry Baryshkov wrote: > On 22/09/2022 15:28, Krzysztof Kozlowski wrote: >> On 22/09/2022 13:46, Dmitry Baryshkov wrote: >>>>> - ranges: true >>>>> + maxItems: 2 >>>>> >>>>> interconnects: >>>>> - items: >>>>> - - description: Interconnect path from mdp0 port to the data bus >>>>> - - description: Interconnect path from mdp1 port to the data bus >>>>> + maxItems: 2 >>>> >>>> I think this is not equivalent now, because you have in total minItems:1 >>>> and maxItems:2, while in past minItems was 2. >>> >>> This means that I should have minItems:2, maxItems:2, which, if I got it >>> right, is frowned upon. Let me doublecheck though if it works as expected. >> >> It is frowned upon only if it is alone, because for missing minItems, >> maxItems implies minItems. Here you have minItems in other schema, so >> there is no such case > > Well, I just checked, the schema will throw an error if I put a single > interconnects or iommus entry. If I understand correctly these two > clauses are evaluated separately. So, the dpu-common's clause tells > minItems:1, maxItems:2. The platform schema file contains just > maxItems:2, which implicitly adds minItems:2 to _this_ clause. > > Thus I think I'll leave this part as is. Thanks for checking. It's good then. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B96CC433FE for ; Mon, 3 Oct 2022 08:22:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230333AbiJCIWS (ORCPT ); Mon, 3 Oct 2022 04:22:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46330 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229687AbiJCIVy (ORCPT ); Mon, 3 Oct 2022 04:21:54 -0400 Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F9CC79A71 for ; Mon, 3 Oct 2022 00:55:53 -0700 (PDT) Received: by mail-lj1-x231.google.com with SMTP id b6so10835480ljr.10 for ; Mon, 03 Oct 2022 00:55:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=AWWik7Ro2WMW3rP3zuTmOKWCoTINy486UbZe1BIOJ30=; b=jCc986gDVQOoJgz1tTSNWFlwcc7cwQUEYkuAkDH+Wwv/85G7GPheB8Q/gKpngA7LoW jOUYnmTNK9Idr/6yd2PkrpuIlZSg1F+cndMsuV0XBsl+0Mw1iRZyzH1rtt9Bp6zbbdsU yJqrpV9nZPfd87H+S89HyLHj/kF/gUF0AOb1QbD0U6Uq94NExN7tQ9MeWNLW3IwwPkVX E8L+D0XW1A/m/Ih//TlBtd+5c4aG8gE40FGFOAsiSJ60ySelzvnOEaqIIZ3NRyyfjh7l fNgXk8O7szMe1hqfPpMYHyhTOyvNJ3eEvqskNibXrPVVSPytOuLWwnAnBgoFdHNeRQxf GevA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=AWWik7Ro2WMW3rP3zuTmOKWCoTINy486UbZe1BIOJ30=; b=iF82aWPxzpbiMXHy9mMJGXkcwDACl7cdUWz7+c2r2Q4G/x1+ZOwX1kgR5ljAgM+e5h Fw44idWglLgHpmUxTWJGXDxMszEzAmcDZhl5jKC6Hg1GvDflWW30co48xixEabSSkws6 vTih9d01WcBadi2bHq3w6xKQ/yJGz/UzwKuTdPqNgiJm1v7xv6ORyPtdjrJbC5J59wOB oN52IbG4tVTzoYg6AYcG/rxwChLv6E1+95qDcMrcp3/z3XDb0O/VK9UDJJnV1ft3eiVf K+rpr0XXEF7iyQOfcGBq69ZpBn6USqJOueoE4Hk3/wipY98ttCwzhOI3deLeCDUKDdyF XS5g== X-Gm-Message-State: ACrzQf1zqEZcwki4Vpr+aBA2/NbZ+KndFbzGoZjePfd+9rS1GweN+0r2 AeLe98vZXEqxqqOyZhfDSAUHHA== X-Google-Smtp-Source: AMsMyM6LazJpQxrBqhJQfb1vXbRFSUvDVP+Ts25muHd1R+0kQHdtCegacUeEqpXvowYR45JtZpfUqQ== X-Received: by 2002:a05:651c:11cc:b0:26c:16cd:f1ae with SMTP id z12-20020a05651c11cc00b0026c16cdf1aemr5941193ljo.59.1664783715938; Mon, 03 Oct 2022 00:55:15 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id s7-20020a2eb8c7000000b0026ddf39da47sm194830ljp.81.2022.10.03.00.55.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Oct 2022 00:55:15 -0700 (PDT) Message-ID: <267c17b6-070c-8b77-8f52-75368c74d59d@linaro.org> Date: Mon, 3 Oct 2022 09:55:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v7 05/12] dt-bindings: display/msm: move common MDSS properties to mdss-common.yaml Content-Language: en-US To: Dmitry Baryshkov , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Clark , Sean Paul , Abhinav Kumar , Rob Herring , Krzysztof Kozlowski Cc: Stephen Boyd , David Airlie , Daniel Vetter , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org References: <20220915133742.115218-1-dmitry.baryshkov@linaro.org> <20220915133742.115218-6-dmitry.baryshkov@linaro.org> <02b60bf8-70ac-eb7b-33d7-1c9b7a6f0a54@linaro.org> <168a46c3-2c0e-cd5c-e6f1-1e072c67d162@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 23/09/2022 22:32, Dmitry Baryshkov wrote: > On 22/09/2022 15:28, Krzysztof Kozlowski wrote: >> On 22/09/2022 13:46, Dmitry Baryshkov wrote: >>>>> - ranges: true >>>>> + maxItems: 2 >>>>> >>>>> interconnects: >>>>> - items: >>>>> - - description: Interconnect path from mdp0 port to the data bus >>>>> - - description: Interconnect path from mdp1 port to the data bus >>>>> + maxItems: 2 >>>> >>>> I think this is not equivalent now, because you have in total minItems:1 >>>> and maxItems:2, while in past minItems was 2. >>> >>> This means that I should have minItems:2, maxItems:2, which, if I got it >>> right, is frowned upon. Let me doublecheck though if it works as expected. >> >> It is frowned upon only if it is alone, because for missing minItems, >> maxItems implies minItems. Here you have minItems in other schema, so >> there is no such case > > Well, I just checked, the schema will throw an error if I put a single > interconnects or iommus entry. If I understand correctly these two > clauses are evaluated separately. So, the dpu-common's clause tells > minItems:1, maxItems:2. The platform schema file contains just > maxItems:2, which implicitly adds minItems:2 to _this_ clause. > > Thus I think I'll leave this part as is. Thanks for checking. It's good then. Best regards, Krzysztof