* [PATCH] ASoC: SOF: fix a typo in put operations for kcontrol
@ 2021-09-07 18:46 Pierre-Louis Bossart
2021-09-08 16:38 ` Pierre-Louis Bossart
0 siblings, 1 reply; 2+ messages in thread
From: Pierre-Louis Bossart @ 2021-09-07 18:46 UTC (permalink / raw)
To: alsa-devel
Cc: tiwai, Pierre-Louis Bossart, broonie, Ranjani Sridharan, Rander Wang
From: Rander Wang <rander.wang@intel.com>
SOF_CTRL_TYPE_VALUE_CHAN_SET should be used for put operations
for consistency. The current use of _GET is obviously incorrect
but _GET and _SET result in the same action so there is no
functional change introduced by this patch.
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Signed-off-by: Rander Wang <rander.wang@intel.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
sound/soc/sof/control.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/sound/soc/sof/control.c b/sound/soc/sof/control.c
index a5dd728c580a..504500dd4d43 100644
--- a/sound/soc/sof/control.c
+++ b/sound/soc/sof/control.c
@@ -108,7 +108,7 @@ int snd_sof_volume_put(struct snd_kcontrol *kcontrol,
if (pm_runtime_active(scomp->dev))
snd_sof_ipc_set_get_comp_data(scontrol,
SOF_IPC_COMP_SET_VALUE,
- SOF_CTRL_TYPE_VALUE_CHAN_GET,
+ SOF_CTRL_TYPE_VALUE_CHAN_SET,
SOF_CTRL_CMD_VOLUME,
true);
return change;
@@ -179,7 +179,7 @@ int snd_sof_switch_put(struct snd_kcontrol *kcontrol,
if (pm_runtime_active(scomp->dev))
snd_sof_ipc_set_get_comp_data(scontrol,
SOF_IPC_COMP_SET_VALUE,
- SOF_CTRL_TYPE_VALUE_CHAN_GET,
+ SOF_CTRL_TYPE_VALUE_CHAN_SET,
SOF_CTRL_CMD_SWITCH,
true);
@@ -226,7 +226,7 @@ int snd_sof_enum_put(struct snd_kcontrol *kcontrol,
if (pm_runtime_active(scomp->dev))
snd_sof_ipc_set_get_comp_data(scontrol,
SOF_IPC_COMP_SET_VALUE,
- SOF_CTRL_TYPE_VALUE_CHAN_GET,
+ SOF_CTRL_TYPE_VALUE_CHAN_SET,
SOF_CTRL_CMD_ENUM,
true);
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ASoC: SOF: fix a typo in put operations for kcontrol
2021-09-07 18:46 [PATCH] ASoC: SOF: fix a typo in put operations for kcontrol Pierre-Louis Bossart
@ 2021-09-08 16:38 ` Pierre-Louis Bossart
0 siblings, 0 replies; 2+ messages in thread
From: Pierre-Louis Bossart @ 2021-09-08 16:38 UTC (permalink / raw)
To: alsa-devel; +Cc: tiwai, broonie, Peter Ujfalusi, Ranjani Sridharan, Rander Wang
On 9/7/21 1:46 PM, Pierre-Louis Bossart wrote:
> From: Rander Wang <rander.wang@intel.com>
>
> SOF_CTRL_TYPE_VALUE_CHAN_SET should be used for put operations
> for consistency. The current use of _GET is obviously incorrect
> but _GET and _SET result in the same action so there is no
> functional change introduced by this patch.
>
> Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
> Signed-off-by: Rander Wang <rander.wang@intel.com>
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Please discard this patch, it was already sent by Peter on September 2.
The effect of the long week-end I guess...
Sorry for the noise.
> ---
> sound/soc/sof/control.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/sound/soc/sof/control.c b/sound/soc/sof/control.c
> index a5dd728c580a..504500dd4d43 100644
> --- a/sound/soc/sof/control.c
> +++ b/sound/soc/sof/control.c
> @@ -108,7 +108,7 @@ int snd_sof_volume_put(struct snd_kcontrol *kcontrol,
> if (pm_runtime_active(scomp->dev))
> snd_sof_ipc_set_get_comp_data(scontrol,
> SOF_IPC_COMP_SET_VALUE,
> - SOF_CTRL_TYPE_VALUE_CHAN_GET,
> + SOF_CTRL_TYPE_VALUE_CHAN_SET,
> SOF_CTRL_CMD_VOLUME,
> true);
> return change;
> @@ -179,7 +179,7 @@ int snd_sof_switch_put(struct snd_kcontrol *kcontrol,
> if (pm_runtime_active(scomp->dev))
> snd_sof_ipc_set_get_comp_data(scontrol,
> SOF_IPC_COMP_SET_VALUE,
> - SOF_CTRL_TYPE_VALUE_CHAN_GET,
> + SOF_CTRL_TYPE_VALUE_CHAN_SET,
> SOF_CTRL_CMD_SWITCH,
> true);
>
> @@ -226,7 +226,7 @@ int snd_sof_enum_put(struct snd_kcontrol *kcontrol,
> if (pm_runtime_active(scomp->dev))
> snd_sof_ipc_set_get_comp_data(scontrol,
> SOF_IPC_COMP_SET_VALUE,
> - SOF_CTRL_TYPE_VALUE_CHAN_GET,
> + SOF_CTRL_TYPE_VALUE_CHAN_SET,
> SOF_CTRL_CMD_ENUM,
> true);
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-08 16:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-07 18:46 [PATCH] ASoC: SOF: fix a typo in put operations for kcontrol Pierre-Louis Bossart
2021-09-08 16:38 ` Pierre-Louis Bossart
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.