From: Eugen Hristev <eugen.hristev@microchip.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 04/20] W1-EEPROM: Add an W1-EEPROM uclass for 1 wire EEPROMs
Date: Mon, 30 Jul 2018 11:54:51 +0300 [thread overview]
Message-ID: <267d7aa6-0776-9bd9-0bde-9046bb96d607@microchip.com> (raw)
In-Reply-To: <20180720142829.wuxhbdd2dz6fhrfb@flea>
On 20.07.2018 17:28, Maxime Ripard wrote:
> Hi Eugen,
>
> Thanks for giving those patches another shot.
>
> On Thu, Jul 19, 2018 at 12:57:52PM +0300, Eugen Hristev wrote:
>> From: Maxime Ripard <maxime.ripard@free-electrons.com>
>>
>> We might want to access data stored onto one wire EEPROMs.
>> Create a framework to provide a consistent API.
>>
>> Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
>> [eugen.hristev at microchip.com: reworked patch]
>> Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
>> ---
>> drivers/Kconfig | 2 ++
>> drivers/Makefile | 1 +
>> drivers/w1-eeprom/Kconfig | 17 +++++++++++
>> drivers/w1-eeprom/Makefile | 2 ++
>> drivers/w1-eeprom/w1-eeprom-uclass.c | 56 ++++++++++++++++++++++++++++++++++++
>> include/dm/uclass-id.h | 1 +
>> include/w1-eeprom.h | 28 ++++++++++++++++++
>> 7 files changed, 107 insertions(+)
>> create mode 040000 drivers/w1-eeprom
>> create mode 100644 drivers/w1-eeprom/Kconfig
>> create mode 100644 drivers/w1-eeprom/Makefile
>> create mode 100644 drivers/w1-eeprom/w1-eeprom-uclass.c
>> create mode 100644 include/w1-eeprom.h
>
> I believe that we shouldn't have a framework solely for 1-wire
> EEPROMs, but for EEPROMs, connected to any bus.
>
> The 1-Wire EEPROMs all behave pretty much the same, so we'll probably
> only see a single driver within that framework. And at the same time,
> we'll want to have a consistent interface to access all the EEPROMs,
> no matter on which bus they sit on.
Hello,
I worked this series using the original implementation as a starting
point: having the eeproms on different subsystems (i2c and onewire).
The different types of eeproms have only the name in common as I see it,
and the way to access them is totally different: two different type of
buses, so uniting them is just for the namesake ?
One option is to have them separately, as we have spi, i2c memories , etc;
Or, unite them under a single subsystem for eeproms, and have one driver
for i2c eeproms and one for w1 eeproms, trying to make the same API to
access them, and hide the bus specific differences.
Question for maintainers: which is the best direction to go, so I can
rework the series accordingly ?
Thanks,
Eugen
>
> Maxime
>
next prev parent reply other threads:[~2018-07-30 8:54 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-19 9:57 [U-Boot] [PATCH 00/20] Add support for 1wire protocol and 1wire eeproms Eugen Hristev
2018-07-19 9:57 ` [U-Boot] [PATCH 01/20] w1: Add 1-Wire uclass Eugen Hristev
2018-07-19 9:57 ` [U-Boot] [PATCH 02/20] w1: Add 1-Wire gpio driver Eugen Hristev
2018-07-19 9:57 ` [U-Boot] [PATCH 03/20] dt-bindings: W1: w1-gpio: added bindings for w1-gpio Eugen Hristev
2018-07-19 9:57 ` [U-Boot] [PATCH 04/20] W1-EEPROM: Add an W1-EEPROM uclass for 1 wire EEPROMs Eugen Hristev
2018-07-20 14:28 ` Maxime Ripard
2018-07-30 8:54 ` Eugen Hristev [this message]
2018-07-31 2:06 ` Tom Rini
2018-08-02 16:56 ` Simon Glass
2018-07-19 9:57 ` [U-Boot] [PATCH 05/20] W1-EEPROM: add support for Maxim DS24 eeprom families Eugen Hristev
2018-07-19 9:57 ` [U-Boot] [PATCH 06/20] W1-EEPROM: add sandbox driver Eugen Hristev
2018-07-19 9:57 ` [U-Boot] [PATCH 07/20] w1: add command for onewire protocol Eugen Hristev
2018-07-19 9:57 ` [U-Boot] [PATCH 08/20] pinctrl: sandbox: add gpio onewire w1 group Eugen Hristev
2018-07-19 9:57 ` [U-Boot] [PATCH 09/20] sandbox: DTS: w1: add node for one wire interface on GPIO Eugen Hristev
2018-07-19 9:57 ` [U-Boot] [PATCH 10/20] configs: sandbox: add onewire w1 and sandbox eeprom Eugen Hristev
2018-07-19 9:57 ` [U-Boot] [PATCH 11/20] w1: enumerate sandbox driver if configured Eugen Hristev
2018-07-20 14:01 ` Lukasz Majewski
2018-07-23 23:48 ` Simon Glass
2018-07-24 6:58 ` Maxime Ripard
2018-07-24 15:28 ` Simon Glass
2018-07-25 9:15 ` Maxime Ripard
2018-07-19 9:58 ` [U-Boot] [PATCH 12/20] configs: sama5d2_xplained: add onewire and eeprom drivers Eugen Hristev
2018-07-19 9:58 ` [U-Boot] [PATCH 13/20] configs: sama5d3_xplained: " Eugen Hristev
2018-07-19 9:58 ` [U-Boot] [PATCH 14/20] board: atmel: add support for pda detection Eugen Hristev
2018-07-19 9:58 ` [U-Boot] [PATCH 15/20] board: sama5d2_xplained: add pda detect call at init time Eugen Hristev
2018-07-19 9:58 ` [U-Boot] [PATCH 16/20] board: sama5d3_xplained: " Eugen Hristev
2018-07-19 9:58 ` [U-Boot] [PATCH 17/20] configs: sama5d2_xplained: add fdt overlay support Eugen Hristev
2018-07-19 9:58 ` [U-Boot] [PATCH 18/20] configs: sama5d3_xplained: " Eugen Hristev
2018-07-19 9:58 ` [U-Boot] [PATCH 19/20] ARM: dts: at91: sama5d2_xplained: add onewire connector for LCD eeprom Eugen Hristev
2018-07-19 9:58 ` [U-Boot] [PATCH 20/20] ARM: dts: at91: sama5d3_xplained: " Eugen Hristev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=267d7aa6-0776-9bd9-0bde-9046bb96d607@microchip.com \
--to=eugen.hristev@microchip.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.