From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7C5DC433FE for ; Thu, 17 Nov 2022 14:02:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239324AbiKQOCu (ORCPT ); Thu, 17 Nov 2022 09:02:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39914 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234629AbiKQOCp (ORCPT ); Thu, 17 Nov 2022 09:02:45 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C725841995 for ; Thu, 17 Nov 2022 06:01:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668693716; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qVerHlGBTcU6VxEyDbbP9m6atBo8xVhYwqwi4Apy7QY=; b=WmxWgsuCEWVpzYe74HDbdQEk8Fook09bnJZ0q2PYUpqdO6mqLOukDKRM3QYFkd8h87lBT/ JiTKnbGkoRQZTg9sGs/gWnVuwciS9OD9Odrrc4q4GIypusvCrBvXzqrVA+0liYEHPHPKoc Niy+t6HYpgm3n6v55Y2nGyXxXyuFfq4= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-383-CSMPsSrjPLyiBCYa5AEW5Q-1; Thu, 17 Nov 2022 09:01:55 -0500 X-MC-Unique: CSMPsSrjPLyiBCYa5AEW5Q-1 Received: by mail-ed1-f71.google.com with SMTP id b13-20020a056402350d00b00464175c3f1eso1272204edd.11 for ; Thu, 17 Nov 2022 06:01:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qVerHlGBTcU6VxEyDbbP9m6atBo8xVhYwqwi4Apy7QY=; b=MNCn0uhhXIX9/IVqLYoTto2w5JndigyZZqZ/X3QJwWDC6qNkwms/lJZAji0IAsTLtS l8pEfzb8u38UdquK/LEtVfhJCsyS1xh5N5jx1U9c2QzsDluznK15dTyQGUeiw7sIi4/f IZbcQSdhvuT8PSRd6SGtdrPAhQSypR+E6uiSn/bx+kKhhUzjFVxHpL8Yhdrw6QNIk0IX sxaSaC5bgl65U/+QyXrWdyZ4QjYHDpE7a4tnxNtS3/XwIX7FtlUldYBtb+nRadxsy5Fc 3oE1Aeyqb+WEH/bSJOt0ZLl0jWy1KJnBb9boR5CwQjGZFqLUb1fWpxSpTDUzoMNfNZVr yjUA== X-Gm-Message-State: ANoB5pkM60fy7gvfJyrhzCDvgQ+r8ml2jUHJm80eTe1TZJ0FB4AgPT11 44lfB/HmyybeUd1VeWje5k8XeGuaUcJ2v6i0MtEka3HVCCMihyD6oBmUjcv/uK+IX8P9+Nz6TPE sx2jvXjW0m75eFNFdJJhAa245 X-Received: by 2002:a05:6402:2d6:b0:461:8efb:3f84 with SMTP id b22-20020a05640202d600b004618efb3f84mr2251866edx.210.1668693714143; Thu, 17 Nov 2022 06:01:54 -0800 (PST) X-Google-Smtp-Source: AA0mqf4p4VFzcRuLpjxSxAwfOnJBCndcIjNQLs3EtUaIqkL62sgB7jIdtINShELBOUgcD9IsvR2iXA== X-Received: by 2002:a05:6402:2d6:b0:461:8efb:3f84 with SMTP id b22-20020a05640202d600b004618efb3f84mr2251841edx.210.1668693713878; Thu, 17 Nov 2022 06:01:53 -0800 (PST) Received: from ?IPV6:2001:1c00:c1e:bf00:d69d:5353:dba5:ee81? (2001-1c00-0c1e-bf00-d69d-5353-dba5-ee81.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:d69d:5353:dba5:ee81]) by smtp.gmail.com with ESMTPSA id f4-20020a17090631c400b00730bfe6adc4sm416785ejf.37.2022.11.17.06.01.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Nov 2022 06:01:53 -0800 (PST) Message-ID: <267ebc83-04a8-4421-732d-7a329bc0fa9a@redhat.com> Date: Thu, 17 Nov 2022 15:01:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH 0/9] Extend Intel On Demand (SDSi) support Content-Language: en-US, nl To: "David E. Box" , markgross@kernel.org, andriy.shevchenko@linux.intel.com, srinivas.pandruvada@intel.com Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221101191023.4150315-1-david.e.box@linux.intel.com> From: Hans de Goede In-Reply-To: <20221101191023.4150315-1-david.e.box@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi David, On 11/1/22 20:10, David E. Box wrote: > Intel Software Defined Silicon (SDSi) is now known as Intel On Demand. The > following patches do the following: > > 1. Identify the driver/tools as Intel On Demand. Only text descriptions are > changed. Kconfig and filenames remain the same. > 2. Perform some attribute cleanup by preventing the showing of files when > features are not supported. > 3. Adds support for a new GUID. GUIDs are used to identify the layout of > the On Demand registers in sysfs. Layouts are described in the > documentation on github [1]. > 4. Add support for reading On Demand meter certificates in sysfs. > 5. The rest of the patches modify the existing tool to support discovery > and reading of On Demand registers and the meter certificate. > > [1] https://github.com/intel/intel-sdsi/blob/master/os-interface.rst > > David E. Box (9): > platform/x86/intel/sdsi: Add Intel On Demand text > platform/x86/intel/sdsi: Hide attributes if hardware doesn't support > platform/x86/intel/sdsi: Support different GUIDs > platform/x86/intel/sdsi: Add meter certificate support > tools/arch/x86: intel_sdsi: Add support for reading state certificates > tools/arch/x86: intel_sdsi: Add Intel On Demand text > tools/arch/x86: intel_sdsi: Read more On Demand registers > tools/arch/x86: intel_sdsi: Add support for new GUID > tools/arch/x86: intel_sdsi: Add support for reading meter certificates Thank you, over all this looks good. I have some small remarks on patches 4, 8 and 9 see my replies to those. Please prepare a v2 addressing Andy's + my review remarks and get that v2 to me no later then next week Tuesday, then I can still merge this in time for 6.2 . Regards, Hans