From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030806AbcDMKOT (ORCPT ); Wed, 13 Apr 2016 06:14:19 -0400 Received: from smtp01.udag.de ([62.146.106.17]:59473 "EHLO smtp01.udag.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030641AbcDMKOR (ORCPT ); Wed, 13 Apr 2016 06:14:17 -0400 Date: Wed, 13 Apr 2016 12:08:38 +0200 (CEST) From: Karol Herbst Reply-To: Karol Herbst To: Martin Peres , kbuild test robot Cc: kbuild-all , Ben Skeggs , linux-kernel , David Airlie , dri-devel Message-ID: <268311584.70313.1460542119095.JavaMail.open-xchange@www.ud-mail.de> In-Reply-To: <570DFB71.4070106@free.fr> References: <201604131531.CJokPLHc%fengguang.wu@intel.com> <20160413070742.GA9311@lkp-nex05> <570DFB71.4070106@free.fr> Subject: Re: [PATCH] drm/nouveau/iccsense: fix ifnullfree.cocci warnings MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Medium X-Mailer: Open-Xchange Mailer v7.6.2-Rev51 X-Originating-Client: open-xchange-appsuite Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Martin Peres hat am 13. April 2016 um 09:55 > geschrieben: > > > On 13/04/16 10:07, kbuild test robot wrote: > > drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c:133:2-7: WARNING: NULL > > check before freeing functions like kfree, debugfs_remove, > > debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider > > reorganizing relevant code to avoid passing NULL values. > > > > NULL check before some freeing functions is not needed. > > > > Based on checkpatch warning > > "kfree(NULL) is safe this check is probably not required" > > and kfreeaddr.cocci by Julia Lawall. > > > > Generated by: scripts/coccinelle/free/ifnullfree.cocci > > > > CC: Karol Herbst > > Signed-off-by: Fengguang Wu > Signed-off-by: Martin Peres Signed-off-by: Karol Herbst