From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E030EC433F5 for ; Thu, 14 Apr 2022 12:21:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229603AbiDNMX2 (ORCPT ); Thu, 14 Apr 2022 08:23:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56172 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243173AbiDNMXZ (ORCPT ); Thu, 14 Apr 2022 08:23:25 -0400 Received: from alexa-out-sd-01.qualcomm.com (alexa-out-sd-01.qualcomm.com [199.106.114.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0BC7D8C7C2; Thu, 14 Apr 2022 05:20:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1649938856; x=1681474856; h=message-id:date:mime-version:subject:references:from:to: in-reply-to:content-transfer-encoding; bh=XQzkMr/Z8ZY/1F9whxA7rLJIz5j5Y5jxd67801ew3pM=; b=flEL6NI2NMVmPAw9N7DN+Egkwh2wjmK7vYvSFuNovjRoxwUEkBw/FcZs 3plCQ4Sp5KTWW1cQVuGcNQpyKIkyxlm7Ph52kX6AzFSX+cuOMgOVNwUyP f55uylSYDW/cCUpInAV3N5Zh0w3XyFt1fqznKshzT8xzmoUlVajLWO1av o=; Received: from unknown (HELO ironmsg01-sd.qualcomm.com) ([10.53.140.141]) by alexa-out-sd-01.qualcomm.com with ESMTP; 14 Apr 2022 05:20:55 -0700 X-QCInternal: smtphost Received: from unknown (HELO nasanex01a.na.qualcomm.com) ([10.52.223.231]) by ironmsg01-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2022 05:20:55 -0700 Received: from [10.201.2.159] (10.80.80.8) by nasanex01a.na.qualcomm.com (10.52.223.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Thu, 14 Apr 2022 05:20:51 -0700 Message-ID: <2697e757-f446-9cdb-95e0-ea01a642e6d4@quicinc.com> Date: Thu, 14 Apr 2022 17:50:48 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: FW: [PATCH] mtd: rawnand: qcom: fix memory corruption that causes panic Content-Language: en-US References: <1649914773-22434-1-git-send-email-quic_mdalam@quicinc.com> <20220414101517.7bbc5e9d@xps13> From: Md Sadre Alam To: , , , , , , , , , In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01a.na.qualcomm.com (10.52.223.231) Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org > Hi Md, > > quic_mdalam@quicinc.com wrote on Thu, 14 Apr 2022 11:09:33 +0530: > >> This patch fixes a memory corruption that occurred in the >> nand_scan() path for Hynix nand device. >> >> On boot, for Hynix nand device will panic at a weird place: >> | Unable to handle kernel NULL pointer dereference at virtual >> address 00000070 >> | [00000070] *pgd=00000000 >> | Internal error: Oops: 5 [#1] PREEMPT SMP ARM Modules linked in: >> | CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5.17.0-01473-g13ae1769cfb0 >> #38 >> | Hardware name: Generic DT based system PC is at >> | nandc_set_reg+0x8/0x1c LR is at qcom_nandc_command+0x20c/0x5d0 >> | pc : [] lr : [] psr: 00000113 >> | sp : c14adc50 ip : c14ee208 fp : c0cc970c >> | r10: 000000a3 r9 : 00000000 r8 : 00000040 >> | r7 : c16f6a00 r6 : 00000090 r5 : 00000004 r4 :c14ee040 >> | r3 : 00000000 r2 : 0000000b r1 : 00000000 r0 :c14ee040 >> | Flags: nzcv IRQs on FIQs on Mode SVC_32 ISA ARM Segment none >> | Control: 10c5387d Table: 8020406a DAC: 00000051 Register r0 >> | information: slab kmalloc-2k start c14ee000 pointer offset >> 64 size 2048 >> | Process swapper/0 (pid: 1, stack limit = 0x(ptrval)) nandc_set_reg >> | from qcom_nandc_command+0x20c/0x5d0 qcom_nandc_command from >> | nand_readid_op+0x198/0x1e8 nand_readid_op from >> | hynix_nand_has_valid_jedecid+0x30/0x78 >> | hynix_nand_has_valid_jedecid from hynix_nand_init+0xb8/0x454 >> | hynix_nand_init from nand_scan_with_ids+0xa30/0x14a8 >> | nand_scan_with_ids from qcom_nandc_probe+0x648/0x7b0 >> | qcom_nandc_probe from platform_probe+0x58/0xac >> >> The problem is that the nand_scan()'s qcom_nand_attach_chip callback >> is updating the nandc->max_cwperpage from 1 to 4.This causes the >> sg_init_table of clear_bam_transaction() in the driver's >> qcom_nandc_command() to memset much more than what was initially >> allocated by alloc_bam_transaction(). > Thanks for investigating! > >> This patch will update nandc->max_cwperpage 1 to 4 after nand_scan() >> returns, and remove updating nandc->max_cwperpage from >> qcom_nand_attach_chip call back. > The fix does not look right, as far as I understand, this should be properly handled during the attach phase. That is where we have all information about the chip and do the configuration for this chip. > > If you update max_cwperpage there you should probably update other internal variables that depend on it as well.    Currently we are updating max_cwperpage  in qcom_nand_attach_chip(), but we are seeing issue for Hynix nand device since nand_scan_tail() is getting called after nand_attach() and in nand_attach() we are updating max_cwperpage to 4 or 8 based on page size.     From nand_scan_tail() there is a call for nand_manufacturer_init() , specific to Hynix nand read_id is getting called that's why we are seeing this issue only for Hynix nand device. Read id sequence as below    hynix_nand_has_valid_jedecid()                 |    nand_readid_op()              |  qcom_nandc_command()             | pre_command()           | clear_bam_transaction()   --> In this call we are doing sg_init_table() which is calling memset() based on max_cwperpage.Since initially we have allocated bam transaction as per max_cwperpage =1 and , since nand_chip_attach() updated max_cwperpage,  now we are doing memset as per max_cwperpage = 4 or 8. So anyway we have to updated max_cwperpage after nand_scan() call only.  Since there is no other dependency on max_cwperpage in nand_attach_chip() and we are using this in bam_alloc() and bam_clear(). > >> Signed-off-by: Md Sadre Alam >> Signed-off-by: Sricharan R >> --- >> drivers/mtd/nand/raw/qcom_nandc.c | 8 ++++---- >> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/mtd/nand/raw/qcom_nandc.c >> b/drivers/mtd/nand/raw/qcom_nandc.c >> index 1a77542..aa3ec45 100644 >> --- a/drivers/mtd/nand/raw/qcom_nandc.c >> +++ b/drivers/mtd/nand/raw/qcom_nandc.c >> @@ -2652,9 +2652,6 @@ static int qcom_nand_attach_chip(struct >> nand_chip *chip) >> >> mtd_set_ooblayout(mtd, &qcom_nand_ooblayout_ops); >> >> - nandc->max_cwperpage = max_t(unsigned int, nandc->max_cwperpage, >> - cwperpage); >> - >> /* >> * DATA_UD_BYTES varies based on whether the read/write command protects >> * spare data with ECC too. We protect spare data by default, so >> we set @@ -2909,7 +2906,7 @@ static int qcom_nand_host_init_and_register(struct qcom_nand_controller *nandc, >> struct nand_chip *chip = &host->chip; >> struct mtd_info *mtd = nand_to_mtd(chip); >> struct device *dev = nandc->dev; >> - int ret; >> + int ret, cwperpage; >> >> ret = of_property_read_u32(dn, "reg", &host->cs); >> if (ret) { >> @@ -2955,6 +2952,9 @@ static int qcom_nand_host_init_and_register(struct qcom_nand_controller *nandc, >> if (ret) >> return ret; >> >> + cwperpage = mtd->writesize / NANDC_STEP_SIZE; >> + nandc->max_cwperpage = max_t(unsigned int, nandc->max_cwperpage, >> + cwperpage); >> if (nandc->props->is_bam) { >> free_bam_transaction(nandc); >> nandc->bam_txn = alloc_bam_transaction(nandc); > > Thanks, > Miquèl From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 65B57C433F5 for ; Thu, 14 Apr 2022 12:21:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:To:From:References:Subject:MIME-Version: Date:Message-ID:Reply-To:Cc:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=YEuQerxk/YaUKZgQFLb6cZ14ATL25lc0iyMcn2yRx6I=; b=tEUMaM0hbC0XULRnEwUQ8RdFD2 YAnZUOyAzzYCt33BAETdp4KIAIRMeZy+QsK/CYCIEY1NoJ9yr7FOOxugUFsxa+eXSAXuRzFzoFpnM NS4CAPauOEQMJ06IQ4cct2MkXjsPbHvmAKKTqzDTWyHPGWukzhpgjCdVIvwXSIWfI/4xxzFhyD7Q5 s0eqZFJfbMpQbTcapInZoydMii11nwo3D5d0IwAEqwX2axmbdi1TMw3pLqj7P5GqodmJHKDb2Dqvn s8Le23FZe3iP2ctABCAQw4Pq2awEr1+PSWSeCzwX3Gxa8O9czgyJHtSoH3saa0oCfjQQyDq//4J7X BTaw/3Ew==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1neyT9-005UyP-Iq; Thu, 14 Apr 2022 12:21:03 +0000 Received: from alexa-out-sd-01.qualcomm.com ([199.106.114.38]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1neyT5-005UwL-4m for linux-mtd@lists.infradead.org; Thu, 14 Apr 2022 12:21:01 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1649938859; x=1681474859; h=message-id:date:mime-version:subject:references:from:to: in-reply-to:content-transfer-encoding; bh=XQzkMr/Z8ZY/1F9whxA7rLJIz5j5Y5jxd67801ew3pM=; b=Zas8FjB87r+uGqvwe+VRVml6ZPQrPj3r6Lw3DXL/J18mHjQbYk6/yMx9 wMPmk5lA4vbFrW6ynErf1VRKjYCcvm+Ky/hy7L4VencGMdpmWWGMAoLOs fTQGXrKVcNTn3Bj/Ch16k5o0ehIQh21BLYARW2bd8zj5btAq9zSLFJJFP 4=; Received: from unknown (HELO ironmsg01-sd.qualcomm.com) ([10.53.140.141]) by alexa-out-sd-01.qualcomm.com with ESMTP; 14 Apr 2022 05:20:55 -0700 X-QCInternal: smtphost Received: from unknown (HELO nasanex01a.na.qualcomm.com) ([10.52.223.231]) by ironmsg01-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2022 05:20:55 -0700 Received: from [10.201.2.159] (10.80.80.8) by nasanex01a.na.qualcomm.com (10.52.223.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Thu, 14 Apr 2022 05:20:51 -0700 Message-ID: <2697e757-f446-9cdb-95e0-ea01a642e6d4@quicinc.com> Date: Thu, 14 Apr 2022 17:50:48 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: FW: [PATCH] mtd: rawnand: qcom: fix memory corruption that causes panic Content-Language: en-US References: <1649914773-22434-1-git-send-email-quic_mdalam@quicinc.com> <20220414101517.7bbc5e9d@xps13> From: Md Sadre Alam To: , , , , , , , , , In-Reply-To: X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01a.na.qualcomm.com (10.52.223.231) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220414_052059_250345_E0DA9E6F X-CRM114-Status: GOOD ( 23.75 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org PiBIaSBNZCwKPgo+IHF1aWNfbWRhbGFtQHF1aWNpbmMuY29tIHdyb3RlIG9uIFRodSwgMTQgQXBy IDIwMjIgMTE6MDk6MzMgKzA1MzA6Cj4KPj4gVGhpcyBwYXRjaCBmaXhlcyBhIG1lbW9yeSBjb3Jy dXB0aW9uIHRoYXQgb2NjdXJyZWQgaW4gdGhlCj4+IG5hbmRfc2NhbigpIHBhdGggZm9yIEh5bml4 IG5hbmQgZGV2aWNlLgo+Pgo+PiBPbiBib290LCBmb3IgSHluaXggbmFuZCBkZXZpY2Ugd2lsbCBw YW5pYyBhdCBhIHdlaXJkIHBsYWNlOgo+PiB8IFVuYWJsZSB0byBoYW5kbGUga2VybmVsIE5VTEwg cG9pbnRlciBkZXJlZmVyZW5jZSBhdCB2aXJ0dWFsCj4+ICAgIGFkZHJlc3MgMDAwMDAwNzAKPj4g fCBbMDAwMDAwNzBdICpwZ2Q9MDAwMDAwMDAKPj4gfCBJbnRlcm5hbCBlcnJvcjogT29wczogNSBb IzFdIFBSRUVNUFQgU01QIEFSTSBNb2R1bGVzIGxpbmtlZCBpbjoKPj4gfCBDUFU6IDAgUElEOiAx IENvbW06IHN3YXBwZXIvMCBOb3QgdGFpbnRlZCA1LjE3LjAtMDE0NzMtZzEzYWUxNzY5Y2ZiMAo+ PiAgICAjMzgKPj4gfCBIYXJkd2FyZSBuYW1lOiBHZW5lcmljIERUIGJhc2VkIHN5c3RlbSBQQyBp cyBhdAo+PiB8IG5hbmRjX3NldF9yZWcrMHg4LzB4MWMgTFIgaXMgYXQgcWNvbV9uYW5kY19jb21t YW5kKzB4MjBjLzB4NWQwCj4+IHwgcGMgOiBbPGMwODhiNzRjPl0gICAgbHIgOiBbPGMwODhkOWM4 Pl0gICAgcHNyOiAwMDAwMDExMwo+PiB8IHNwIDogYzE0YWRjNTAgIGlwIDogYzE0ZWUyMDggIGZw IDogYzBjYzk3MGMKPj4gfCByMTA6IDAwMDAwMGEzICByOSA6IDAwMDAwMDAwICByOCA6IDAwMDAw MDQwCj4+IHwgcjcgOiBjMTZmNmEwMCAgcjYgOiAwMDAwMDA5MCAgcjUgOiAwMDAwMDAwNCAgcjQg OmMxNGVlMDQwCj4+IHwgcjMgOiAwMDAwMDAwMCAgcjIgOiAwMDAwMDAwYiAgcjEgOiAwMDAwMDAw MCAgcjAgOmMxNGVlMDQwCj4+IHwgRmxhZ3M6IG56Y3YgIElSUXMgb24gIEZJUXMgb24gIE1vZGUg U1ZDXzMyICBJU0EgQVJNIFNlZ21lbnQgbm9uZQo+PiB8IENvbnRyb2w6IDEwYzUzODdkICBUYWJs ZTogODAyMDQwNmEgIERBQzogMDAwMDAwNTEgUmVnaXN0ZXIgcjAKPj4gfCBpbmZvcm1hdGlvbjog c2xhYiBrbWFsbG9jLTJrIHN0YXJ0IGMxNGVlMDAwIHBvaW50ZXIgb2Zmc2V0Cj4+ICAgIDY0IHNp emUgMjA0OAo+PiB8IFByb2Nlc3Mgc3dhcHBlci8wIChwaWQ6IDEsIHN0YWNrIGxpbWl0ID0gMHgo cHRydmFsKSkgbmFuZGNfc2V0X3JlZwo+PiB8IGZyb20gcWNvbV9uYW5kY19jb21tYW5kKzB4MjBj LzB4NWQwIHFjb21fbmFuZGNfY29tbWFuZCBmcm9tCj4+IHwgbmFuZF9yZWFkaWRfb3ArMHgxOTgv MHgxZTggbmFuZF9yZWFkaWRfb3AgZnJvbQo+PiB8IGh5bml4X25hbmRfaGFzX3ZhbGlkX2plZGVj aWQrMHgzMC8weDc4Cj4+IHwgaHluaXhfbmFuZF9oYXNfdmFsaWRfamVkZWNpZCBmcm9tIGh5bml4 X25hbmRfaW5pdCsweGI4LzB4NDU0Cj4+IHwgaHluaXhfbmFuZF9pbml0IGZyb20gbmFuZF9zY2Fu X3dpdGhfaWRzKzB4YTMwLzB4MTRhOAo+PiB8IG5hbmRfc2Nhbl93aXRoX2lkcyBmcm9tIHFjb21f bmFuZGNfcHJvYmUrMHg2NDgvMHg3YjAKPj4gfCBxY29tX25hbmRjX3Byb2JlIGZyb20gcGxhdGZv cm1fcHJvYmUrMHg1OC8weGFjCj4+Cj4+IFRoZSBwcm9ibGVtIGlzIHRoYXQgdGhlIG5hbmRfc2Nh bigpJ3MgcWNvbV9uYW5kX2F0dGFjaF9jaGlwIGNhbGxiYWNrCj4+IGlzIHVwZGF0aW5nIHRoZSBu YW5kYy0+bWF4X2N3cGVycGFnZSBmcm9tIDEgdG8gNC5UaGlzIGNhdXNlcyB0aGUKPj4gc2dfaW5p dF90YWJsZSBvZiBjbGVhcl9iYW1fdHJhbnNhY3Rpb24oKSBpbiB0aGUgZHJpdmVyJ3MKPj4gcWNv bV9uYW5kY19jb21tYW5kKCkgdG8gbWVtc2V0IG11Y2ggbW9yZSB0aGFuIHdoYXQgd2FzIGluaXRp YWxseQo+PiBhbGxvY2F0ZWQgYnkgYWxsb2NfYmFtX3RyYW5zYWN0aW9uKCkuCj4gVGhhbmtzIGZv ciBpbnZlc3RpZ2F0aW5nIQo+Cj4+IFRoaXMgcGF0Y2ggd2lsbCB1cGRhdGUgbmFuZGMtPm1heF9j d3BlcnBhZ2UgMSB0byA0IGFmdGVyIG5hbmRfc2NhbigpCj4+IHJldHVybnMsIGFuZCByZW1vdmUg dXBkYXRpbmcgbmFuZGMtPm1heF9jd3BlcnBhZ2UgZnJvbQo+PiBxY29tX25hbmRfYXR0YWNoX2No aXAgY2FsbCBiYWNrLgo+IFRoZSBmaXggZG9lcyBub3QgbG9vayByaWdodCwgYXMgZmFyIGFzIEkg dW5kZXJzdGFuZCwgdGhpcyBzaG91bGQgYmUgcHJvcGVybHkgaGFuZGxlZCBkdXJpbmcgdGhlIGF0 dGFjaCBwaGFzZS4gVGhhdCBpcyB3aGVyZSB3ZSBoYXZlIGFsbCBpbmZvcm1hdGlvbiBhYm91dCB0 aGUgY2hpcCBhbmQgZG8gdGhlIGNvbmZpZ3VyYXRpb24gZm9yIHRoaXMgY2hpcC4KPgo+IElmIHlv dSB1cGRhdGUgbWF4X2N3cGVycGFnZSB0aGVyZSB5b3Ugc2hvdWxkIHByb2JhYmx5IHVwZGF0ZSBv dGhlciBpbnRlcm5hbCB2YXJpYWJsZXMgdGhhdCBkZXBlbmQgb24gaXQgYXMgd2VsbC4KCiDCoMKg IEN1cnJlbnRseSB3ZSBhcmUgdXBkYXRpbmcgbWF4X2N3cGVycGFnZcKgIGluIHFjb21fbmFuZF9h dHRhY2hfY2hpcCgpLCAKYnV0IHdlIGFyZSBzZWVpbmcgaXNzdWUgZm9yIEh5bml4IG5hbmQgZGV2 aWNlIHNpbmNlIG5hbmRfc2Nhbl90YWlsKCkgaXMgCmdldHRpbmcgY2FsbGVkIGFmdGVyIG5hbmRf YXR0YWNoKCkgYW5kIGluIG5hbmRfYXR0YWNoKCkgd2UgYXJlIHVwZGF0aW5nIAptYXhfY3dwZXJw YWdlIHRvIDQgb3IgOCBiYXNlZCBvbiBwYWdlIHNpemUuCgogwqDCoMKgIEZyb20gbmFuZF9zY2Fu X3RhaWwoKSB0aGVyZSBpcyBhIGNhbGwgZm9yIG5hbmRfbWFudWZhY3R1cmVyX2luaXQoKSAKLCBz cGVjaWZpYyB0byBIeW5peCBuYW5kIHJlYWRfaWQgaXMgZ2V0dGluZyBjYWxsZWQgdGhhdCdzIHdo eSB3ZSBhcmUgCnNlZWluZyB0aGlzIGlzc3VlIG9ubHkgZm9yIEh5bml4IG5hbmQgZGV2aWNlLiBS ZWFkIGlkIHNlcXVlbmNlIGFzIGJlbG93CgogwqDCoCBoeW5peF9uYW5kX2hhc192YWxpZF9qZWRl Y2lkKCkKCiDCoMKgwqDCoMKgwqDCoCDCoCDCoCDCoCDCoCB8CgogwqDCoCBuYW5kX3JlYWRpZF9v cCgpCgogwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHwKCiDCoHFjb21fbmFuZGNfY29tbWFuZCgp CgogwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB8CgpwcmVfY29tbWFuZCgpCgogwqDCoMKgwqDCoMKg wqDCoMKgIHwKCmNsZWFyX2JhbV90cmFuc2FjdGlvbigpwqDCoCAtLT4gSW4gdGhpcyBjYWxsIHdl IGFyZSBkb2luZyBzZ19pbml0X3RhYmxlKCkgCndoaWNoIGlzIGNhbGxpbmcgbWVtc2V0KCkgYmFz ZWQgb24gbWF4X2N3cGVycGFnZS5TaW5jZSBpbml0aWFsbHkgd2UgaGF2ZSAKYWxsb2NhdGVkIGJh bSB0cmFuc2FjdGlvbiBhcyBwZXIgbWF4X2N3cGVycGFnZSA9MSBhbmQgLCBzaW5jZSAKbmFuZF9j aGlwX2F0dGFjaCgpIHVwZGF0ZWQgbWF4X2N3cGVycGFnZSzCoCBub3cgd2UgYXJlIGRvaW5nIG1l bXNldCBhcyAKcGVyIG1heF9jd3BlcnBhZ2UgPSA0IG9yIDguCgoKU28gYW55d2F5IHdlIGhhdmUg dG8gdXBkYXRlZCBtYXhfY3dwZXJwYWdlIGFmdGVyIG5hbmRfc2NhbigpIGNhbGwgb25seS7CoCAK U2luY2UgdGhlcmUgaXMgbm8gb3RoZXIgZGVwZW5kZW5jeSBvbiBtYXhfY3dwZXJwYWdlIGluIApu YW5kX2F0dGFjaF9jaGlwKCkgYW5kIHdlIGFyZSB1c2luZyB0aGlzIGluIGJhbV9hbGxvYygpIGFu ZCBiYW1fY2xlYXIoKS4KCj4KPj4gU2lnbmVkLW9mZi1ieTogTWQgU2FkcmUgQWxhbSA8cXVpY19t ZGFsYW1AcXVpY2luYy5jb20+Cj4+IFNpZ25lZC1vZmYtYnk6IFNyaWNoYXJhbiBSIDxxdWljX3Ny aWNoYXJhQHF1aWNpbmMuY29tPgo+PiAtLS0KPj4gICBkcml2ZXJzL210ZC9uYW5kL3Jhdy9xY29t X25hbmRjLmMgfCA4ICsrKystLS0tCj4+ICAgMSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygr KSwgNCBkZWxldGlvbnMoLSkKPj4KPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbXRkL25hbmQvcmF3 L3Fjb21fbmFuZGMuYwo+PiBiL2RyaXZlcnMvbXRkL25hbmQvcmF3L3Fjb21fbmFuZGMuYwo+PiBp bmRleCAxYTc3NTQyLi5hYTNlYzQ1IDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL210ZC9uYW5kL3Jh dy9xY29tX25hbmRjLmMKPj4gKysrIGIvZHJpdmVycy9tdGQvbmFuZC9yYXcvcWNvbV9uYW5kYy5j Cj4+IEBAIC0yNjUyLDkgKzI2NTIsNiBAQCBzdGF0aWMgaW50IHFjb21fbmFuZF9hdHRhY2hfY2hp cChzdHJ1Y3QKPj4gbmFuZF9jaGlwICpjaGlwKQo+Pgo+PiAgICAgICAgbXRkX3NldF9vb2JsYXlv dXQobXRkLCAmcWNvbV9uYW5kX29vYmxheW91dF9vcHMpOwo+Pgo+PiAtICAgICBuYW5kYy0+bWF4 X2N3cGVycGFnZSA9IG1heF90KHVuc2lnbmVkIGludCwgbmFuZGMtPm1heF9jd3BlcnBhZ2UsCj4+ IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY3dwZXJwYWdlKTsKPj4gLQo+PiAg ICAgICAgLyoKPj4gICAgICAgICAqIERBVEFfVURfQllURVMgdmFyaWVzIGJhc2VkIG9uIHdoZXRo ZXIgdGhlIHJlYWQvd3JpdGUgY29tbWFuZCBwcm90ZWN0cwo+PiAgICAgICAgICogc3BhcmUgZGF0 YSB3aXRoIEVDQyB0b28uIFdlIHByb3RlY3Qgc3BhcmUgZGF0YSBieSBkZWZhdWx0LCBzbwo+PiB3 ZSBzZXQgQEAgLTI5MDksNyArMjkwNiw3IEBAIHN0YXRpYyBpbnQgcWNvbV9uYW5kX2hvc3RfaW5p dF9hbmRfcmVnaXN0ZXIoc3RydWN0IHFjb21fbmFuZF9jb250cm9sbGVyICpuYW5kYywKPj4gICAg ICAgIHN0cnVjdCBuYW5kX2NoaXAgKmNoaXAgPSAmaG9zdC0+Y2hpcDsKPj4gICAgICAgIHN0cnVj dCBtdGRfaW5mbyAqbXRkID0gbmFuZF90b19tdGQoY2hpcCk7Cj4+ICAgICAgICBzdHJ1Y3QgZGV2 aWNlICpkZXYgPSBuYW5kYy0+ZGV2Owo+PiAtICAgICBpbnQgcmV0Owo+PiArICAgICBpbnQgcmV0 LCBjd3BlcnBhZ2U7Cj4+Cj4+ICAgICAgICByZXQgPSBvZl9wcm9wZXJ0eV9yZWFkX3UzMihkbiwg InJlZyIsICZob3N0LT5jcyk7Cj4+ICAgICAgICBpZiAocmV0KSB7Cj4+IEBAIC0yOTU1LDYgKzI5 NTIsOSBAQCBzdGF0aWMgaW50IHFjb21fbmFuZF9ob3N0X2luaXRfYW5kX3JlZ2lzdGVyKHN0cnVj dCBxY29tX25hbmRfY29udHJvbGxlciAqbmFuZGMsCj4+ICAgICAgICBpZiAocmV0KQo+PiAgICAg ICAgICAgICAgICByZXR1cm4gcmV0Owo+Pgo+PiArICAgICBjd3BlcnBhZ2UgPSBtdGQtPndyaXRl c2l6ZSAvIE5BTkRDX1NURVBfU0laRTsKPj4gKyAgICAgbmFuZGMtPm1heF9jd3BlcnBhZ2UgPSBt YXhfdCh1bnNpZ25lZCBpbnQsIG5hbmRjLT5tYXhfY3dwZXJwYWdlLAo+PiArICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIGN3cGVycGFnZSk7Cj4+ICAgICAgICBpZiAobmFuZGMtPnBy b3BzLT5pc19iYW0pIHsKPj4gICAgICAgICAgICAgICAgZnJlZV9iYW1fdHJhbnNhY3Rpb24obmFu ZGMpOwo+PiAgICAgICAgICAgICAgICBuYW5kYy0+YmFtX3R4biA9IGFsbG9jX2JhbV90cmFuc2Fj dGlvbihuYW5kYyk7Cj4KPiBUaGFua3MsCj4gTWlxdcOobAoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4IE1URCBkaXNjdXNzaW9uIG1h aWxpbmcgbGlzdApodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xp bnV4LW10ZC8K