From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A15EDC433FF for ; Thu, 1 Aug 2019 13:59:29 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 673DA20838 for ; Thu, 1 Aug 2019 13:59:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XSmpfaFC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 673DA20838 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1htBby-0002Eu-1j; Thu, 01 Aug 2019 13:59:18 +0000 Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1htBbw-0002Eh-5m for xen-devel@lists.xenproject.org; Thu, 01 Aug 2019 13:59:16 +0000 X-Inumbo-ID: 8b0c6985-b464-11e9-8980-bc764e045a96 Received: from mail-ed1-x541.google.com (unknown [2a00:1450:4864:20::541]) by us1-rack-dfw2.inumbo.com (Halon) with ESMTPS id 8b0c6985-b464-11e9-8980-bc764e045a96; Thu, 01 Aug 2019 13:59:14 +0000 (UTC) Received: by mail-ed1-x541.google.com with SMTP id w20so69246784edd.2 for ; Thu, 01 Aug 2019 06:59:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=rv/H/hMyQhghpYVpHdsZPv4+DPLjl0X8Toc4ot4uRxU=; b=XSmpfaFCaTFaUlifI2cSKybCPucvt24mmaS/SjEjdwkkDJ9vLsDWMqeIzJOrE/lbBD vnJyvK7hjTGFMevD6cagxlj0HIEz/8/4kbiC5FJnidWo59hZeG7jurMeZUWI0vHBgIIB iTAsVrQr0HLc9NW5++Gf1wfip8Y7USXLblC+h4KgHbbnPmFZ2fHGzztRtgG9uD6X7IFZ T4EqAR/FGROtTflc0K8u8DMspVgts06VFWbu75GVz+Pf9Ry1r7uzHGX3n06rBwUGI2/1 PEqA7PNAjZ/L8B531IZ5i5kFlFTAqXg6YsguzQ1LyUbftXshgqt1RhO0fFpseu7uiYkU XFjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=rv/H/hMyQhghpYVpHdsZPv4+DPLjl0X8Toc4ot4uRxU=; b=mlHW4TKDpsJrNYrU4P8a/rgDLQ6NPbg+F9c1tMDM7yKhNsoQdvGTaO5xeMFfHOQasR KA6SIukaHZfkiImLfke6SHn8qIUOXwtJY2k+X/DovT6MM49lc2xqcEBGp8jsWwHkGCmM 9IpEL7VeNLHGRPrzbV9OTm8f5QlFKZdDKFYsRkaXVMYRWtrRwnFAULyAF6sgoKGLUew6 bcrKEbKOlvzL/EuF+t9o4wwERJZKAWwDNhC8VHzV9/Y5DULYGp5/orxYhCtYZZ/v4zYg KJYvhWnED2qSrAUkXRWZjCarxK5K22NSiMAvMGk1UZJGeBC9t0WBPi/RH/hVaaMW2GPf 0K/Q== X-Gm-Message-State: APjAAAVnvpnLh0SVRNnEj71u4yLCOOKIfRs42uAW0C/g8O9p86Iu3LT+ TukzdmGIBD2Fx+O10ngLDFs= X-Google-Smtp-Source: APXvYqwZsipA5ZK1hGtLE+mIPxXKNxGEkZNwUsXB52Pb0ewjH1DeSM5JIki/DyR2HUHwasFwNcfbfg== X-Received: by 2002:a17:907:447e:: with SMTP id oo22mr80313110ejb.169.1564667952614; Thu, 01 Aug 2019 06:59:12 -0700 (PDT) Received: from [10.80.118.76] (default-46-102-197-194.interdsl.co.uk. [46.102.197.194]) by smtp.gmail.com with ESMTPSA id j30sm17672355edb.8.2019.08.01.06.59.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 01 Aug 2019 06:59:12 -0700 (PDT) From: Lars Kurth X-Google-Original-From: Lars Kurth Message-Id: <269AA3CE-4B2D-4651-B65D-907E64B43473@xenproject.org> Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Date: Thu, 1 Aug 2019 14:59:10 +0100 In-Reply-To: To: Julien Grall References: <20190731102856.23215-1-viktor.mitin.19@gmail.com> <878sseieu1.fsf@epam.com> <15e988be-80bd-f729-ea39-8e7cbc16007f@arm.com> X-Mailer: Apple Mail (2.3445.9.1) Subject: Re: [Xen-devel] [PATCH v4 1/2] xen/arm: extend fdt_property_interrupts X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: xen-devel , Stefano Stabellini , Volodymyr Babchuk , Viktor Mitin , Viktor Mitin Content-Type: multipart/mixed; boundary="===============4821651692112625668==" Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" --===============4821651692112625668== Content-Type: multipart/alternative; boundary="Apple-Mail=_92857747-0EC5-4B90-8B59-184AC2F50A9D" --Apple-Mail=_92857747-0EC5-4B90-8B59-184AC2F50A9D Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On 1 Aug 2019, at 13:41, Julien Grall wrote: >=20 > Hi Viktor, >=20 > On 01/08/2019 13:26, Viktor Mitin wrote: >> Hi Julien and Volodymyr, >> On Wed, Jul 31, 2019 at 3:52 PM Julien Grall = wrote: >>>=20 >>> Hi, >>>=20 >>>>> It is recommended (and probably required, but I can't find exact = place >>>>> in the rules) to include cover letter if you are sending more that = one >>>>> patch in series. This will ease up review process, because = reviewer will >>>>> know what to expect in the series. >>>> > There is no such requirement, only recommendation. >>>=20 >>> It is a strong recommendation: "If you need to send more than one = patches (which >>> normally means you're sending a patch series with cover letter),". >>>=20 >>>> I did not put it since this is simple short patch series and both >>>> patches in this series have been discussed previously, so it is = known >>>> what it is about. >>>=20 >>> For a first, if you don't have a cover letter then the threading in = e-mail >>> client would look weird: >>> [PATCH v4 1/2] xen/arm: extend fdt_property_interrupts >>> |-> [PATCH v4 2/2] xen/arm: merge make_timer_node and = make_timer_domU_node >>>=20 >>> I tend to hid anything within the thread so I have only one title. = For the title >>> it is not clear to me what's the purpose of the e-mail. >>>=20 >>> The cover letter is also used to keep a summary of what was = discussed and the >>> overall goal. It does not matter if it is just a few lines. This is = also a good >>> place to have a discussion of the overall series (i.e not specific = to a patch). >>>=20 >>> Lastly, you may have new reviewers that haven't followed the = previous >>> discussion. You have also reviewers like me which receive a few = hundreds e-mails >>> per week (just counting my inbox so e-mail I am CCed to). While I = have a good >>> memory, I can't possibly remember everything single e-mails. >>>=20 >>> So the cover letter is a good place to explain what changes have = been done >>> between series. You can also do that per-patch. >>>=20 >>> Speaking about changelog, I would highly recommend to keep all the = changelog >>> from v1. This gives us an idea what happen over the review. >> Thank you for this great and detailed argumentation provided. It = makes >> sense, so probably Xen patches wiki should be updated with this >> information and cover letter should become not a recommendation, but = a >> rule. >=20 > Update to the wiki are always welcomed. I still have an action to rework = https://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches = =C2=A0and= = migrate the content to the sphinx docs @Victor: can you quickly point out where we recommend to use cover = letters (if you remember). I thought it was a requirement Lars --Apple-Mail=_92857747-0EC5-4B90-8B59-184AC2F50A9D Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii

On 1 Aug 2019, at 13:41, Julien Grall <julien.grall@arm.com> wrote:

Hi = Viktor,

On 01/08/2019 = 13:26, Viktor Mitin wrote:
Hi Julien and Volodymyr,
On Wed, Jul 31, 2019 at 3:52 PM Julien Grall <julien.grall@arm.com> wrote:

Hi,

It is recommended (and probably required, but I can't find = exact place
in the rules) to include cover letter if you = are sending more that one
patch in series. This will ease = up review process, because reviewer will
know what to = expect in the series.
 > There is no = such requirement, only recommendation.

It is a strong recommendation: "If you need to send more than = one patches (which
normally means you're sending a patch = series with cover letter),".

I did not put it since this is simple short = patch series and both
patches in this series have been = discussed previously, so it is known
what it is about.

For a first, if you don't have a = cover letter then the threading in e-mail
client would = look weird:
    [PATCH v4 1/2] = xen/arm: extend fdt_property_interrupts
       |-> [PATCH v4 = 2/2] xen/arm: merge make_timer_node and make_timer_domU_node

I tend to hid anything within the thread so I = have only one title. For the title
it is not clear to me = what's the purpose of the e-mail.

The cover = letter is also used to keep a summary of what was discussed and the
overall goal. It does not matter if it is just a few lines. = This is also a good
place to have a discussion of the = overall series (i.e not specific to a patch).

Lastly, you may have new reviewers that haven't followed the = previous
discussion. You have also reviewers like me which = receive a few hundreds e-mails
per week (just counting my = inbox so e-mail I am CCed to). While I have a good
memory, = I can't possibly remember everything single e-mails.

So the cover letter is a good place to explain what changes = have been done
between series. You can also do that = per-patch.

Speaking about changelog, I = would highly recommend to keep all the changelog
from v1. = This gives us an idea what happen over the review.
Thank you for this great and detailed = argumentation provided. It makes
sense, so probably Xen = patches wiki should be updated with this
information and = cover letter should become not a recommendation, but a
rule.

Update to the wiki are always welcomed.

I still = have an action to rework https://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches=  and migrate the content to the sphinx = docs

@Victor: can you quickly point = out where we recommend to use cover letters (if you remember). I thought = it was a requirement

Lars

= --Apple-Mail=_92857747-0EC5-4B90-8B59-184AC2F50A9D-- --===============4821651692112625668== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0 cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA== --===============4821651692112625668==--