From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49328)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mjt@tls.msk.ru>) id 1bk4e9-0008Eg-9p
	for qemu-devel@nongnu.org; Wed, 14 Sep 2016 03:30:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mjt@tls.msk.ru>) id 1bk4e5-00037e-3G
	for qemu-devel@nongnu.org; Wed, 14 Sep 2016 03:30:16 -0400
References: <1462237852-61856-1-git-send-email-chrisfriedt@gmail.com>
From: Michael Tokarev <mjt@tls.msk.ru>
Message-ID: <269ab2fb-a43b-c5ee-3ff4-c08f99054f8b@msgid.tls.msk.ru>
Date: Wed, 14 Sep 2016 10:30:07 +0300
MIME-Version: 1.0
In-Reply-To: <1462237852-61856-1-git-send-email-chrisfriedt@gmail.com>
Content-Type: text/plain; charset=windows-1251; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/2v2] [RESENT-INLINE] Use libtool instead
 of ar to create static libraries on Darwin.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Christopher Friedt <chrisfriedt@gmail.com>, famz@redhat.com, mst@redhat.com
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org

03.05.2016 04:10, Christopher Friedt wrote:
> Currently, at least on Mac OS X 10.11.4 (El Capitan), Qemu fails to build for a few reasons.
>
> One of those reasons is that Apple's ld (at least ld64) does not properly process archive files created with ar (even Apple's ar).
>
> After some RTFM'ing, I came upon this tidbit, which is unfortunate. Luckily, autotools packages are not broken.
>
> "Libtool with -static is intended to replace ar(5) and ranlib."
> http://www.manpages.info/macosx/libtool.1.html
>
> In any case, this change takes Apple's recommendations into account and allows Qemu to build on Mac OS X El Capitan.
>
> Signed-off-by: Christopher Friedt <chrisfriedt@gmail.com>
> ---
>  rules.mak | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/rules.mak b/rules.mak
> index d1ff311..44421af 100644
> --- a/rules.mak
> +++ b/rules.mak
> @@ -105,7 +105,11 @@ modules:
>  	$(call LINK,$(filter %.o %.a %.mo, $^))
>
>  %.a:
> +ifdef CONFIG_DARWIN
> +	$(call quiet-command,rm -f $@ && libtool -static -o $@ $^,"  libtool    $(TARGET_DIR)$@")
> +else
>  	$(call quiet-command,rm -f $@ && $(AR) rcs $@ $^,"  AR    $(TARGET_DIR)$@")
> +endif
>
>  quiet-command = $(if $(V),$1,$(if $(2),@echo $2 && $1, @$1))

Hmm.  Is this patch still relevant?  Apparently I missed it back then.

Thanks,

/mjt