All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bowers, AndrewX <andrewx.bowers@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [next PATCH v2 1/4] ixgbe: Add support for	generic Tx checksums
Date: Tue, 1 Mar 2016 17:38:09 +0000	[thread overview]
Message-ID: <26D9FDECA4FBDD4AADA65D8E2FC68A4A0F99B0FC@ORSMSX104.amr.corp.intel.com> (raw)
In-Reply-To: <20160113153111.4527.72349.stgit@localhost.localdomain>

> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On
> Behalf Of Alexander Duyck
> Sent: Wednesday, January 13, 2016 7:31 AM
> To: intel-wired-lan at lists.osuosl.org
> Subject: [Intel-wired-lan] [next PATCH v2 1/4] ixgbe: Add support for generic
> Tx checksums
> 
> This patch adds support for generic Tx checksums to the ixgbe driver.  It turns
> out this is actually pretty easy after going over the datasheet as we were
> doing a number of steps we didn't need to.
> 
> In order to perform a Tx checksum for an L4 header we need to fill in the
> following fields in the Tx descriptor:
>   MACLEN (maximum of 127), retrieved from:
> 		skb_network_offset()
>   IPLEN  (maximum of 511), retrieved from:
> 		skb_checksum_start_offset() - skb_network_offset()
>   TUCMD.L4T indicates offset and if checksum or crc32c, based on:
> 		skb->csum_offset
> 
> The added advantage to doing this is that we can support inner checksum
> offloads for tunnels and MPLS while still being able to transparently insert
> VLAN tags.
> 
> I also took the opportunity to clean-up many of the feature flag configuration
> bits to make them a bit more consistent between drivers.
> 
> Signed-off-by: Alexander Duyck <aduyck@mirantis.com>
> ---
>  drivers/net/ethernet/intel/ixgbe/ixgbe_main.c |  163 +++++++++-------------
> ---
>  1 file changed, 59 insertions(+), 104 deletions(-)

Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Ethtool shows generic checksum offload support, can be toggled.

  reply	other threads:[~2016-03-01 17:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-13 15:31 [Intel-wired-lan] [next PATCH v2 0/4] Add support for generic Tx checksums to igb, ixgbe, igbvf, ixgbevf Alexander Duyck
2016-01-13 15:31 ` [Intel-wired-lan] [next PATCH v2 1/4] ixgbe: Add support for generic Tx checksums Alexander Duyck
2016-03-01 17:38   ` Bowers, AndrewX [this message]
2016-01-13 15:31 ` [Intel-wired-lan] [next PATCH v2 2/4] ixgbevf: " Alexander Duyck
2016-03-01 17:35   ` Bowers, AndrewX
2016-01-13 15:31 ` [Intel-wired-lan] [next PATCH v2 3/4] igb: " Alexander Duyck
2016-01-15  3:22   ` Brown, Aaron F
2016-01-13 15:31 ` [Intel-wired-lan] [next PATCH v2 4/4] igbvf: " Alexander Duyck
2016-01-15  3:26   ` Brown, Aaron F

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=26D9FDECA4FBDD4AADA65D8E2FC68A4A0F99B0FC@ORSMSX104.amr.corp.intel.com \
    --to=andrewx.bowers@intel.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.