All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bowers, AndrewX <andrewx.bowers@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [next PATCH S51-V2 1/8] i40e: Be much more	verbose about what we can and cannot offload
Date: Wed, 26 Oct 2016 21:17:53 +0000	[thread overview]
Message-ID: <26D9FDECA4FBDD4AADA65D8E2FC68A4A0FA2925F@ORSMSX104.amr.corp.intel.com> (raw)
In-Reply-To: <1477436933-13679-2-git-send-email-bimmy.pujari@intel.com>

> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On
> Behalf Of Bimmy Pujari
> Sent: Tuesday, October 25, 2016 4:09 PM
> To: intel-wired-lan at lists.osuosl.org
> Subject: [Intel-wired-lan] [next PATCH S51-V2 1/8] i40e: Be much more
> verbose about what we can and cannot offload
> 
> From: Alexander Duyck <alexander.h.duyck@intel.com>
> 
> This change makes it so that we are much more robust about defining what
> we can and cannot offload.  Previously we were just checking for the L4
> tunnel header length, however there are other fields we should be verifying
> as there are multiple scenarios in which we cannot perform hardware
> offloads.
> 
> In addition the device only supports GSO as long as the MSS is 64 or greater.
> We were not checking this so an MSS less than that was resulting in Tx hangs.
> 
> Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
> Change-ID: I5e2fd5f3075c73601b4b36327b771c64fcb6c31b
> ---
> Testing Hints:
>         This is half of the fix needed to address MSS less than 64.  This
>         is the fix for upstream and kernels after 3.18.4, but we will need
>         to come up with a separate fix for out-of-tree that can be stripped
>         on kernels prior to 3.18.4.
> 
>         An easy test for this patch is to just set the MTU for an interface
>         to a value 102.  Without this patch we should see Tx hangs with
>         netperf and with we should be able to pass traffic without
>         triggering Tx hangs.
> 
>  drivers/net/ethernet/intel/i40e/i40e_main.c | 52
> ++++++++++++++++++++++++-----
>  1 file changed, 44 insertions(+), 8 deletions(-)

Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
No TX Hangs with MTU 102



  reply	other threads:[~2016-10-26 21:17 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-25 23:08 [Intel-wired-lan] [next PATCH S51-V2 0/8] i40e/i40evf updates Bimmy Pujari
2016-10-25 23:08 ` [Intel-wired-lan] [next PATCH S51-V2 1/8] i40e: Be much more verbose about what we can and cannot offload Bimmy Pujari
2016-10-26 21:17   ` Bowers, AndrewX [this message]
2016-10-25 23:08 ` [Intel-wired-lan] [next PATCH S51-V2 2/8] i40evf: " Bimmy Pujari
2016-10-27 16:13   ` Bowers, AndrewX
2016-10-25 23:08 ` [Intel-wired-lan] [next PATCH S51-V2 3/8] i40e: remove error_param_int label from i40e_vc_config_promiscuous_mode_msg Bimmy Pujari
2016-10-26 22:07   ` Bowers, AndrewX
2016-10-25 23:08 ` [Intel-wired-lan] [next PATCH S51-V2 4/8] i40e: remove second check of VLAN_N_VID in i40e_vlan_rx_add_vid Bimmy Pujari
2016-10-26 22:09   ` Bowers, AndrewX
2016-10-25 23:08 ` [Intel-wired-lan] [next PATCH S51-V2 5/8] i40e: avoid duplicate private flags definitions Bimmy Pujari
2016-10-26 22:13   ` Bowers, AndrewX
2016-10-25 23:08 ` [Intel-wired-lan] [next PATCH S51-V2 6/8] i40e: Add Clause22 implementation Bimmy Pujari
2016-10-26 22:21   ` Bowers, AndrewX
2016-10-25 23:08 ` [Intel-wired-lan] [next PATCH S51-V2 7/8] i40e: fix trivial typo in naming of i40e_sync_filters_subtask Bimmy Pujari
2016-10-26 22:23   ` Bowers, AndrewX
2016-10-25 23:08 ` [Intel-wired-lan] [next PATCH S51-V2 8/8] i40e: Add protocols over MCTP to i40e_aq_discover_capabilities Bimmy Pujari
2016-10-26 22:28   ` Bowers, AndrewX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=26D9FDECA4FBDD4AADA65D8E2FC68A4A0FA2925F@ORSMSX104.amr.corp.intel.com \
    --to=andrewx.bowers@intel.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.