From: Bowers, AndrewX <andrewx.bowers@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [next PATCH S61 09/10] i40e: Drop FCoE code from core driver files
Date: Tue, 7 Mar 2017 16:31:35 +0000 [thread overview]
Message-ID: <26D9FDECA4FBDD4AADA65D8E2FC68A4A10401F37@ORSMSX101.amr.corp.intel.com> (raw)
In-Reply-To: <1487721348-25617-10-git-send-email-bimmy.pujari@intel.com>
> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On
> Behalf Of Bimmy Pujari
> Sent: Tuesday, February 21, 2017 3:56 PM
> To: intel-wired-lan at lists.osuosl.org
> Subject: [Intel-wired-lan] [next PATCH S61 09/10] i40e: Drop FCoE code from
> core driver files
>
> From: Alexander Duyck <alexander.h.duyck@intel.com>
>
> Looking over the code for FCoE it looks like the Rx path has been broken at
> least since the last major Rx refactor almost a year ago. It seems like FCoE
> isn't supported for any of the Fortville/Fortpark hardware so there isn't much
> point in carrying the code around, especially if it is broken and untested.
>
> This patch cleans the FCoE code out of the CORE files and permanently sets
> the build flags so that the FCoE bits are stripped out of the shared code.
>
> It was generated using 2 passes. First with unifdef, and then manually going
> through and eliminating any extra #ifdef cruft such as an extra
>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
> Change-ID: I892de8fa551cb129ce2361e738ff82ce55fa229e
> ---
> Testing Hints:
> Driver should function the same as before. The only real change
> is that we stripped out code that was either ifdef'ed out or
> code that was unused since FCoE would never be enabled.
>
> drivers/net/ethernet/intel/Kconfig | 11 -
> drivers/net/ethernet/intel/i40e/Makefile | 1 -
> drivers/net/ethernet/intel/i40e/i40e.h | 61 +-----
> drivers/net/ethernet/intel/i40e/i40e_common.c | 27 ---
> drivers/net/ethernet/intel/i40e/i40e_debugfs.c | 19 --
> drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 35 ---
> drivers/net/ethernet/intel/i40e/i40e_main.c | 261 +----------------------
> drivers/net/ethernet/intel/i40e/i40e_osdep.h | 3 -
> drivers/net/ethernet/intel/i40e/i40e_prototype.h | 3 -
> drivers/net/ethernet/intel/i40e/i40e_txrx.c | 26 ---
> drivers/net/ethernet/intel/i40e/i40e_txrx.h | 17 --
> drivers/net/ethernet/intel/i40e/i40e_type.h | 138 ------------
> drivers/net/ethernet/intel/i40evf/i40e_txrx.h | 12 --
> 13 files changed, 2 insertions(+), 612 deletions(-)
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
next prev parent reply other threads:[~2017-03-07 16:31 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-21 23:55 [Intel-wired-lan] [next PATCH S61 00/10] i40e/i40evf updates Bimmy Pujari
2017-02-21 23:55 ` [Intel-wired-lan] [next PATCH S61 01/10] i40e/i40evf: Update code to better handle incrementing page count Bimmy Pujari
2017-03-07 16:24 ` Bowers, AndrewX
2017-02-21 23:55 ` [Intel-wired-lan] [next PATCH S61 02/10] i40e: fix configuration of RSS table with DCB Bimmy Pujari
2017-03-07 16:25 ` Bowers, AndrewX
2017-02-21 23:55 ` [Intel-wired-lan] [next PATCH S61 03/10] i40e/i40evf: Fix use after free in Rx cleanup path Bimmy Pujari
2017-03-08 18:55 ` Bowers, AndrewX
2017-02-21 23:55 ` [Intel-wired-lan] [next PATCH S61 04/10] i40e: Fixed race conditions in VF reset Bimmy Pujari
2017-03-13 14:50 ` Bowers, AndrewX
2017-02-21 23:55 ` [Intel-wired-lan] [next PATCH S61 05/10] i40e: Add support for 25G in ethtool Bimmy Pujari
2017-03-06 1:10 ` Jeff Kirsher
2017-02-21 23:55 ` [Intel-wired-lan] [next PATCH S61 06/10] i40e: fix for queue timing delays Bimmy Pujari
2017-03-07 16:29 ` Bowers, AndrewX
2017-02-21 23:55 ` [Intel-wired-lan] [next PATCH S61 07/10] i40e: removed no longer needed delays Bimmy Pujari
2017-03-07 16:30 ` Bowers, AndrewX
2017-02-21 23:55 ` [Intel-wired-lan] [next PATCH S61 08/10] i40e/i40evf: Clean-up process_skb_fields Bimmy Pujari
2017-03-07 16:30 ` Bowers, AndrewX
2017-02-21 23:55 ` [Intel-wired-lan] [next PATCH S61 09/10] i40e: Drop FCoE code from core driver files Bimmy Pujari
2017-03-07 16:31 ` Bowers, AndrewX [this message]
2017-02-21 23:55 ` [Intel-wired-lan] [next PATCH S61 10/10] i40e: Drop FCoE code that always evaluates to false or 0 Bimmy Pujari
2017-03-07 16:32 ` Bowers, AndrewX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26D9FDECA4FBDD4AADA65D8E2FC68A4A10401F37@ORSMSX101.amr.corp.intel.com \
--to=andrewx.bowers@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.