From: Bowers, AndrewX <andrewx.bowers@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [next PATCH S62 5/6] i40e: remove a useless goto statement
Date: Mon, 20 Mar 2017 23:04:39 +0000 [thread overview]
Message-ID: <26D9FDECA4FBDD4AADA65D8E2FC68A4A104066D3@ORSMSX101.amr.corp.intel.com> (raw)
In-Reply-To: <1489177325-13156-6-git-send-email-bimmy.pujari@intel.com>
> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On
> Behalf Of Bimmy Pujari
> Sent: Friday, March 10, 2017 12:22 PM
> To: intel-wired-lan at lists.osuosl.org
> Subject: [Intel-wired-lan] [next PATCH S62 5/6] i40e: remove a useless goto
> statement
>
> From: Jacob Keller <jacob.e.keller@intel.com>
>
> The goto found here for when in MFP mode is pointless. It jumps to the end
> of a series of if blocks. However, right after this statement is a closing '}' for
> this if block, which will result in the program flow going to the exact same
> location as the goto statement indicates. Thus, regardless of whether we are
> in MFP mode, the program flow will resume from the same location.
>
> This arose due to various refactoring which did not notice that this goto
> became essentially a no-op.
>
> To properly understand this diff you will need to view a larger context than is
> given by default.
>
> Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
> Change-ID: I088f73c3831aa5c4e2281380c7a3ce605594300c
> ---
> drivers/net/ethernet/intel/i40e/i40e_main.c | 4 ----
> 1 file changed, 4 deletions(-)
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
next prev parent reply other threads:[~2017-03-20 23:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-10 20:21 [Intel-wired-lan] [next PATCH S62 0/6] i40e/i40evf updates Bimmy Pujari
2017-03-10 20:22 ` [Intel-wired-lan] [next PATCH S62 1/6] i40evf: enforce descriptor write-back mechanism for VF Bimmy Pujari
2017-03-28 23:49 ` Bowers, AndrewX
2017-03-10 20:22 ` [Intel-wired-lan] [next PATCH S62 2/6] i40e: Clean up handling of private flags Bimmy Pujari
2017-03-20 23:03 ` Bowers, AndrewX
2017-03-10 20:22 ` [Intel-wired-lan] [next PATCH S62 3/6] i40e: use register for XL722 control register read/write Bimmy Pujari
2017-03-21 22:27 ` Bowers, AndrewX
2017-03-10 20:22 ` [Intel-wired-lan] [next PATCH S62 4/6] i40e: Check for new arq elements before leaving the adminq subtask loop Bimmy Pujari
2017-03-21 23:27 ` Bowers, AndrewX
2017-03-10 20:22 ` [Intel-wired-lan] [next PATCH S62 5/6] i40e: remove a useless goto statement Bimmy Pujari
2017-03-20 23:04 ` Bowers, AndrewX [this message]
2017-03-10 20:22 ` [Intel-wired-lan] [next PATCH S62 6/6] i40e: remove FDIR_REQUIRES_REINIT driver flag Bimmy Pujari
2017-03-20 23:05 ` Bowers, AndrewX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26D9FDECA4FBDD4AADA65D8E2FC68A4A104066D3@ORSMSX101.amr.corp.intel.com \
--to=andrewx.bowers@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.