All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bowers, AndrewX <andrewx.bowers@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH v3 3/5] net-intel: add statistic	indicating number of skipped Tx timestamps
Date: Tue, 2 May 2017 16:44:33 +0000	[thread overview]
Message-ID: <26D9FDECA4FBDD4AADA65D8E2FC68A4A10DA1ED3@ORSMSX104.amr.corp.intel.com> (raw)
In-Reply-To: <20170428184421.20216-4-jacob.e.keller@intel.com>

> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On
> Behalf Of Jacob Keller
> Sent: Friday, April 28, 2017 11:44 AM
> To: Intel Wired LAN <intel-wired-lan@lists.osuosl.org>
> Cc: Richard Cochran <richardcochran@gmail.com>
> Subject: [Intel-wired-lan] [PATCH v3 3/5] net-intel: add statistic indicating
> number of skipped Tx timestamps
> 
> The e1000e, igb, i40e, and ixgbe drivers share similar code for handling Tx
> timestamps, with a similar limitation of only one Tx timestamp register set.
> Because the hardware only supports one Tx timestamp at a time, the drivers
> may silently ignore timestamp requests for packets while waiting for a
> previous packet timestamp to complete. Add a new statistic,
> tx_hwtstamp_skipped, which indicates how many times this has happened.
> This is useful when trying to determine why a specific application is not
> receiving timestamps. Without this statistic, the developer may not have any
> indication that the timestamp was intentionally skipped.
> 
> Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
> ---
>  drivers/net/ethernet/intel/e1000e/e1000.h        |  1 +
>  drivers/net/ethernet/intel/e1000e/ethtool.c      |  1 +
>  drivers/net/ethernet/intel/e1000e/netdev.c       | 17 ++++++++++-------
>  drivers/net/ethernet/intel/i40e/i40e.h           |  1 +
>  drivers/net/ethernet/intel/i40e/i40e_ethtool.c   |  1 +
>  drivers/net/ethernet/intel/i40e/i40e_txrx.c      |  1 +
>  drivers/net/ethernet/intel/igb/igb.h             |  1 +
>  drivers/net/ethernet/intel/igb/igb_ethtool.c     |  1 +
>  drivers/net/ethernet/intel/igb/igb_main.c        |  2 ++
>  drivers/net/ethernet/intel/ixgbe/ixgbe.h         |  1 +
>  drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c |  3 +++
>  drivers/net/ethernet/intel/ixgbe/ixgbe_main.c    | 21 ++++++++++++--------
> -
>  12 files changed, 35 insertions(+), 16 deletions(-)

Tested-by: Andrew Bowers <andrewx.bowers@intel.com>



  reply	other threads:[~2017-05-02 16:44 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-28 18:44 [Intel-wired-lan] [PATCH v3 0/5] ptp cornercase cleanups Jacob Keller
2017-04-28 18:44 ` [Intel-wired-lan] [PATCH v3 1/5] net-intel: fix race condition with PTP_TX_IN_PROGRESS bits Jacob Keller
2017-05-02 18:32   ` Bowers, AndrewX
2017-04-28 18:44 ` [Intel-wired-lan] [PATCH v3 2/5] net-intel: avoid permanent lock of *_PTP_TX_IN_PROGRESS Jacob Keller
2017-05-02 18:33   ` Bowers, AndrewX
2017-04-28 18:44 ` [Intel-wired-lan] [PATCH v3 3/5] net-intel: add statistic indicating number of skipped Tx timestamps Jacob Keller
2017-05-02 16:44   ` Bowers, AndrewX [this message]
2017-04-28 18:44 ` [Intel-wired-lan] [PATCH v3 4/5] i40e: use pf data structure directly in i40e_ptp_rx_hang Jacob Keller
2017-05-02 18:34   ` Bowers, AndrewX
2017-04-28 18:44 ` [Intel-wired-lan] [PATCH v3 5/5] net-intel: check for Tx timestamp timeouts during watchdog Jacob Keller
2017-04-29 17:03   ` Shannon Nelson
2017-05-02 18:34   ` Bowers, AndrewX
2017-05-03 16:43 ` [Intel-wired-lan] [PATCH v3 0/5] ptp cornercase cleanups Keller, Jacob E

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=26D9FDECA4FBDD4AADA65D8E2FC68A4A10DA1ED3@ORSMSX104.amr.corp.intel.com \
    --to=andrewx.bowers@intel.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.