From: Bowers, AndrewX <andrewx.bowers@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH] ixgbe: fix memory leak on ipsec allocation
Date: Thu, 10 May 2018 19:14:00 +0000 [thread overview]
Message-ID: <26D9FDECA4FBDD4AADA65D8E2FC68A4A1B763F19@ORSMSX104.amr.corp.intel.com> (raw)
In-Reply-To: <20180509135848.20530-1-colin.king@canonical.com>
> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On
> Behalf Of Colin King
> Sent: Wednesday, May 9, 2018 6:59 AM
> To: Kirsher, Jeffrey T <jeffrey.t.kirsher@intel.com>; David S . Miller
> <davem@davemloft.net>; intel-wired-lan at lists.osuosl.org;
> netdev at vger.kernel.org
> Cc: kernel-janitors at vger.kernel.org; linux-kernel at vger.kernel.org
> Subject: [Intel-wired-lan] [PATCH] ixgbe: fix memory leak on ipsec allocation
>
> From: Colin Ian King <colin.king@canonical.com>
>
> The error clean up path kfree's adapter->ipsec and should be instead
> kfree'ing ipsec. Fix this. Also, the err1 error exit path does not need to kfree
> ipsec because this failure path was for the failed allocation of ipsec.
>
> Detected by CoverityScan, CID#146424 ("Resource Leak")
>
> Fixes: 63a67fe229ea ("ixgbe: add ipsec offload add and remove SA")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
prev parent reply other threads:[~2018-05-10 19:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-09 13:58 [PATCH] ixgbe: fix memory leak on ipsec allocation Colin King
2018-05-09 13:58 ` [Intel-wired-lan] " Colin King
2018-05-09 13:58 ` Colin King
2018-05-09 16:22 ` Shannon Nelson
2018-05-09 16:22 ` [Intel-wired-lan] " Shannon Nelson
2018-05-09 16:22 ` Shannon Nelson
2018-05-10 19:14 ` Bowers, AndrewX [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26D9FDECA4FBDD4AADA65D8E2FC68A4A1B763F19@ORSMSX104.amr.corp.intel.com \
--to=andrewx.bowers@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.