All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bowers, AndrewX <andrewx.bowers@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH] i40e: Use proper enum in i40e_ndo_set_vf_link_state
Date: Thu, 27 Sep 2018 16:19:54 +0000	[thread overview]
Message-ID: <26D9FDECA4FBDD4AADA65D8E2FC68A4A1D2FC890@ORSMSX106.amr.corp.intel.com> (raw)
In-Reply-To: <20180921101359.23911-1-natechancellor@gmail.com>

> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On
> Behalf Of Nathan Chancellor
> Sent: Friday, September 21, 2018 3:14 AM
> To: Kirsher, Jeffrey T <jeffrey.t.kirsher@intel.com>; David S. Miller
> <davem@davemloft.net>
> Cc: netdev at vger.kernel.org; Nathan Chancellor
> <natechancellor@gmail.com>; intel-wired-lan at lists.osuosl.org; linux-
> kernel at vger.kernel.org
> Subject: [Intel-wired-lan] [PATCH] i40e: Use proper enum in
> i40e_ndo_set_vf_link_state
> 
> Clang warns when one enumerated type is converted implicitly to another.
> 
> drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c:4214:42: warning:
> implicit conversion from enumeration type 'enum i40e_aq_link_speed' to
> different enumeration type 'enum virtchnl_link_speed'
>       [-Wenum-conversion]
>                 pfe.event_data.link_event.link_speed = I40E_LINK_SPEED_40GB;
>                                                      ~ ^~~~~~~~~~~~~~~~~~~~
> 1 warning generated.
> 
> Use the proper enum from virtchnl_link_speed, which has the same value as
> I40E_LINK_SPEED_40GB, VIRTCHNL_LINK_SPEED_40GB. This appears to be
> missed by commit ff3f4cc267f6 ("virtchnl: finish conversion to virtchnl
> interface").
> 
> Link: https://github.com/ClangBuiltLinux/linux/issues/81
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
> ---
>  drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Tested-by: Andrew Bowers <andrewx.bowers@intel.com>



      reply	other threads:[~2018-09-27 16:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-21 10:13 [PATCH] i40e: Use proper enum in i40e_ndo_set_vf_link_state Nathan Chancellor
2018-09-21 10:13 ` [Intel-wired-lan] " Nathan Chancellor
2018-09-27 16:19 ` Bowers, AndrewX [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=26D9FDECA4FBDD4AADA65D8E2FC68A4A1D2FC890@ORSMSX106.amr.corp.intel.com \
    --to=andrewx.bowers@intel.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.