From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Bowers, AndrewX" Subject: RE: [PATCH net-next v4 1/2] ixgbe: register a mdiobus Date: Tue, 4 Dec 2018 16:58:46 +0000 Message-ID: <26D9FDECA4FBDD4AADA65D8E2FC68A4A1D32C606@ORSMSX104.amr.corp.intel.com> References: <20181203163227.5107-1-stephend@silicom-usa.com> <20181203201432.18252-1-stephend@silicom-usa.com> <20181203201432.18252-2-stephend@silicom-usa.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT To: "netdev@vger.kernel.org" , "intel-wired-lan@lists.osuosl.org" Return-path: Received: from mga17.intel.com ([192.55.52.151]:20081 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726964AbeLDQ6s (ORCPT ); Tue, 4 Dec 2018 11:58:48 -0500 In-Reply-To: <20181203201432.18252-2-stephend@silicom-usa.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: > -----Original Message----- > From: Intel-wired-lan [mailto:intel-wired-lan-bounces@osuosl.org] On > Behalf Of Steve Douthit > Sent: Monday, December 3, 2018 12:15 PM > To: Kirsher, Jeffrey T > Cc: Andrew Lunn ; Florian Fainelli ; > netdev@vger.kernel.org; intel-wired-lan@lists.osuosl.org; David S. Miller > > Subject: [Intel-wired-lan] [PATCH net-next v4 1/2] ixgbe: register a mdiobus > > Most dsa devices expect a 'struct mii_bus' pointer to talk to switches via the > MII interface. > > While this works for dsa devices, it will not work safely with Linux PHYs in all > configurations since the firmware of the ixgbe device may be polling some > PHY addresses in the background. > > Signed-off-by: Stephen Douthit > Reviewed-by: Andrew Lunn > Reviewed-by: Florian Fainelli > --- > drivers/net/ethernet/intel/Kconfig | 1 + > drivers/net/ethernet/intel/ixgbe/ixgbe.h | 2 + > drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 5 + > drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c | 299 ++++++++++++++++++ > drivers/net/ethernet/intel/ixgbe/ixgbe_phy.h | 2 + > 5 files changed, 309 insertions(+) Tested-by: Andrew Bowers From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bowers, AndrewX Date: Tue, 4 Dec 2018 16:58:46 +0000 Subject: [Intel-wired-lan] [PATCH net-next v4 1/2] ixgbe: register a mdiobus In-Reply-To: <20181203201432.18252-2-stephend@silicom-usa.com> References: <20181203163227.5107-1-stephend@silicom-usa.com> <20181203201432.18252-1-stephend@silicom-usa.com> <20181203201432.18252-2-stephend@silicom-usa.com> Message-ID: <26D9FDECA4FBDD4AADA65D8E2FC68A4A1D32C606@ORSMSX104.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: intel-wired-lan@osuosl.org List-ID: > -----Original Message----- > From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On > Behalf Of Steve Douthit > Sent: Monday, December 3, 2018 12:15 PM > To: Kirsher, Jeffrey T > Cc: Andrew Lunn ; Florian Fainelli ; > netdev at vger.kernel.org; intel-wired-lan at lists.osuosl.org; David S. Miller > > Subject: [Intel-wired-lan] [PATCH net-next v4 1/2] ixgbe: register a mdiobus > > Most dsa devices expect a 'struct mii_bus' pointer to talk to switches via the > MII interface. > > While this works for dsa devices, it will not work safely with Linux PHYs in all > configurations since the firmware of the ixgbe device may be polling some > PHY addresses in the background. > > Signed-off-by: Stephen Douthit > Reviewed-by: Andrew Lunn > Reviewed-by: Florian Fainelli > --- > drivers/net/ethernet/intel/Kconfig | 1 + > drivers/net/ethernet/intel/ixgbe/ixgbe.h | 2 + > drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 5 + > drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c | 299 ++++++++++++++++++ > drivers/net/ethernet/intel/ixgbe/ixgbe_phy.h | 2 + > 5 files changed, 309 insertions(+) Tested-by: Andrew Bowers