From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bowers, AndrewX Date: Fri, 8 Mar 2019 00:27:38 +0000 Subject: [Intel-wired-lan] [PATCH S17 04/17] ice: Resolve static analysis reported issue In-Reply-To: <20190228232603.32156-5-anirudh.venkataramanan@intel.com> References: <20190228232603.32156-1-anirudh.venkataramanan@intel.com> <20190228232603.32156-5-anirudh.venkataramanan@intel.com> Message-ID: <26D9FDECA4FBDD4AADA65D8E2FC68A4A1D368E6A@ORSMSX104.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: intel-wired-lan@osuosl.org List-ID: > -----Original Message----- > From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On > Behalf Of Anirudh Venkataramanan > Sent: Thursday, February 28, 2019 3:26 PM > To: intel-wired-lan at lists.osuosl.org > Subject: [Intel-wired-lan] [PATCH S17 04/17] ice: Resolve static analysis > reported issue > > From: Bruce Allan > > Static analysis points out the default case in the switch statement in > ice_get_itr_intrl_gran() is an infeasible condition causing the default case > statement to be unreachable. Remove it and since the function no longer > returns anything but success, change it to just return void and update the > only call to it accordingly. > > Signed-off-by: Bruce Allan > Signed-off-by: Anirudh Venkataramanan > > --- > [Anirudh Venkataramanan cleaned > up commit message] > --- > drivers/net/ethernet/intel/ice/ice_common.c | 12 ++---------- > 1 file changed, 2 insertions(+), 10 deletions(-) Tested-by: Andrew Bowers