From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87EB8C5B579 for ; Fri, 28 Jun 2019 03:51:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 67282208CB for ; Fri, 28 Jun 2019 03:51:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727217AbfF1DvJ (ORCPT ); Thu, 27 Jun 2019 23:51:09 -0400 Received: from smtp2207-205.mail.aliyun.com ([121.197.207.205]:57719 "EHLO smtp2207-205.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726748AbfF1DvJ (ORCPT ); Thu, 27 Jun 2019 23:51:09 -0400 X-Alimail-AntiSpam: AC=CONTINUE;BC=0.07491465|-1;CH=green;DM=CONTINUE|CONTINUE|true|0.348959-0.0103707-0.64067;FP=0|0|0|0|0|-1|-1|-1;HT=e02c03299;MF=liaoweixiong@allwinnertech.com;NM=1;PH=DS;RN=13;RT=13;SR=0;TI=SMTPD_---.Er3LMMF_1561693861; Received: from 172.16.10.102(mailfrom:liaoweixiong@allwinnertech.com fp:SMTPD_---.Er3LMMF_1561693861) by smtp.aliyun-inc.com(10.147.42.16); Fri, 28 Jun 2019 11:51:02 +0800 Subject: Re: [RESEND PATCH v2] mtd: spinand: read return badly if the last page has bitflips To: Miquel Raynal , Schrempf Frieder Cc: Greg KH , Vignesh Raghavendra , Boris Brezillon , Richard Weinberger , "linux-kernel@vger.kernel.org" , Chuanhong Guo , Marek Vasut , "linux-mtd@lists.infradead.org" , "stable@vger.kernel.org" , Brian Norris , David Woodhouse References: <1561424549-784-1-git-send-email-liaoweixiong@allwinnertech.com> <20190625030807.GA11074@kroah.com> <97adf58f-4771-90f1-bdaf-5a9d00eef768@kontron.de> <20190627190644.25aaaf31@xps13> <20190627201742.34059cdf@xps13> From: liaoweixiong Message-ID: <26a4597e-3881-73a2-07e3-6171ddd15d51@allwinnertech.com> Date: Fri, 28 Jun 2019 11:51:05 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190627201742.34059cdf@xps13> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Miquel, On 2019/6/28 AM2:17, Miquel Raynal wrote: > Hi Miquel, > > Miquel Raynal wrote on Thu, 27 Jun 2019 > 19:06:44 +0200: > >> Hello, >> >> Schrempf Frieder wrote on Tue, 25 Jun >> 2019 07:04:06 +0000: >> >>> Hi liaoweixiong, >>> >>> On 25.06.19 05:08, Greg KH wrote: >>>> On Tue, Jun 25, 2019 at 09:02:29AM +0800, liaoweixiong wrote: >>>>> In case of the last page containing bitflips (ret > 0), >>>>> spinand_mtd_read() will return that number of bitflips for the last >>>>> page. But to me it looks like it should instead return max_bitflips like >>>>> it does when the last page read returns with 0. >>>>> >>>>> Signed-off-by: liaoweixiong >> >> Please write your entire official first/last name(s) >> OK. >>>>> Reviewed-by: Boris Brezillon >>>>> Reviewed-by: Frieder Schrempf >> >> I am waiting your next version with Acked-by instead of Rewieved-by >> tags and Greg's comment addressed. > > Sorry for the mistake, R-b tags are fine here, don't touch that. > The rest needs to be fixed though. > OK. >>>>> Fixes: 7529df465248 ("mtd: nand: Add core infrastructure to support SPI NANDs") >> >> Finally, when we ask you to resend a patch, it means sending a new >> version of the patch. So in the subject, you should not use the >> [RESEND] keyword (which means you are sending something again exactly >> as it was before, you just got ignored, for example) but instead you >> should increment the version number (v3) and also write a nice >> changelog after the three dashes '---' (will be ignored by Git when >> applying). >> >> I would like to queue this for the next release so if you can do it >> ASAP, that would be great. >> I will do it right now. >> Thank you, >> Miquèl > > > > > Thanks, > Miquèl > -- liaoweixiong From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44410C4321A for ; Fri, 28 Jun 2019 03:51:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1728B208CB for ; Fri, 28 Jun 2019 03:51:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gidBULL5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1728B208CB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=allwinnertech.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NTEr/mpXHUDJANuzxyDEg3Q3iNdLkENnxafyu0pNWK8=; b=gidBULL5H10pmC jOwOSZoZ2IPbopeQzXjm6jo+f8G3J8n2YPtdK+vRN1LmnOjTEoyyFvmoq7N2jGduKJXFloV3zKuiZ xjOsahY6+vshUpwHp3E2A2aOZk0IRAoc/pTaL/z6FV8IwQhu5WIs9TrfOryqjF1wY50QlLuGqZmHI Nz0efgkK6p/VJq4si+pO1ttBC4GV6X5bS5slXHKS/P4AXn06abwTfMXXRi4QKZQMB/Bsvcpzoge5a yW0cKrwUx18ilMvMTTHw7eXga7a3l5yh/cB2lpLG3xfYMtIl/UtcfGO2HAVdD4UqjFbYkJB+v1s/t 9K705Mh/5oFLKLPjqFMA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hghup-0007hi-Tx; Fri, 28 Jun 2019 03:51:11 +0000 Received: from smtp2207-205.mail.aliyun.com ([121.197.207.205]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hghum-0007hH-Ut for linux-mtd@lists.infradead.org; Fri, 28 Jun 2019 03:51:10 +0000 X-Alimail-AntiSpam: AC=CONTINUE; BC=0.07491465|-1; CH=green; DM=CONTINUE|CONTINUE|true|0.348959-0.0103707-0.64067; FP=0|0|0|0|0|-1|-1|-1; HT=e02c03299; MF=liaoweixiong@allwinnertech.com; NM=1; PH=DS; RN=13; RT=13; SR=0; TI=SMTPD_---.Er3LMMF_1561693861; Received: from 172.16.10.102(mailfrom:liaoweixiong@allwinnertech.com fp:SMTPD_---.Er3LMMF_1561693861) by smtp.aliyun-inc.com(10.147.42.16); Fri, 28 Jun 2019 11:51:02 +0800 Subject: Re: [RESEND PATCH v2] mtd: spinand: read return badly if the last page has bitflips To: Miquel Raynal , Schrempf Frieder References: <1561424549-784-1-git-send-email-liaoweixiong@allwinnertech.com> <20190625030807.GA11074@kroah.com> <97adf58f-4771-90f1-bdaf-5a9d00eef768@kontron.de> <20190627190644.25aaaf31@xps13> <20190627201742.34059cdf@xps13> From: liaoweixiong Message-ID: <26a4597e-3881-73a2-07e3-6171ddd15d51@allwinnertech.com> Date: Fri, 28 Jun 2019 11:51:05 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190627201742.34059cdf@xps13> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190627_205109_160135_5E8DC0AE X-CRM114-Status: GOOD ( 17.02 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vignesh Raghavendra , Boris Brezillon , Richard Weinberger , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , Marek Vasut , "linux-mtd@lists.infradead.org" , Greg KH , Brian Norris , Chuanhong Guo , David Woodhouse Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgTWlxdWVsLAoKT24gMjAxOS82LzI4IEFNMjoxNywgTWlxdWVsIFJheW5hbCB3cm90ZToKPiBI aSBNaXF1ZWwsCj4gCj4gTWlxdWVsIFJheW5hbCA8bWlxdWVsLnJheW5hbEBib290bGluLmNvbT4g d3JvdGUgb24gVGh1LCAyNyBKdW4gMjAxOQo+IDE5OjA2OjQ0ICswMjAwOgo+IAo+PiBIZWxsbywK Pj4KPj4gU2NocmVtcGYgRnJpZWRlciA8ZnJpZWRlci5zY2hyZW1wZkBrb250cm9uLmRlPiB3cm90 ZSBvbiBUdWUsIDI1IEp1bgo+PiAyMDE5IDA3OjA0OjA2ICswMDAwOgo+Pgo+Pj4gSGkgbGlhb3dl aXhpb25nLAo+Pj4KPj4+IE9uIDI1LjA2LjE5IDA1OjA4LCBHcmVnIEtIIHdyb3RlOiAgCj4+Pj4g T24gVHVlLCBKdW4gMjUsIDIwMTkgYXQgMDk6MDI6MjlBTSArMDgwMCwgbGlhb3dlaXhpb25nIHdy b3RlOiAgICAKPj4+Pj4gSW4gY2FzZSBvZiB0aGUgbGFzdCBwYWdlIGNvbnRhaW5pbmcgYml0Zmxp cHMgKHJldCA+IDApLAo+Pj4+PiBzcGluYW5kX210ZF9yZWFkKCkgd2lsbCByZXR1cm4gdGhhdCBu dW1iZXIgb2YgYml0ZmxpcHMgZm9yIHRoZSBsYXN0Cj4+Pj4+IHBhZ2UuIEJ1dCB0byBtZSBpdCBs b29rcyBsaWtlIGl0IHNob3VsZCBpbnN0ZWFkIHJldHVybiBtYXhfYml0ZmxpcHMgbGlrZQo+Pj4+ PiBpdCBkb2VzIHdoZW4gdGhlIGxhc3QgcGFnZSByZWFkIHJldHVybnMgd2l0aCAwLgo+Pj4+Pgo+ Pj4+PiBTaWduZWQtb2ZmLWJ5OiBsaWFvd2VpeGlvbmcgPGxpYW93ZWl4aW9uZ0BhbGx3aW5uZXJ0 ZWNoLmNvbT4gIAo+Pgo+PiBQbGVhc2Ugd3JpdGUgeW91ciBlbnRpcmUgb2ZmaWNpYWwgZmlyc3Qv bGFzdCBuYW1lKHMpCj4+CgpPSy4KCj4+Pj4+IFJldmlld2VkLWJ5OiBCb3JpcyBCcmV6aWxsb24g PGJvcmlzLmJyZXppbGxvbkBjb2xsYWJvcmEuY29tPgo+Pj4+PiBSZXZpZXdlZC1ieTogRnJpZWRl ciBTY2hyZW1wZiA8ZnJpZWRlci5zY2hyZW1wZkBrb250cm9uLmRlPiAgCj4+Cj4+IEkgYW0gd2Fp dGluZyB5b3VyIG5leHQgdmVyc2lvbiB3aXRoIEFja2VkLWJ5IGluc3RlYWQgb2YgUmV3aWV2ZWQt YnkKPj4gdGFncyBhbmQgR3JlZydzIGNvbW1lbnQgYWRkcmVzc2VkLgo+IAo+IFNvcnJ5IGZvciB0 aGUgbWlzdGFrZSwgUi1iIHRhZ3MgYXJlIGZpbmUgaGVyZSwgZG9uJ3QgdG91Y2ggdGhhdC4KPiBU aGUgcmVzdCBuZWVkcyB0byBiZSBmaXhlZCB0aG91Z2guCj4gCgpPSy4KCj4+Pj4+IEZpeGVzOiA3 NTI5ZGY0NjUyNDggKCJtdGQ6IG5hbmQ6IEFkZCBjb3JlIGluZnJhc3RydWN0dXJlIHRvIHN1cHBv cnQgU1BJIE5BTkRzIikgIAo+Pgo+PiBGaW5hbGx5LCB3aGVuIHdlIGFzayB5b3UgdG8gcmVzZW5k IGEgcGF0Y2gsIGl0IG1lYW5zIHNlbmRpbmcgYSBuZXcKPj4gdmVyc2lvbiBvZiB0aGUgcGF0Y2gu IFNvIGluIHRoZSBzdWJqZWN0LCB5b3Ugc2hvdWxkIG5vdCB1c2UgdGhlCj4+IFtSRVNFTkRdIGtl eXdvcmQgKHdoaWNoIG1lYW5zIHlvdSBhcmUgc2VuZGluZyBzb21ldGhpbmcgYWdhaW4gZXhhY3Rs eQo+PiBhcyBpdCB3YXMgYmVmb3JlLCB5b3UganVzdCBnb3QgaWdub3JlZCwgZm9yIGV4YW1wbGUp IGJ1dCBpbnN0ZWFkIHlvdQo+PiBzaG91bGQgaW5jcmVtZW50IHRoZSB2ZXJzaW9uIG51bWJlciAo djMpIGFuZCBhbHNvIHdyaXRlIGEgbmljZQo+PiBjaGFuZ2Vsb2cgYWZ0ZXIgdGhlIHRocmVlIGRh c2hlcyAnLS0tJyAod2lsbCBiZSBpZ25vcmVkIGJ5IEdpdCB3aGVuCj4+IGFwcGx5aW5nKS4KPj4K Pj4gSSB3b3VsZCBsaWtlIHRvIHF1ZXVlIHRoaXMgZm9yIHRoZSBuZXh0IHJlbGVhc2Ugc28gaWYg eW91IGNhbiBkbyBpdAo+PiBBU0FQLCB0aGF0IHdvdWxkIGJlIGdyZWF0Lgo+PgoKSSB3aWxsIGRv IGl0IHJpZ2h0IG5vdy4KCj4+IFRoYW5rIHlvdSwKPj4gTWlxdcOobAo+IAo+IAo+IAo+IAo+IFRo YW5rcywKPiBNaXF1w6hsCj4gCgotLSAKbGlhb3dlaXhpb25nCgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXggTVREIGRpc2N1c3Npb24g bWFpbGluZyBsaXN0Cmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8v bGludXgtbXRkLwo=