From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C994C43334 for ; Fri, 24 Jun 2022 13:42:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232193AbiFXNmR (ORCPT ); Fri, 24 Jun 2022 09:42:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44200 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231888AbiFXNmO (ORCPT ); Fri, 24 Jun 2022 09:42:14 -0400 Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C74562D1F4; Fri, 24 Jun 2022 06:42:12 -0700 (PDT) X-UUID: ec960c61baa04437bf56d857c8086f85-20220624 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.6,REQID:aecedf80-805d-4a4a-8f5d-3c50ce08cc4c,OB:0,LO B:40,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:45,FILE:0,RULE:Release_Ham,AC TION:release,TS:45 X-CID-INFO: VERSION:1.1.6,REQID:aecedf80-805d-4a4a-8f5d-3c50ce08cc4c,OB:0,LOB: 40,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:45,FILE:0,RULE:Release_Ham,ACTI ON:release,TS:45 X-CID-META: VersionHash:b14ad71,CLOUDID:b80170ea-f7af-4e69-92ee-0fd74a0c286c,C OID:e10d6b610329,Recheck:0,SF:28|17|19|48,TC:nil,Content:-5,EDM:-3,IP:nil, URL:1,File:nil,QS:nil,BEC:nil,COL:0 X-UUID: ec960c61baa04437bf56d857c8086f85-20220624 Received: from mtkmbs10n1.mediatek.inc [(172.21.101.34)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 366130123; Fri, 24 Jun 2022 21:42:05 +0800 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.3; Fri, 24 Jun 2022 21:42:04 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Fri, 24 Jun 2022 21:42:03 +0800 Message-ID: <26b47f385eb4148715aabe0184bd90cc32cdd42f.camel@mediatek.com> Subject: Re: [PATCH v1 1/4] pinctrl: add generic driving setup property on mt8192 From: Guodong Liu To: "=?ISO-8859-1?Q?N=EDcolas?= F. R. A. Prado" CC: Linus Walleij , Rob Herring , Matthias Brugger , Sean Wang , Sean Wang , Zhiyong Tao , , , , , , Date: Fri, 24 Jun 2022 21:42:03 +0800 In-Reply-To: <20220609181658.s5qdm32f5vhwkkao@notapiano> References: <20220608053909.1252-1-guodong.liu@mediatek.com> <20220608053909.1252-2-guodong.liu@mediatek.com> <20220609181658.s5qdm32f5vhwkkao@notapiano> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org -----Original Message----- From: Nícolas F. R. A. Prado To: Guodong Liu Cc: Linus Walleij , Rob Herring < robh+dt@kernel.org>, Matthias Brugger , Sean Wang , Sean Wang , Zhiyong Tao , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Project_Global_Chrome_Upstream_Group@mediatek.com Subject: Re: [PATCH v1 1/4] pinctrl: add generic driving setup property on mt8192 Date: Thu, 9 Jun 2022 14:16:58 -0400 Hi Guodong, thank you for the patch. On Wed, Jun 08, 2022 at 01:39:06PM +0800, Guodong Liu wrote: > This patch provides generic driving setup, which support > 2/4/6/8/10/12/14/16mA driving, original driver just set > raw data setup setting when use drive-strength property You should mention in the commit message that the dt-binding expects that drive-strength arguments be passed in mA, but the driver was expecting raw values. And that this commit changes the driver so that it is aligned with the binding. Thanks, Nícolas will fix it in next version,thanks! > > Signed-off-by: Guodong Liu > --- > drivers/pinctrl/mediatek/pinctrl-mt8192.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/pinctrl/mediatek/pinctrl-mt8192.c > b/drivers/pinctrl/mediatek/pinctrl-mt8192.c > index acccde9262ba..9faf7001369d 100644 > --- a/drivers/pinctrl/mediatek/pinctrl-mt8192.c > +++ b/drivers/pinctrl/mediatek/pinctrl-mt8192.c > @@ -1372,8 +1372,8 @@ static const struct mtk_pin_soc mt8192_data = { > .gpio_m = 0, > .bias_set_combo = mtk_pinconf_bias_set_combo, > .bias_get_combo = mtk_pinconf_bias_get_combo, > - .drive_set = mtk_pinconf_drive_set_raw, > - .drive_get = mtk_pinconf_drive_get_raw, > + .drive_set = mtk_pinconf_drive_set_rev1, > + .drive_get = mtk_pinconf_drive_get_rev1, > .adv_pull_get = mtk_pinconf_adv_pull_get, > .adv_pull_set = mtk_pinconf_adv_pull_set, > .adv_drive_get = mtk_pinconf_adv_drive_get, > -- > 2.25.5 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2A363C433EF for ; Fri, 24 Jun 2022 13:50:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xo0MJ/l7KDF2y2oHM/D3N/2VAtlNrtgBksAJVn9Aado=; b=A+0A4hMOqW5+5U U66bE6XEpVfQQBJ+ouYNYCgvmk3RbomT+in8+C0ft+cHfqcjUMJr+YuYz/szRo6+iujS3lWKhk267 nWbQWQ8dMCNzUcf4xqA6FTmr0l3ZijiuldrXHkgIPhfhH4GJSXH+vrDVD2BWIBg1Wpqzris/l3D4l CpqDwq8LIEh7lF7qXfWuCy2163DrA8asTWjFC8B5Kra/MDfSmI+vHQ/UOLAjldqtjtOH4Owqt8Vsd rx9kvHOOXaTHVh3zP879eYhmqFhq/X5AZlcvX8tgJFWPWwWO1pzxXSp4clbQ4pr+ngvnueY3cAkul UjP34YsrFXgteRuoJbvw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o4jg0-002T6E-Gn; Fri, 24 Jun 2022 13:48:49 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o4jej-002SRC-Dl; Fri, 24 Jun 2022 13:47:35 +0000 X-UUID: c0e4019fd7cd47919272698101a95538-20220624 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=3f2/bpQKtykjR5qjBidriE1zZ4iOBIpTZv8uRjxEFH0=; b=kzGdflhHkLSGzyq59ZZDJP4qFkl/wzmw/w4cjfk0zh2P2MMoBt89yjSbccnUPnSeQ3n4UVPZNINvEXAaxysHgBWbxvDMsaFaxh5oH8k8zu/AHprsRt3Qjc61Y/BCcf+JyrO623QX1qlSZPdsfSUnw2+Iv+oqg0wtpV3wPjr5Ym8=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.6,REQID:fc8e1ba0-0d5a-4b5f-96dd-fb32eb6e5393,OB:0,LO B:0,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,RULE:Release_Ham,ACTI ON:release,TS:0 X-CID-META: VersionHash:b14ad71,CLOUDID:4991f82d-1756-4fa3-be7f-474a6e4be921,C OID:IGNORED,Recheck:0,SF:nil,TC:nil,Content:-5,EDM:-3,IP:nil,URL:1,File:ni l,QS:nil,BEC:nil,COL:0 X-UUID: c0e4019fd7cd47919272698101a95538-20220624 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 2048413901; Fri, 24 Jun 2022 06:47:13 -0700 Received: from mtkmbs10n2.mediatek.inc (172.21.101.183) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 24 Jun 2022 06:42:05 -0700 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.3; Fri, 24 Jun 2022 21:42:04 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Fri, 24 Jun 2022 21:42:03 +0800 Message-ID: <26b47f385eb4148715aabe0184bd90cc32cdd42f.camel@mediatek.com> Subject: Re: [PATCH v1 1/4] pinctrl: add generic driving setup property on mt8192 From: Guodong Liu To: "=?ISO-8859-1?Q?N=EDcolas?= F. R. A. Prado" CC: Linus Walleij , Rob Herring , Matthias Brugger , Sean Wang , Sean Wang , Zhiyong Tao , , , , , , Date: Fri, 24 Jun 2022 21:42:03 +0800 In-Reply-To: <20220609181658.s5qdm32f5vhwkkao@notapiano> References: <20220608053909.1252-1-guodong.liu@mediatek.com> <20220608053909.1252-2-guodong.liu@mediatek.com> <20220609181658.s5qdm32f5vhwkkao@notapiano> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220624_064729_612784_9F0C697A X-CRM114-Status: GOOD ( 19.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org LS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCkZyb206IE7DrWNvbGFzIEYuIFIuIEEuIFByYWRv IDxuZnJhcHJhZG9AY29sbGFib3JhLmNvbT4NClRvOiBHdW9kb25nIExpdSA8Z3VvZG9uZy5saXVA bWVkaWF0ZWsuY29tPg0KQ2M6IExpbnVzIFdhbGxlaWogPGxpbnVzLndhbGxlaWpAbGluYXJvLm9y Zz4sIFJvYiBIZXJyaW5nIDwNCnJvYmgrZHRAa2VybmVsLm9yZz4sIE1hdHRoaWFzIEJydWdnZXIg PG1hdHRoaWFzLmJnZ0BnbWFpbC5jb20+LCBTZWFuDQpXYW5nIDxzZWFuLndhbmdAa2VybmVsLm9y Zz4sIFNlYW4gV2FuZyA8c2Vhbi53YW5nQG1lZGlhdGVrLmNvbT4sDQpaaGl5b25nIFRhbyA8emhp eW9uZy50YW9AbWVkaWF0ZWsuY29tPiwgbGludXgtZ3Bpb0B2Z2VyLmtlcm5lbC5vcmcsIA0KZGV2 aWNldHJlZUB2Z2VyLmtlcm5lbC5vcmcsIGxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFk Lm9yZywgDQpsaW51eC1tZWRpYXRla0BsaXN0cy5pbmZyYWRlYWQub3JnLCBsaW51eC1rZXJuZWxA dmdlci5rZXJuZWwub3JnLCANClByb2plY3RfR2xvYmFsX0Nocm9tZV9VcHN0cmVhbV9Hcm91cEBt ZWRpYXRlay5jb20NClN1YmplY3Q6IFJlOiBbUEFUQ0ggdjEgMS80XSBwaW5jdHJsOiBhZGQgZ2Vu ZXJpYyBkcml2aW5nIHNldHVwIHByb3BlcnR5DQpvbiBtdDgxOTINCkRhdGU6IFRodSwgOSBKdW4g MjAyMiAxNDoxNjo1OCAtMDQwMA0KDQpIaSBHdW9kb25nLA0KDQp0aGFuayB5b3UgZm9yIHRoZSBw YXRjaC4NCg0KT24gV2VkLCBKdW4gMDgsIDIwMjIgYXQgMDE6Mzk6MDZQTSArMDgwMCwgR3VvZG9u ZyBMaXUgd3JvdGU6DQo+IFRoaXMgcGF0Y2ggcHJvdmlkZXMgZ2VuZXJpYyBkcml2aW5nIHNldHVw LCB3aGljaCBzdXBwb3J0DQo+IDIvNC82LzgvMTAvMTIvMTQvMTZtQSBkcml2aW5nLCBvcmlnaW5h bCBkcml2ZXIganVzdCBzZXQNCj4gcmF3IGRhdGEgc2V0dXAgc2V0dGluZyB3aGVuIHVzZSBkcml2 ZS1zdHJlbmd0aCBwcm9wZXJ0eQ0KDQpZb3Ugc2hvdWxkIG1lbnRpb24gaW4gdGhlIGNvbW1pdCBt ZXNzYWdlIHRoYXQgdGhlIGR0LWJpbmRpbmcgZXhwZWN0cw0KdGhhdA0KZHJpdmUtc3RyZW5ndGgg YXJndW1lbnRzIGJlIHBhc3NlZCBpbiBtQSwgYnV0IHRoZSBkcml2ZXIgd2FzIGV4cGVjdGluZw0K cmF3DQp2YWx1ZXMuIEFuZCB0aGF0IHRoaXMgY29tbWl0IGNoYW5nZXMgdGhlIGRyaXZlciBzbyB0 aGF0IGl0IGlzIGFsaWduZWQNCndpdGggdGhlDQpiaW5kaW5nLg0KDQpUaGFua3MsDQpOw61jb2xh cw0KDQp3aWxsIGZpeCBpdCBpbiBuZXh0IHZlcnNpb24sdGhhbmtzIQ0KPiANCj4gU2lnbmVkLW9m Zi1ieTogR3VvZG9uZyBMaXUgPGd1b2RvbmcubGl1QG1lZGlhdGVrLmNvbT4NCj4gLS0tDQo+ICBk cml2ZXJzL3BpbmN0cmwvbWVkaWF0ZWsvcGluY3RybC1tdDgxOTIuYyB8IDQgKystLQ0KPiAgMSBm aWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkNCj4gDQo+IGRpZmYg LS1naXQgYS9kcml2ZXJzL3BpbmN0cmwvbWVkaWF0ZWsvcGluY3RybC1tdDgxOTIuYw0KPiBiL2Ry aXZlcnMvcGluY3RybC9tZWRpYXRlay9waW5jdHJsLW10ODE5Mi5jDQo+IGluZGV4IGFjY2NkZTky NjJiYS4uOWZhZjcwMDEzNjlkIDEwMDY0NA0KPiAtLS0gYS9kcml2ZXJzL3BpbmN0cmwvbWVkaWF0 ZWsvcGluY3RybC1tdDgxOTIuYw0KPiArKysgYi9kcml2ZXJzL3BpbmN0cmwvbWVkaWF0ZWsvcGlu Y3RybC1tdDgxOTIuYw0KPiBAQCAtMTM3Miw4ICsxMzcyLDggQEAgc3RhdGljIGNvbnN0IHN0cnVj dCBtdGtfcGluX3NvYyBtdDgxOTJfZGF0YSA9IHsNCj4gIAkuZ3Bpb19tID0gMCwNCj4gIAkuYmlh c19zZXRfY29tYm8gPSBtdGtfcGluY29uZl9iaWFzX3NldF9jb21ibywNCj4gIAkuYmlhc19nZXRf Y29tYm8gPSBtdGtfcGluY29uZl9iaWFzX2dldF9jb21ibywNCj4gLQkuZHJpdmVfc2V0ID0gbXRr X3BpbmNvbmZfZHJpdmVfc2V0X3JhdywNCj4gLQkuZHJpdmVfZ2V0ID0gbXRrX3BpbmNvbmZfZHJp dmVfZ2V0X3JhdywNCj4gKwkuZHJpdmVfc2V0CT0gbXRrX3BpbmNvbmZfZHJpdmVfc2V0X3JldjEs DQo+ICsJLmRyaXZlX2dldAk9IG10a19waW5jb25mX2RyaXZlX2dldF9yZXYxLA0KPiAgCS5hZHZf cHVsbF9nZXQgPSBtdGtfcGluY29uZl9hZHZfcHVsbF9nZXQsDQo+ICAJLmFkdl9wdWxsX3NldCA9 IG10a19waW5jb25mX2Fkdl9wdWxsX3NldCwNCj4gIAkuYWR2X2RyaXZlX2dldCA9IG10a19waW5j b25mX2Fkdl9kcml2ZV9nZXQsDQo+IC0tIA0KPiAyLjI1LjUNCj4gDQpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcg bGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmlu ZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==