All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andreas Roeseler <andreas.a.roeseler@gmail.com>
To: David Ahern <dsahern@gmail.com>, David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, yoshfuji@linux-ipv6.org, kuba@kernel.org,
	dsahern@kernel.org
Subject: Re: [PATCH V4 net-next 5/5] icmp: add response to RFC 8335 PROBE messages
Date: Sat, 20 Mar 2021 11:01:20 -0500	[thread overview]
Message-ID: <26d502c2efecf3ea1ffdd8784590697d02907e7a.camel@gmail.com> (raw)
In-Reply-To: <34107111-5293-2119-cfc7-8156c43ae555@gmail.com>

On Wed, 2021-03-17 at 21:24 -0600, David Ahern wrote:
> On 3/17/21 9:19 PM, David Miller wrote:
> > From: Andreas Roeseler <andreas.a.roeseler@gmail.com>
> > Date: Wed, 17 Mar 2021 22:11:47 -0500
> > 
> > > On Mon, 2021-03-15 at 04:35 +0800, kernel test robot wrote:
> > > Is there something that I'm not understanding about compiling
> > > kernel
> > > components modularly? How do I avoid this error?
> > 
> > > 
> > You cannot reference module exported symbols from statically linked
> > code.
> > y
> > 
> 
> Look at ipv6_stub to see how it exports IPv6 functions for v4 code.
> There are a few examples under net/ipv4.

Thanks for the advice. I've been able to make some progress but I still
have some questions that I have been unable to find online.

What steps are required to include a function into the ipv6_stub
struct? I've added the declaration of the function to the struct, but
when I attempt to call it using <ipv6_stub->ipv6_dev_find()> the kernel
locks up. Additionally, a typo in the declaration isn't flagged during
compilation. Are there other places where I need to edit the ipv6_stub
struct or include various headers? The examples I have looked at are
<fib_semantics.c>, <nexthop.c>, and <udp.c> in the <net/ipv4> folder
and they don't seem to do anything on the caller side of ipv6_stub, so
I think I am not adding the function to ipv6_stub properly. I have been
able to call other functions that currently exist in ipv6_stub, but not
the one I  am attempting to add, so am I missing a step?

I've noticed that some functions such as <ipv6_route_input> aren't
exported using EXPORT_SYMBOL when it is defined in
<net/ipv6/af_inet6.c>, but it is still loaded into ipv6_stub. How can
this be? Is there a different way to include symbols into ipv6_stub
based on whether or not they are explicitly exported using
EXPORT_SYMBOL?


  reply	other threads:[~2021-03-20 16:02 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-14 16:48 [PATCH V4 net-next 0/5] add support for RFC 8335 PROBE Andreas Roeseler
2021-03-14 16:48 ` [PATCH V4 net-next 1/5] icmp: " Andreas Roeseler
2021-03-14 16:48 ` [PATCH V4 net-next 2/5] ICMPV6: " Andreas Roeseler
2021-03-14 16:48 ` [PATCH V4 net-next 3/5] net: add sysctl for enabling RFC 8335 PROBE messages Andreas Roeseler
2021-03-14 16:48 ` [PATCH V4 net-next 4/5] net: add support for sending " Andreas Roeseler
2021-03-14 16:48 ` [PATCH V4 net-next 5/5] icmp: add response to " Andreas Roeseler
2021-03-14 17:59   ` kernel test robot
2021-03-14 18:32   ` kernel test robot
2021-03-14 18:33   ` kernel test robot
2021-03-14 20:35   ` kernel test robot
2021-03-18  3:11     ` Andreas Roeseler
2021-03-18  3:19       ` David Miller
2021-03-18  3:24         ` David Ahern
2021-03-20 16:01           ` Andreas Roeseler [this message]
2021-03-20 16:43             ` David Ahern
2021-03-15 15:50   ` Willem de Bruijn
2021-03-15 19:09     ` Andreas Roeseler
2021-03-15 19:34       ` Willem de Bruijn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=26d502c2efecf3ea1ffdd8784590697d02907e7a.camel@gmail.com \
    --to=andreas.a.roeseler@gmail.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@gmail.com \
    --cc=dsahern@kernel.org \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.