From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70E70C001DC for ; Fri, 7 Jul 2023 13:50:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232662AbjGGNuu (ORCPT ); Fri, 7 Jul 2023 09:50:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33070 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232663AbjGGNum (ORCPT ); Fri, 7 Jul 2023 09:50:42 -0400 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A43DAF for ; Fri, 7 Jul 2023 06:50:41 -0700 (PDT) Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-3fbd33a57dcso21109185e9.0 for ; Fri, 07 Jul 2023 06:50:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20221208.gappssmtp.com; s=20221208; t=1688737839; x=1691329839; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3j3NwAPFY78Qhs50ITu0+2oTOBybcQeJnKlWCP159es=; b=I1+TSh7b2Q202iHBO0hVfS9/ZziI37tnntx0FsMqkX69+DWkfi8eyU/v0zCNtXb6OL 4tuLAI42Y184Vgke/lieW0SVC/kyYH5G0hrPG9W2Yl8F/+115Nqfm1pAaxEhiRrDHLDG x237vmBWBcvEWIK8n5TIu0MAILF6MaXGiLEGnyYnaXwSTLztju+o1QC+Jqp1CtgOQqW0 BUG8j7fw2muDJtzkad1KsxPieG/xCFgZRvJPknzUNjZvOWNGvkissjBOF90zoQ/e688F TGC33aCJ20gRtzV+C4WI5xceHCURxEorMwc1DBu4fiDHRpKJVQGdRyXQsIRY1LVN/yU0 7Zqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688737839; x=1691329839; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3j3NwAPFY78Qhs50ITu0+2oTOBybcQeJnKlWCP159es=; b=VuyNYJzvHzHaJWeFzYlkuonGb5Xcv1xJnqSFhuUcYx6jieHXGXdn2OPA9S0vnNLHio JBKTHK6/Fr2CtsCE4sq4uVhA0y8qExAOF3Oe7zziTlFhZcKifX3uIglwK+P9xiJ+40FT NyjNvnTxmBQZbLoKUsz/Mt0zvjbcnNR6Iqx8pOI2cZw3zryJD6khoiZ7/sboAbRzAoCM H/qf07RSf2LkYVa3xiZjiho6jzkr6JmYZvP8wqa9CxaY0VdhFgkOsPzL8LX4UiPbf0oF VaV8DoL38HRzVHRzHpfAMEpbjzhDOdAYGbfdJBohL2S17cYS8zq78eNxdPsfAt28Jud3 fWPw== X-Gm-Message-State: ABy/qLYZ+NRO5GtrXOjyaG/0t3PXObmBKCcCxa38EkUzlkAuyPxju7ZS pcpnS0I1oezrR9B58U401tXIIA== X-Google-Smtp-Source: APBJJlETRcrMTPhEN/HPK4s4f3CyhXH6jBzJpRJpJVuRp4Zn+qZ7qEfjxymL6GD/vVJq5JP8oFpwbQ== X-Received: by 2002:a1c:4c07:0:b0:3fa:9850:8b1d with SMTP id z7-20020a1c4c07000000b003fa98508b1dmr4038526wmf.30.1688737839661; Fri, 07 Jul 2023 06:50:39 -0700 (PDT) Received: from [192.168.1.172] ([93.5.22.158]) by smtp.gmail.com with ESMTPSA id p11-20020a1c740b000000b003fbe36a4ce6sm2542924wmc.10.2023.07.07.06.50.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Jul 2023 06:50:38 -0700 (PDT) Message-ID: <26d9e485-e9f6-7217-7c88-4c9a9b4dd9ea@baylibre.com> Date: Fri, 7 Jul 2023 15:50:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v3 2/6] thermal/drivers/mediatek/lvts_thermal: Honor sensors in immediate mode Content-Language: en-US To: =?UTF-8?B?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= , Daniel Lezcano Cc: Alexandre Bailon , Balsam CHIHI , AngeloGioacchino Del Regno , Chen-Yu Tsai , kernel@collabora.com, Amit Kucheria , Matthias Brugger , "Rafael J. Wysocki" , Zhang Rui , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-pm@vger.kernel.org References: <20230706153823.201943-1-nfraprado@collabora.com> <20230706153823.201943-3-nfraprado@collabora.com> From: Alexandre Mergnat In-Reply-To: <20230706153823.201943-3-nfraprado@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/07/2023 17:37, Nícolas F. R. A. Prado wrote: > Each controller can be configured to operate on immediate or filtered > mode. On filtered mode, the sensors are enabled by setting the > corresponding bits in MONCTL0, while on immediate mode, by setting > MSRCTL1. > > Previously, the code would set MSRCTL1 for all four sensors when > configured to immediate mode, but given that the controller might not > have all four sensors connected, this would cause interrupts to trigger > for non-existent sensors. Fix this by handling the MSRCTL1 register > analogously to the MONCTL0: only enable the sensors that were declared. Reviewed-by: Alexandre Mergnat -- Regards, Alexandre From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 21FC7EB64DA for ; Fri, 7 Jul 2023 13:51:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=s1ASdwg/U5veOonk5lA7RkPOEOX2YD/tl9bTqq07vug=; b=EipheNO37ys7/c 09/cRtlg1XecEPjeD0E0qbJThzK9yaaxggIu2nWdWyuBvNT28w4CARVoCvvOJDQ11KlhpD7fqRw6a IfFOmcvXbYMI5Ru48q6X1ci4pEiBzbTDe3OeFCzvwDVCac2qv6c9MPQhzmqoGobZbEI+1gxpvCcrL XtPhGDYPU9+EQfMQ5hKzfWsRbRrlGOtHLQ2EI/RLakyhu0CvCRqOAcv72FlIk5JsCD4v8fJsBFEUp BBZA65Yn0949dqBsXZEvwmZ87+PJZX8c01TF5hZ1yqVE+ZbT0ln6gaJkbrVr/w8xJwWBCTdutG52z KkdiIW2I7NmWisQfz3mg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qHlrG-004m9C-13; Fri, 07 Jul 2023 13:50:50 +0000 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qHlrD-004m7N-13 for linux-arm-kernel@lists.infradead.org; Fri, 07 Jul 2023 13:50:49 +0000 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-3fbc12181b6so20942185e9.2 for ; Fri, 07 Jul 2023 06:50:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20221208.gappssmtp.com; s=20221208; t=1688737839; x=1691329839; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3j3NwAPFY78Qhs50ITu0+2oTOBybcQeJnKlWCP159es=; b=I1+TSh7b2Q202iHBO0hVfS9/ZziI37tnntx0FsMqkX69+DWkfi8eyU/v0zCNtXb6OL 4tuLAI42Y184Vgke/lieW0SVC/kyYH5G0hrPG9W2Yl8F/+115Nqfm1pAaxEhiRrDHLDG x237vmBWBcvEWIK8n5TIu0MAILF6MaXGiLEGnyYnaXwSTLztju+o1QC+Jqp1CtgOQqW0 BUG8j7fw2muDJtzkad1KsxPieG/xCFgZRvJPknzUNjZvOWNGvkissjBOF90zoQ/e688F TGC33aCJ20gRtzV+C4WI5xceHCURxEorMwc1DBu4fiDHRpKJVQGdRyXQsIRY1LVN/yU0 7Zqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688737839; x=1691329839; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3j3NwAPFY78Qhs50ITu0+2oTOBybcQeJnKlWCP159es=; b=F9vAOqojL0pTrQzBFjoFwPnLe8qWLgNMZ92SUTEsp+xf7E3xHLRzWUlFqXIXFvXBn3 bDm4lyE2fu4EIZWu2fZJYgxfY/b/WPkV+ry1519iizdQQ9a5+3yYOwDjIYwDkD1qrf0E XNi5+bQMNmBSWJx7F9Vu+4zdZPqGU0WaTXmLLtvYRx2h40Bpcf//jdJza4/Tg8ipYv/U LBpp8udwLGA/Md2+hMnVQeheV4cjzIR6Z5hZlM4y25CkyePcHe4FVoDx5JYOLXoPu/eS CVqNeqhRUx40OimwxfmzWVYz23Rx/B+Sdo3qaaQtL8czIa5yVZQ0YDA7Pb5XmMzi371p bjKQ== X-Gm-Message-State: ABy/qLa4mepR995cn0+o9DHm6J6YCT0EIGcWK46CQCj3YNt8f+cKiSPM ZhH1Uf/YTZVt6SQxHPcnm2PBtQ== X-Google-Smtp-Source: APBJJlETRcrMTPhEN/HPK4s4f3CyhXH6jBzJpRJpJVuRp4Zn+qZ7qEfjxymL6GD/vVJq5JP8oFpwbQ== X-Received: by 2002:a1c:4c07:0:b0:3fa:9850:8b1d with SMTP id z7-20020a1c4c07000000b003fa98508b1dmr4038526wmf.30.1688737839661; Fri, 07 Jul 2023 06:50:39 -0700 (PDT) Received: from [192.168.1.172] ([93.5.22.158]) by smtp.gmail.com with ESMTPSA id p11-20020a1c740b000000b003fbe36a4ce6sm2542924wmc.10.2023.07.07.06.50.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Jul 2023 06:50:38 -0700 (PDT) Message-ID: <26d9e485-e9f6-7217-7c88-4c9a9b4dd9ea@baylibre.com> Date: Fri, 7 Jul 2023 15:50:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v3 2/6] thermal/drivers/mediatek/lvts_thermal: Honor sensors in immediate mode Content-Language: en-US To: =?UTF-8?B?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= , Daniel Lezcano Cc: Alexandre Bailon , Balsam CHIHI , AngeloGioacchino Del Regno , Chen-Yu Tsai , kernel@collabora.com, Amit Kucheria , Matthias Brugger , "Rafael J. Wysocki" , Zhang Rui , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-pm@vger.kernel.org References: <20230706153823.201943-1-nfraprado@collabora.com> <20230706153823.201943-3-nfraprado@collabora.com> From: Alexandre Mergnat In-Reply-To: <20230706153823.201943-3-nfraprado@collabora.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230707_065047_361862_7E331251 X-CRM114-Status: GOOD ( 11.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org CgpPbiAwNi8wNy8yMDIzIDE3OjM3LCBOw61jb2xhcyBGLiBSLiBBLiBQcmFkbyB3cm90ZToKPiBF YWNoIGNvbnRyb2xsZXIgY2FuIGJlIGNvbmZpZ3VyZWQgdG8gb3BlcmF0ZSBvbiBpbW1lZGlhdGUg b3IgZmlsdGVyZWQKPiBtb2RlLiBPbiBmaWx0ZXJlZCBtb2RlLCB0aGUgc2Vuc29ycyBhcmUgZW5h YmxlZCBieSBzZXR0aW5nIHRoZQo+IGNvcnJlc3BvbmRpbmcgYml0cyBpbiBNT05DVEwwLCB3aGls ZSBvbiBpbW1lZGlhdGUgbW9kZSwgYnkgc2V0dGluZwo+IE1TUkNUTDEuCj4gCj4gUHJldmlvdXNs eSwgdGhlIGNvZGUgd291bGQgc2V0IE1TUkNUTDEgZm9yIGFsbCBmb3VyIHNlbnNvcnMgd2hlbgo+ IGNvbmZpZ3VyZWQgdG8gaW1tZWRpYXRlIG1vZGUsIGJ1dCBnaXZlbiB0aGF0IHRoZSBjb250cm9s bGVyIG1pZ2h0IG5vdAo+IGhhdmUgYWxsIGZvdXIgc2Vuc29ycyBjb25uZWN0ZWQsIHRoaXMgd291 bGQgY2F1c2UgaW50ZXJydXB0cyB0byB0cmlnZ2VyCj4gZm9yIG5vbi1leGlzdGVudCBzZW5zb3Jz LiBGaXggdGhpcyBieSBoYW5kbGluZyB0aGUgTVNSQ1RMMSByZWdpc3Rlcgo+IGFuYWxvZ291c2x5 IHRvIHRoZSBNT05DVEwwOiBvbmx5IGVuYWJsZSB0aGUgc2Vuc29ycyB0aGF0IHdlcmUgZGVjbGFy ZWQuCgoKUmV2aWV3ZWQtYnk6IEFsZXhhbmRyZSBNZXJnbmF0IDxhbWVyZ25hdEBiYXlsaWJyZS5j b20+CgotLSAKUmVnYXJkcywKQWxleGFuZHJlCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1h cm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcv bWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==