From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 169D2C433DF for ; Thu, 13 Aug 2020 10:03:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E61D120781 for ; Thu, 13 Aug 2020 10:03:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="Et1S1Eyp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726072AbgHMKDT (ORCPT ); Thu, 13 Aug 2020 06:03:19 -0400 Received: from fllv0015.ext.ti.com ([198.47.19.141]:46346 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726048AbgHMKDT (ORCPT ); Thu, 13 Aug 2020 06:03:19 -0400 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 07DA3AxV013498; Thu, 13 Aug 2020 05:03:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1597312990; bh=/AO2wK7pWlJylET/IzLEhd/kD3jlI7C4dYt61mYsxA0=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=Et1S1EypeJpYpFQxQxHP3L+7/GHGy22pcqlO6Kp9dcCx4HQ1JGCxa/jnhsd3uq2ND 3VCA0IyaSTIvz1xOhMG4ESrYIQlq03Vi7ZT8mFblITZpCSOXlneLy1/9pBiuwR6Yep dMXzJc7aFgWi60mwhMquYqIulBHlDCFvSAqAJrVI= Received: from DLEE105.ent.ti.com (dlee105.ent.ti.com [157.170.170.35]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTP id 07DA3AQT043840; Thu, 13 Aug 2020 05:03:10 -0500 Received: from DLEE101.ent.ti.com (157.170.170.31) by DLEE105.ent.ti.com (157.170.170.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Thu, 13 Aug 2020 05:03:10 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE101.ent.ti.com (157.170.170.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Thu, 13 Aug 2020 05:03:10 -0500 Received: from [10.24.69.198] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 07DA35db063204; Thu, 13 Aug 2020 05:03:06 -0500 Subject: Re: [PATCH v6 00/13] irqchip: ti,sci-intr/inta: Update the dt bindings to accept different interrupt parents To: Peter Ujfalusi , Lokesh Vutla , Marc Zyngier , Rob Herring , Vinod CC: Thomas Gleixner , Nishanth Menon , Tero Kristo , Santosh Shilimkar , Linux ARM Mailing List , Grygorii Strashko , Device Tree Mailing List , Suman Anna References: <20200806074826.24607-1-lokeshvutla@ti.com> <31a0d207-cafa-8524-0364-b0bc55db6f6d@ti.com> From: Sekhar Nori Message-ID: <26dffb1a-8e1b-db7f-dde6-98af607799f5@ti.com> Date: Thu, 13 Aug 2020 15:33:05 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <31a0d207-cafa-8524-0364-b0bc55db6f6d@ti.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 8/13/20 3:11 PM, Peter Ujfalusi wrote: > Hi Lokesh, > > On 06/08/2020 10.48, Lokesh Vutla wrote: >> Hi Marc, >> This is continuation of the RFC patches[0] regarding the driver >> updates to support for following interrupt parent connection: >> - INTR -> INTR >> - INTA -> GICv3 >> The current existing driver assumes that INTR is always connected to >> GICv3 and INTA is always connected to INTR. >> >> As discussed this change breaks the DT backward compatibility but it >> allows to not depend on TISCI firmware properties in DT node. IMHO, this >> will ensure that any future changes will not effect DT properties. > > Just to note: > this series will demand new sysfw (with ABI 3.0+) to boot (well, to have > usable intr/inta). Sysfw ABI 3.0 carries other non compatible changes > affecting DMA on am654: TR mode channels for servicing peripherals will > fail at request time since the channel OES offset value is different > compared to older sysfw ABI. > > The good news is that other channels are _not_ affected by this, so > packet mode channels and mem2mem TR channel pairs will work just fine - > as you have tested it already w/ NFS boot. > We do not have upstream users for TR mode channels for peripherals, it > is only in my local branch for audio. > > I can send a patch for UDMA to be picked up by Marc on top of this > series to avoid this, if it is OK with Marc to pick it up. This series is already straddling too many subsystems, I would not complicate this any further. Moreover, since there are no upstream users for TR mode peripheral channels those changes can wait, right? Thanks, Sekhar From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0FCEC433E1 for ; Thu, 13 Aug 2020 10:04:48 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8CD2820781 for ; Thu, 13 Aug 2020 10:04:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="eaGthNx6"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ti.com header.i=@ti.com header.b="Et1S1Eyp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8CD2820781 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZK89pc7RYEzdFmp9TEKqXJ4CEJuBzPgGL333IK3plFU=; b=eaGthNx6tQBf14+GOU+cdoCDB 2iCwrYXp1hIFUhvc8wwaNftHHHP1oYJdGmuX51w5Thu06ZRROiBJsSEsAuZcJVzO4S3ofB2rVygmz wf2wD9KXgX4qH1g+STziOo8LhJ2gQNz1jxdH5o5AM1YQ0E7Hkzxjll4HHJFKQ0nbHunugtq8twvpF T3dE55MogIlF7CYz98Tcz2zCpBSO5K7TmOgJLxzyNK7/x7VeRbbmQdEMZaRR4HThcCEYLHHnpus26 5wgi3Dcp4aMhpuS43U/TD3THBAojCUJ/knd5hKvBmRhMAMYlQg/Jm+ef9ODFNxuz7zT8P8lTyfODv +qFkkuwTA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k6A4u-0000yj-Lc; Thu, 13 Aug 2020 10:03:20 +0000 Received: from fllv0015.ext.ti.com ([198.47.19.141]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k6A4r-0000xG-H5 for linux-arm-kernel@lists.infradead.org; Thu, 13 Aug 2020 10:03:18 +0000 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 07DA3AxV013498; Thu, 13 Aug 2020 05:03:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1597312990; bh=/AO2wK7pWlJylET/IzLEhd/kD3jlI7C4dYt61mYsxA0=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=Et1S1EypeJpYpFQxQxHP3L+7/GHGy22pcqlO6Kp9dcCx4HQ1JGCxa/jnhsd3uq2ND 3VCA0IyaSTIvz1xOhMG4ESrYIQlq03Vi7ZT8mFblITZpCSOXlneLy1/9pBiuwR6Yep dMXzJc7aFgWi60mwhMquYqIulBHlDCFvSAqAJrVI= Received: from DLEE105.ent.ti.com (dlee105.ent.ti.com [157.170.170.35]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTP id 07DA3AQT043840; Thu, 13 Aug 2020 05:03:10 -0500 Received: from DLEE101.ent.ti.com (157.170.170.31) by DLEE105.ent.ti.com (157.170.170.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Thu, 13 Aug 2020 05:03:10 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE101.ent.ti.com (157.170.170.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Thu, 13 Aug 2020 05:03:10 -0500 Received: from [10.24.69.198] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 07DA35db063204; Thu, 13 Aug 2020 05:03:06 -0500 Subject: Re: [PATCH v6 00/13] irqchip: ti,sci-intr/inta: Update the dt bindings to accept different interrupt parents To: Peter Ujfalusi , Lokesh Vutla , Marc Zyngier , Rob Herring , Vinod References: <20200806074826.24607-1-lokeshvutla@ti.com> <31a0d207-cafa-8524-0364-b0bc55db6f6d@ti.com> From: Sekhar Nori Message-ID: <26dffb1a-8e1b-db7f-dde6-98af607799f5@ti.com> Date: Thu, 13 Aug 2020 15:33:05 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <31a0d207-cafa-8524-0364-b0bc55db6f6d@ti.com> Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200813_060317_663396_CA087538 X-CRM114-Status: GOOD ( 22.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nishanth Menon , Device Tree Mailing List , Grygorii Strashko , Tero Kristo , Santosh Shilimkar , Thomas Gleixner , Linux ARM Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 8/13/20 3:11 PM, Peter Ujfalusi wrote: > Hi Lokesh, > > On 06/08/2020 10.48, Lokesh Vutla wrote: >> Hi Marc, >> This is continuation of the RFC patches[0] regarding the driver >> updates to support for following interrupt parent connection: >> - INTR -> INTR >> - INTA -> GICv3 >> The current existing driver assumes that INTR is always connected to >> GICv3 and INTA is always connected to INTR. >> >> As discussed this change breaks the DT backward compatibility but it >> allows to not depend on TISCI firmware properties in DT node. IMHO, this >> will ensure that any future changes will not effect DT properties. > > Just to note: > this series will demand new sysfw (with ABI 3.0+) to boot (well, to have > usable intr/inta). Sysfw ABI 3.0 carries other non compatible changes > affecting DMA on am654: TR mode channels for servicing peripherals will > fail at request time since the channel OES offset value is different > compared to older sysfw ABI. > > The good news is that other channels are _not_ affected by this, so > packet mode channels and mem2mem TR channel pairs will work just fine - > as you have tested it already w/ NFS boot. > We do not have upstream users for TR mode channels for peripherals, it > is only in my local branch for audio. > > I can send a patch for UDMA to be picked up by Marc on top of this > series to avoid this, if it is OK with Marc to pick it up. This series is already straddling too many subsystems, I would not complicate this any further. Moreover, since there are no upstream users for TR mode peripheral channels those changes can wait, right? Thanks, Sekhar _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel