From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.4 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3F34C433DB for ; Thu, 4 Feb 2021 18:21:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7FE2364F45 for ; Thu, 4 Feb 2021 18:21:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238969AbhBDSUr (ORCPT ); Thu, 4 Feb 2021 13:20:47 -0500 Received: from mx2.suse.de ([195.135.220.15]:59498 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238938AbhBDSTa (ORCPT ); Thu, 4 Feb 2021 13:19:30 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 9DC79AC45; Thu, 4 Feb 2021 18:18:49 +0000 (UTC) Subject: Re: [PATCH v6 06/10] drm/qxl: properly pin/unpin shadow To: Gerd Hoffmann , dri-devel@lists.freedesktop.org Cc: Dave Airlie , David Airlie , Daniel Vetter , "open list:DRM DRIVER FOR QXL VIRTUAL GPU" , "open list:DRM DRIVER FOR QXL VIRTUAL GPU" , open list References: <20210204145712.1531203-1-kraxel@redhat.com> <20210204145712.1531203-7-kraxel@redhat.com> From: Thomas Zimmermann Message-ID: <26e46352-9804-f7bd-416e-9304de839e22@suse.de> Date: Thu, 4 Feb 2021 19:18:48 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <20210204145712.1531203-7-kraxel@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="puhXiUl0yb9wyvcqleNQ0FC5PygyaUJjl" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --puhXiUl0yb9wyvcqleNQ0FC5PygyaUJjl Content-Type: multipart/mixed; boundary="bVdDgZUP1a5PNggIVo8wmhttgCyoTsyiI"; protected-headers="v1" From: Thomas Zimmermann To: Gerd Hoffmann , dri-devel@lists.freedesktop.org Cc: Dave Airlie , David Airlie , Daniel Vetter , "open list:DRM DRIVER FOR QXL VIRTUAL GPU" , "open list:DRM DRIVER FOR QXL VIRTUAL GPU" , open list Message-ID: <26e46352-9804-f7bd-416e-9304de839e22@suse.de> Subject: Re: [PATCH v6 06/10] drm/qxl: properly pin/unpin shadow References: <20210204145712.1531203-1-kraxel@redhat.com> <20210204145712.1531203-7-kraxel@redhat.com> In-Reply-To: <20210204145712.1531203-7-kraxel@redhat.com> --bVdDgZUP1a5PNggIVo8wmhttgCyoTsyiI Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable Am 04.02.21 um 15:57 schrieb Gerd Hoffmann: > Suggested-by: Thomas Zimmermann > Signed-off-by: Gerd Hoffmann Thanks for this. Acked-by: Thomas Zimmermann > --- > drivers/gpu/drm/qxl/qxl_display.c | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/drivers/gpu/drm/qxl/qxl_display.c b/drivers/gpu/drm/qxl/qx= l_display.c > index 60331e31861a..d25fd3acc891 100644 > --- a/drivers/gpu/drm/qxl/qxl_display.c > +++ b/drivers/gpu/drm/qxl/qxl_display.c > @@ -802,12 +802,14 @@ static int qxl_plane_prepare_fb(struct drm_plane = *plane, > } > if (user_bo->shadow !=3D qdev->dumb_shadow_bo) { > if (user_bo->shadow) { > + qxl_bo_unpin(user_bo->shadow); > drm_gem_object_put > (&user_bo->shadow->tbo.base); > user_bo->shadow =3D NULL; > } > drm_gem_object_get(&qdev->dumb_shadow_bo->tbo.base); > user_bo->shadow =3D qdev->dumb_shadow_bo; > + qxl_bo_pin(user_bo->shadow); > } > } > =20 > @@ -833,6 +835,7 @@ static void qxl_plane_cleanup_fb(struct drm_plane *= plane, > qxl_bo_unpin(user_bo); > =20 > if (old_state->fb !=3D plane->state->fb && user_bo->shadow) { > + qxl_bo_unpin(user_bo->shadow); > drm_gem_object_put(&user_bo->shadow->tbo.base); > user_bo->shadow =3D NULL; > } > @@ -1230,6 +1233,7 @@ int qxl_modeset_init(struct qxl_device *qdev) > void qxl_modeset_fini(struct qxl_device *qdev) > { > if (qdev->dumb_shadow_bo) { > + qxl_bo_unpin(qdev->dumb_shadow_bo); > drm_gem_object_put(&qdev->dumb_shadow_bo->tbo.base); > qdev->dumb_shadow_bo =3D NULL; > } >=20 --=20 Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany (HRB 36809, AG N=C3=BCrnberg) Gesch=C3=A4ftsf=C3=BChrer: Felix Imend=C3=B6rffer --bVdDgZUP1a5PNggIVo8wmhttgCyoTsyiI-- --puhXiUl0yb9wyvcqleNQ0FC5PygyaUJjl Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsF5BAABCAAjFiEExndm/fpuMUdwYFFolh/E3EQov+AFAmAcOogFAwAAAAAACgkQlh/E3EQov+Dg Vg/+MUInIKH8GpLCOyMWjazU0ZyjdPK+V/ovGgU1m6paa5rIQo2By75Mk2CBWYoEX5C3jVg8BAq7 CuULKTn6Qzy58+h5vJhK8qdQfzCRPN6a3OBycUHiuwaZWLBbr39QbJYIMYl2gz2GAR7wdx051ZnP h+3PwY6fMUQbklPO34p7IneF19eOspTehL6wmirOv7njTu74VJpkDIpaJEC2VTOJl6L13uYYlFg+ p6ukjInHCkR/+4Uc0SnSR64+Ts71FrNtKoWcE4Vu1KQprd7OUVOGbn/BYl3qQP9auhGXW9NhXpmS b/vueXUfzHk0VuPjMPcp7/LJvA9wG1DBn1Cddm+FMoiGYoH7vPOOY/yH4A+NnGjiyFH+Jo4Ug2yU eGwQyXdnmzQyj6OXMrD6FaxyCx0Y7HdefvmM/5/dSX/qWoy2YqjVb9bFfRMRHIPGc6nEaEKo7s1o ESwZCkHBsn+aPCatdhrLbySrZjtI0pdTdBUBsHOFCtgh523GP24jtn7KZe0h5vbhPUPtT5zq0yNc Ix367RqSVvS2J9r0C0eg748FyufuQEKib37D+qIcW68u8xWe2xx1gpeDIv5VfHq1Z5eSEVuuv5mA osWrF0qYo4TVnIOX2bTqtTW8V2/5orsYkXp5jNgAxz/NbdCSyt/8JASh9aXdFsweHe+CL1yXGQxo +FA= =ReK/ -----END PGP SIGNATURE----- --puhXiUl0yb9wyvcqleNQ0FC5PygyaUJjl-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.4 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D1C0C433E0 for ; Thu, 4 Feb 2021 18:18:59 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7FEA164F44 for ; Thu, 4 Feb 2021 18:18:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7FEA164F44 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=virtualization-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 30A848723D; Thu, 4 Feb 2021 18:18:58 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MJEzvL-CvVaj; Thu, 4 Feb 2021 18:18:57 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by hemlock.osuosl.org (Postfix) with ESMTP id 8B76187234; Thu, 4 Feb 2021 18:18:57 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 7C4CBC0174; Thu, 4 Feb 2021 18:18:57 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id F3B92C013A for ; Thu, 4 Feb 2021 18:18:52 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id EB9222D059 for ; Thu, 4 Feb 2021 18:18:52 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zEQGijE1MZSN for ; Thu, 4 Feb 2021 18:18:51 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by silver.osuosl.org (Postfix) with ESMTPS id 27710203D5 for ; Thu, 4 Feb 2021 18:18:51 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 9DC79AC45; Thu, 4 Feb 2021 18:18:49 +0000 (UTC) Subject: Re: [PATCH v6 06/10] drm/qxl: properly pin/unpin shadow To: Gerd Hoffmann , dri-devel@lists.freedesktop.org References: <20210204145712.1531203-1-kraxel@redhat.com> <20210204145712.1531203-7-kraxel@redhat.com> From: Thomas Zimmermann Message-ID: <26e46352-9804-f7bd-416e-9304de839e22@suse.de> Date: Thu, 4 Feb 2021 19:18:48 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <20210204145712.1531203-7-kraxel@redhat.com> Cc: David Airlie , open list , "open list:DRM DRIVER FOR QXL VIRTUAL GPU" , Daniel Vetter , "open list:DRM DRIVER FOR QXL VIRTUAL GPU" , Dave Airlie X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============1107855276164547810==" Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============1107855276164547810== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="puhXiUl0yb9wyvcqleNQ0FC5PygyaUJjl" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --puhXiUl0yb9wyvcqleNQ0FC5PygyaUJjl Content-Type: multipart/mixed; boundary="bVdDgZUP1a5PNggIVo8wmhttgCyoTsyiI"; protected-headers="v1" From: Thomas Zimmermann To: Gerd Hoffmann , dri-devel@lists.freedesktop.org Cc: Dave Airlie , David Airlie , Daniel Vetter , "open list:DRM DRIVER FOR QXL VIRTUAL GPU" , "open list:DRM DRIVER FOR QXL VIRTUAL GPU" , open list Message-ID: <26e46352-9804-f7bd-416e-9304de839e22@suse.de> Subject: Re: [PATCH v6 06/10] drm/qxl: properly pin/unpin shadow References: <20210204145712.1531203-1-kraxel@redhat.com> <20210204145712.1531203-7-kraxel@redhat.com> In-Reply-To: <20210204145712.1531203-7-kraxel@redhat.com> --bVdDgZUP1a5PNggIVo8wmhttgCyoTsyiI Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable Am 04.02.21 um 15:57 schrieb Gerd Hoffmann: > Suggested-by: Thomas Zimmermann > Signed-off-by: Gerd Hoffmann Thanks for this. Acked-by: Thomas Zimmermann > --- > drivers/gpu/drm/qxl/qxl_display.c | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/drivers/gpu/drm/qxl/qxl_display.c b/drivers/gpu/drm/qxl/qx= l_display.c > index 60331e31861a..d25fd3acc891 100644 > --- a/drivers/gpu/drm/qxl/qxl_display.c > +++ b/drivers/gpu/drm/qxl/qxl_display.c > @@ -802,12 +802,14 @@ static int qxl_plane_prepare_fb(struct drm_plane = *plane, > } > if (user_bo->shadow !=3D qdev->dumb_shadow_bo) { > if (user_bo->shadow) { > + qxl_bo_unpin(user_bo->shadow); > drm_gem_object_put > (&user_bo->shadow->tbo.base); > user_bo->shadow =3D NULL; > } > drm_gem_object_get(&qdev->dumb_shadow_bo->tbo.base); > user_bo->shadow =3D qdev->dumb_shadow_bo; > + qxl_bo_pin(user_bo->shadow); > } > } > =20 > @@ -833,6 +835,7 @@ static void qxl_plane_cleanup_fb(struct drm_plane *= plane, > qxl_bo_unpin(user_bo); > =20 > if (old_state->fb !=3D plane->state->fb && user_bo->shadow) { > + qxl_bo_unpin(user_bo->shadow); > drm_gem_object_put(&user_bo->shadow->tbo.base); > user_bo->shadow =3D NULL; > } > @@ -1230,6 +1233,7 @@ int qxl_modeset_init(struct qxl_device *qdev) > void qxl_modeset_fini(struct qxl_device *qdev) > { > if (qdev->dumb_shadow_bo) { > + qxl_bo_unpin(qdev->dumb_shadow_bo); > drm_gem_object_put(&qdev->dumb_shadow_bo->tbo.base); > qdev->dumb_shadow_bo =3D NULL; > } >=20 --=20 Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany (HRB 36809, AG N=C3=BCrnberg) Gesch=C3=A4ftsf=C3=BChrer: Felix Imend=C3=B6rffer --bVdDgZUP1a5PNggIVo8wmhttgCyoTsyiI-- --puhXiUl0yb9wyvcqleNQ0FC5PygyaUJjl Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsF5BAABCAAjFiEExndm/fpuMUdwYFFolh/E3EQov+AFAmAcOogFAwAAAAAACgkQlh/E3EQov+Dg Vg/+MUInIKH8GpLCOyMWjazU0ZyjdPK+V/ovGgU1m6paa5rIQo2By75Mk2CBWYoEX5C3jVg8BAq7 CuULKTn6Qzy58+h5vJhK8qdQfzCRPN6a3OBycUHiuwaZWLBbr39QbJYIMYl2gz2GAR7wdx051ZnP h+3PwY6fMUQbklPO34p7IneF19eOspTehL6wmirOv7njTu74VJpkDIpaJEC2VTOJl6L13uYYlFg+ p6ukjInHCkR/+4Uc0SnSR64+Ts71FrNtKoWcE4Vu1KQprd7OUVOGbn/BYl3qQP9auhGXW9NhXpmS b/vueXUfzHk0VuPjMPcp7/LJvA9wG1DBn1Cddm+FMoiGYoH7vPOOY/yH4A+NnGjiyFH+Jo4Ug2yU eGwQyXdnmzQyj6OXMrD6FaxyCx0Y7HdefvmM/5/dSX/qWoy2YqjVb9bFfRMRHIPGc6nEaEKo7s1o ESwZCkHBsn+aPCatdhrLbySrZjtI0pdTdBUBsHOFCtgh523GP24jtn7KZe0h5vbhPUPtT5zq0yNc Ix367RqSVvS2J9r0C0eg748FyufuQEKib37D+qIcW68u8xWe2xx1gpeDIv5VfHq1Z5eSEVuuv5mA osWrF0qYo4TVnIOX2bTqtTW8V2/5orsYkXp5jNgAxz/NbdCSyt/8JASh9aXdFsweHe+CL1yXGQxo +FA= =ReK/ -----END PGP SIGNATURE----- --puhXiUl0yb9wyvcqleNQ0FC5PygyaUJjl-- --===============1107855276164547810== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization --===============1107855276164547810==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.4 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29A8CC433E0 for ; Thu, 4 Feb 2021 18:18:53 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BCAA364F44 for ; Thu, 4 Feb 2021 18:18:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BCAA364F44 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 22EBA6EE24; Thu, 4 Feb 2021 18:18:52 +0000 (UTC) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 148086EE24; Thu, 4 Feb 2021 18:18:51 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 9DC79AC45; Thu, 4 Feb 2021 18:18:49 +0000 (UTC) Subject: Re: [PATCH v6 06/10] drm/qxl: properly pin/unpin shadow To: Gerd Hoffmann , dri-devel@lists.freedesktop.org References: <20210204145712.1531203-1-kraxel@redhat.com> <20210204145712.1531203-7-kraxel@redhat.com> From: Thomas Zimmermann Message-ID: <26e46352-9804-f7bd-416e-9304de839e22@suse.de> Date: Thu, 4 Feb 2021 19:18:48 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <20210204145712.1531203-7-kraxel@redhat.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , open list , "open list:DRM DRIVER FOR QXL VIRTUAL GPU" , "open list:DRM DRIVER FOR QXL VIRTUAL GPU" , Dave Airlie Content-Type: multipart/mixed; boundary="===============1214407006==" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============1214407006== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="puhXiUl0yb9wyvcqleNQ0FC5PygyaUJjl" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --puhXiUl0yb9wyvcqleNQ0FC5PygyaUJjl Content-Type: multipart/mixed; boundary="bVdDgZUP1a5PNggIVo8wmhttgCyoTsyiI"; protected-headers="v1" From: Thomas Zimmermann To: Gerd Hoffmann , dri-devel@lists.freedesktop.org Cc: Dave Airlie , David Airlie , Daniel Vetter , "open list:DRM DRIVER FOR QXL VIRTUAL GPU" , "open list:DRM DRIVER FOR QXL VIRTUAL GPU" , open list Message-ID: <26e46352-9804-f7bd-416e-9304de839e22@suse.de> Subject: Re: [PATCH v6 06/10] drm/qxl: properly pin/unpin shadow References: <20210204145712.1531203-1-kraxel@redhat.com> <20210204145712.1531203-7-kraxel@redhat.com> In-Reply-To: <20210204145712.1531203-7-kraxel@redhat.com> --bVdDgZUP1a5PNggIVo8wmhttgCyoTsyiI Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable Am 04.02.21 um 15:57 schrieb Gerd Hoffmann: > Suggested-by: Thomas Zimmermann > Signed-off-by: Gerd Hoffmann Thanks for this. Acked-by: Thomas Zimmermann > --- > drivers/gpu/drm/qxl/qxl_display.c | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/drivers/gpu/drm/qxl/qxl_display.c b/drivers/gpu/drm/qxl/qx= l_display.c > index 60331e31861a..d25fd3acc891 100644 > --- a/drivers/gpu/drm/qxl/qxl_display.c > +++ b/drivers/gpu/drm/qxl/qxl_display.c > @@ -802,12 +802,14 @@ static int qxl_plane_prepare_fb(struct drm_plane = *plane, > } > if (user_bo->shadow !=3D qdev->dumb_shadow_bo) { > if (user_bo->shadow) { > + qxl_bo_unpin(user_bo->shadow); > drm_gem_object_put > (&user_bo->shadow->tbo.base); > user_bo->shadow =3D NULL; > } > drm_gem_object_get(&qdev->dumb_shadow_bo->tbo.base); > user_bo->shadow =3D qdev->dumb_shadow_bo; > + qxl_bo_pin(user_bo->shadow); > } > } > =20 > @@ -833,6 +835,7 @@ static void qxl_plane_cleanup_fb(struct drm_plane *= plane, > qxl_bo_unpin(user_bo); > =20 > if (old_state->fb !=3D plane->state->fb && user_bo->shadow) { > + qxl_bo_unpin(user_bo->shadow); > drm_gem_object_put(&user_bo->shadow->tbo.base); > user_bo->shadow =3D NULL; > } > @@ -1230,6 +1233,7 @@ int qxl_modeset_init(struct qxl_device *qdev) > void qxl_modeset_fini(struct qxl_device *qdev) > { > if (qdev->dumb_shadow_bo) { > + qxl_bo_unpin(qdev->dumb_shadow_bo); > drm_gem_object_put(&qdev->dumb_shadow_bo->tbo.base); > qdev->dumb_shadow_bo =3D NULL; > } >=20 --=20 Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany (HRB 36809, AG N=C3=BCrnberg) Gesch=C3=A4ftsf=C3=BChrer: Felix Imend=C3=B6rffer --bVdDgZUP1a5PNggIVo8wmhttgCyoTsyiI-- --puhXiUl0yb9wyvcqleNQ0FC5PygyaUJjl Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsF5BAABCAAjFiEExndm/fpuMUdwYFFolh/E3EQov+AFAmAcOogFAwAAAAAACgkQlh/E3EQov+Dg Vg/+MUInIKH8GpLCOyMWjazU0ZyjdPK+V/ovGgU1m6paa5rIQo2By75Mk2CBWYoEX5C3jVg8BAq7 CuULKTn6Qzy58+h5vJhK8qdQfzCRPN6a3OBycUHiuwaZWLBbr39QbJYIMYl2gz2GAR7wdx051ZnP h+3PwY6fMUQbklPO34p7IneF19eOspTehL6wmirOv7njTu74VJpkDIpaJEC2VTOJl6L13uYYlFg+ p6ukjInHCkR/+4Uc0SnSR64+Ts71FrNtKoWcE4Vu1KQprd7OUVOGbn/BYl3qQP9auhGXW9NhXpmS b/vueXUfzHk0VuPjMPcp7/LJvA9wG1DBn1Cddm+FMoiGYoH7vPOOY/yH4A+NnGjiyFH+Jo4Ug2yU eGwQyXdnmzQyj6OXMrD6FaxyCx0Y7HdefvmM/5/dSX/qWoy2YqjVb9bFfRMRHIPGc6nEaEKo7s1o ESwZCkHBsn+aPCatdhrLbySrZjtI0pdTdBUBsHOFCtgh523GP24jtn7KZe0h5vbhPUPtT5zq0yNc Ix367RqSVvS2J9r0C0eg748FyufuQEKib37D+qIcW68u8xWe2xx1gpeDIv5VfHq1Z5eSEVuuv5mA osWrF0qYo4TVnIOX2bTqtTW8V2/5orsYkXp5jNgAxz/NbdCSyt/8JASh9aXdFsweHe+CL1yXGQxo +FA= =ReK/ -----END PGP SIGNATURE----- --puhXiUl0yb9wyvcqleNQ0FC5PygyaUJjl-- --===============1214407006== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel --===============1214407006==--