Re: [PATCH linux dev-4.13 1/4] fsi/occ: Add retries on SBE errors

[Eddie James <eajames@linux.vnet.ibm.com>]

On 05/21/2018 05:53 PM, Benjamin Herrenschmidt wrote:
> On Mon, 2018-05-21 at 13:48 -0500, Eddie James wrote:
>>>> 3.3.1 BMC-OCC Communication Failure Handling
>>>>
>>>> On failures communicating with an OCC the BMC should first verify
>>>> that the “OCC Active” sensor is TRUE.  If the OCCs are not active the
>>>> error should be ignored and communication with the OCC should not be
>>>> retired until the “OCC Active” sensor is TRUE.  If the “OCC Active”
>>>> sensor is TRUE the command should be retried twice.
>>> What is the "OCC Active sensor" ?
>> It's a value in the OCC poll response.
> That's only useful if you can get that response then... which you can't
> if the communication fails. I'm missing something here.

Ah. There is also the IPMI OCC active sensor, which is what this must 
mean. We're doing this correctly by unbinding the occ-hwmon driver when 
the OCC active sensor comes in false. So, if driver is bound, OCC active 
must be true, so we "retry" twice by only setting the error attribute 
after two failed poll responses.

Thanks... sorry for the mixup.
Eddie

>
> Ben.
>