From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59047) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bKnOH-0005EQ-E0 for qemu-devel@nongnu.org; Wed, 06 Jul 2016 10:01:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bKnOB-0003DJ-0V for qemu-devel@nongnu.org; Wed, 06 Jul 2016 10:01:24 -0400 References: <1467732272-23368-1-git-send-email-clord@redhat.com> <1467732272-23368-4-git-send-email-clord@redhat.com> From: Max Reitz Message-ID: <26f0012a-2791-4758-1e3b-5782bc15f76a@redhat.com> Date: Wed, 6 Jul 2016 16:01:02 +0200 MIME-Version: 1.0 In-Reply-To: <1467732272-23368-4-git-send-email-clord@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="KgBVw7unQF3C5bSGvt94Mf2mabl1aiAiX" Subject: Re: [Qemu-devel] [PATCH v3 03/32] blockdev: Add dynamic module loading for block drivers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Colin Lord , qemu-devel@nongnu.org Cc: kwolf@redhat.com, qemu-block@nongnu.org, Marc Mari This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --KgBVw7unQF3C5bSGvt94Mf2mabl1aiAiX From: Max Reitz To: Colin Lord , qemu-devel@nongnu.org Cc: kwolf@redhat.com, qemu-block@nongnu.org, Marc Mari Message-ID: <26f0012a-2791-4758-1e3b-5782bc15f76a@redhat.com> Subject: Re: [PATCH v3 03/32] blockdev: Add dynamic module loading for block drivers References: <1467732272-23368-1-git-send-email-clord@redhat.com> <1467732272-23368-4-git-send-email-clord@redhat.com> In-Reply-To: <1467732272-23368-4-git-send-email-clord@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05.07.2016 17:24, Colin Lord wrote: > From: Marc Mari >=20 > Extend the current module interface to allow for block drivers to be lo= aded > dynamically on request. >=20 > The only block drivers that can be converted into modules are the drive= rs > that don't perform any init operation except for registering themselves= =2E >=20 > All the necessary module information is located in a new structure foun= d in > module_block.h >=20 > Signed-off-by: Marc Mar=C3=AD > Signed-off-by: Colin Lord > --- > block.c | 110 ++++++++++++++++++++++++++++++++++++++++++= -------- > include/qemu/module.h | 3 ++ > util/module.c | 38 +++++------------ > 3 files changed, 108 insertions(+), 43 deletions(-) Reviewed-by: Max Reitz > diff --git a/block.c b/block.c > index f4648e9..88a05b2 100644 > --- a/block.c > +++ b/block.c [...] > + for (n =3D 0; n < ARRAY_SIZE(block_driver_modules); n++) { (yay for post-increment) --KgBVw7unQF3C5bSGvt94Mf2mabl1aiAiX Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEvBAEBCAAZBQJXfQ8eEhxtcmVpdHpAcmVkaGF0LmNvbQAKCRA7sUIC6DisrQbP CACFoU8hrgAx7PKC+UGKjzSykiDPAbunioJqO+F0wm0a2mpeiOTfYcM+91UJsiRv k6meE6sErIO5ZWqhtWQEeg0+VSIK8gU5qbEzQEH37WqLvzNwj1S9m/apFRuv/9Cl gerGmGg7lodLabq0aDt6gQdhOp2rapSceLTBQtRfepRNWtUmeJB/RGhXWYa6DZmb dZdaLE0gFwFXoQfIRiSUKRKPDYTEM63nDX8QAHWgygY4lTCLfOUKv43M0RnYqJGV pcP0pSZQQLcWz6X4LgEGyCsq28dzs5OpWWJB7Daiuniip4LktKF6Z1KULz8us5wS Z9SS89pP9WdaXXqV4EqYeB5N =7Th2 -----END PGP SIGNATURE----- --KgBVw7unQF3C5bSGvt94Mf2mabl1aiAiX--