All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kever Yang <kever.yang@rock-chips.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot, 2/2] rockchip: Drop call to rockchip_dnl_mode_check() for now【请注意,邮件由u-boot-bounces@lists.denx.de代发】
Date: Fri, 1 Feb 2019 17:32:40 +0800	[thread overview]
Message-ID: <26f57e00-9162-cd4e-2fad-8cc459dcd8af@rock-chips.com> (raw)
In-Reply-To: <E1gpJd4-0008JF-BU@mail.theobroma-systems.com>

Hi Philipp,

    This is not right,  this patch should not merged like this!!!

    I have give my review comment in previous mail, and this will break
many boards.

    My another patch do not break anything, but you insist NAK it
without acceptable reason;
    This patch definitely break other board and I have comment it, but
you just ignore other people's review and merge it, good job!

Thanks,
- Kever
On 02/01/2019 05:12 AM, Philipp Tomsich wrote:
>> This function causes a 5-second delay and stops the display working on
>> minnie. This code should be in a driver and should only be enabled by
>> a device-tree property, so that it does not affect devices which do not
>> have this feature.
>>
>> Signed-off-by: Simon Glass <sjg@chromium.org>
>> Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
>> ---
>>
>>  arch/arm/mach-rockchip/boot_mode.c | 8 +++++++-
>>  1 file changed, 7 insertions(+), 1 deletion(-)
>>
> Applied to u-boot-rockchip, thanks!
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> https://lists.denx.de/listinfo/u-boot

  parent reply	other threads:[~2019-02-01  9:32 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-29 13:16 [U-Boot] [PATCH 1/2] rockchip: chromebook_minnie: Enable sound Simon Glass
2018-12-29 13:16 ` [U-Boot] [PATCH 2/2] rockchip: Drop call to rockchip_dnl_mode_check() for now Simon Glass
2018-12-29 17:57   ` Philipp Tomsich
2018-12-29 18:00     ` Philipp Tomsich
2019-01-10 12:56       ` Simon Glass
2019-01-03  7:32   ` [U-Boot] [PATCH 2/2] rockchip: Drop call to rockchip_dnl_mode_check() for now[Please note, mail behalf by 3vnmnxammciszqnjoyvtpbt.vynrlcly.fhunyvjr-jopwz.jvt@chromium-sendgmr.bounces.google.com] Kever Yang
2019-01-03 21:29     ` Simon Glass
2019-01-03 21:36       ` Philipp Tomsich
2019-01-31 21:12   ` [U-Boot] [U-Boot, 2/2] rockchip: Drop call to rockchip_dnl_mode_check() for now Philipp Tomsich
2019-02-01  1:32     ` andy.yan at rock-chips.com
2019-02-01  8:38       ` Philipp Tomsich
2019-02-01  8:39         ` Philipp Tomsich
2019-02-01  9:32     ` Kever Yang [this message]
2019-02-01  9:34       ` [U-Boot] [U-Boot, 2/2] rockchip: Drop call to rockchip_dnl_mode_check() for now【请注意,邮件由u-boot-bounces@lists.denx.de代发】 Philipp Tomsich
2019-02-01 10:26         ` Philipp Tomsich
2019-02-01 14:39           ` Simon Glass
2019-02-12  3:03           ` Andy Yan
2019-02-12 15:31             ` Simon Glass
2019-03-06 10:52               ` [U-Boot] [U-Boot, 2/2] rockchip: Drop call to rockchip_dnl_mode_check() for now【请注意,邮件由u-boot-bounces@lists.denx.de代发】【请注意,邮件由sjg@google.com代发】 Andy Yan
2019-03-11  2:30                 ` Simon Glass
2019-03-11 13:04                   ` Philipp Tomsich
2019-03-12  1:23                     ` [U-Boot] [U-Boot, 2/2] rockchip: Drop call to rockchip_dnl_mode_check() for now Kever Yang
2019-03-18 11:58                       ` Simon Glass
2019-03-18 12:07                         ` Philipp Tomsich
2019-03-12  6:28                   ` [U-Boot] [U-Boot, 2/2] rockchip: Drop call to rockchip_dnl_mode_check() for now【请注意,邮件由u-boot-bounces@lists.denx.de代发】【请注意,邮件由sjg@google.com代发】 Andy Yan
2019-01-27 17:31 ` [U-Boot] [U-Boot, 1/2] rockchip: chromebook_minnie: Enable sound Philipp Tomsich
2019-01-28  9:12 ` Philipp Tomsich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=26f57e00-9162-cd4e-2fad-8cc459dcd8af@rock-chips.com \
    --to=kever.yang@rock-chips.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.