All of lore.kernel.org
 help / color / mirror / Atom feed
From: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	"Eric W. Biederman" <ebiederm@xmission.com>
Subject: Re: [PATCH] proc/sysctl: prune stale dentries during unregistering
Date: Fri, 10 Feb 2017 10:54:07 +0300	[thread overview]
Message-ID: <26fa33ed-365e-f4c9-9270-421420c16163@yandex-team.ru> (raw)
In-Reply-To: <20170210074715.GN13195@ZenIV.linux.org.uk>

On 10.02.2017 10:47, Al Viro wrote:
> On Fri, Feb 10, 2017 at 10:35:02AM +0300, Konstantin Khlebnikov wrote:
>
>> # time sysctl -a > /dev/null
>> real    1m12.806s
>> user    0m0.016s
>> sys     1m12.400s
>>
>> Currently only memory reclaimer could remove this garbage.
>> But without significant memory pressure this never happens.
>>
>> This patch collects sysctl inodes into list on sysctl table header and
>> prunes all their dentries once that table unregisters.
>
> I'd probably go for hlist, but that's mostly cosmetic difference; how about
> the matching stats *after* that patch?
>

dcache size doesn't grow endlessly, so stats are fine

# sysctl fs.dentry-state
fs.dentry-state = 92712	58376	45	0	0	0

# time sysctl -a &>/dev/null

real	0m0.013s
user	0m0.004s
sys	0m0.008s

  reply	other threads:[~2017-02-10  7:58 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-08 10:48 [PATCH] proc/sysctl: drop unregistered stale dentries as soon as possible Konstantin Khlebnikov
2017-02-08 21:48 ` Andrew Morton
2017-02-09  3:53   ` Al Viro
2017-02-09  7:36     ` Konstantin Khlebnikov
2017-02-09  8:40       ` Al Viro
2017-02-10  7:35         ` [PATCH] proc/sysctl: prune stale dentries during unregistering Konstantin Khlebnikov
2017-02-10  7:47           ` Al Viro
2017-02-10  7:54             ` Konstantin Khlebnikov [this message]
2017-02-13  9:54               ` Eric W. Biederman
2017-02-18 18:55           ` Konstantin Khlebnikov
2017-02-19  8:42             ` Al Viro
2017-02-21  1:41               ` [REVIEW][PATCH] proc/sysctl: Don't grab i_lock under sysctl_lock Eric W. Biederman
2017-02-21  8:40                 ` Konstantin Khlebnikov
2017-02-21 19:29                   ` Eric W. Biederman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=26fa33ed-365e-f4c9-9270-421420c16163@yandex-team.ru \
    --to=khlebnikov@yandex-team.ru \
    --cc=akpm@linux-foundation.org \
    --cc=ebiederm@xmission.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.