From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60B0CC43381 for ; Mon, 18 Mar 2019 23:00:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 375952171F for ; Mon, 18 Mar 2019 23:00:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726998AbfCRXAm convert rfc822-to-8bit (ORCPT ); Mon, 18 Mar 2019 19:00:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35260 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726927AbfCRXAm (ORCPT ); Mon, 18 Mar 2019 19:00:42 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2582FC049E24; Mon, 18 Mar 2019 23:00:42 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-120-17.rdu2.redhat.com [10.10.120.17]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6625D600C2; Mon, 18 Mar 2019 23:00:41 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20190318050022.7833-1-jencce.kernel@gmail.com> References: <20190318050022.7833-1-jencce.kernel@gmail.com> To: Murphy Zhou Cc: dhowells@redhat.com, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH] vfs: return EINVAL instead of ENOENT when missing source MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <27064.1552950040.1@warthog.procyon.org.uk> Content-Transfer-Encoding: 8BIT Date: Mon, 18 Mar 2019 23:00:40 +0000 Message-ID: <27065.1552950040@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Mon, 18 Mar 2019 23:00:42 +0000 (UTC) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Murphy Zhou wrote: > mount(2) with a NULL source device would return ENOENT instead of EINVAL > after this commit: > > commit f3a09c92018a91ad0981146a4ac59414f814d801 > Author: Al Viro > Date: Sun Dec 23 18:55:56 2018 -0500 > > introduce fs_context methods > > Change the return value to be compatible with the old behaviour. > > This was caught by LTP mount02[1]. This testcase is calling mount(2) with a > NULL device name and expecting EINVAL to PASS but now we are getting ENOENT. > > [1] https://github.com/linux-test-project/ltp/blob/master/testcases/kernel/syscalls/mount/mount02.c > > Signed-off-by: Murphy Zhou Reviewed-by: David Howells