Re: [PATCH v2 0/2] drm/blend: Add per-plane pixel blend mode property

[Lowry Li <lowry.li@arm.com>]

On Thu, May 31, 2018 at 06:22:26PM +0800, Lowry Li wrote:
> On Wed, May 30, 2018 at 10:40:40AM -0400, Sean Paul wrote:
> > On Wed, May 30, 2018 at 07:23:52PM +0800, Lowry Li wrote:
> > > Hi,
> > > 
> > > This serie aims at adding the support for pixel blend modes represent the
> > > alpha blending equation selection in the driver. It also introduces to use
> > > it in the malidp driver.
> > > 
> > > Let me know what you think,
> > 
> > Hi Lowry,
> > Thank you for doing this work. I know this is something that is missing for
> > proper Android support, so it's most welcome.
> > 
> > Do you have userspace patches using this property?
> > 
> > Sean
> > 
> > 
> Hi Sean,
> Thanks a lot for the reply. Yes, we have userspace patches, which is
> on the way. Will let you know once it's ready.
> 
> Thanks,
> Lowry
Hi Sean,
We've created a merge request on userspace patches. Please kindly check the
following link address at your time. Thanks:)
https://gitlab.freedesktop.org/drm-hwcomposer/drm-hwcomposer/merge_requests/16

Regards
Lowry
> > > Lowry
> > > 
> > > Changes for v2:
> > >  - Moves the blending equation into the DOC comment
> > >  - Refines the comments of drm_plane_create_blend_mode_property to not
> > >    enumerate the #defines, but instead the string values
> > >  - Uses fg.* instead of pixel.* and plane_alpha instead of plane.alpha
> > >  - Introduces to use it in the malidp driver, which depends on the plane
> > >    alpha patch
> > > 
> > > Changes from v1:
> > >  - v1 is just the core changes to request for commments
> > >  - Adds a pixel_blend_mode to drm_plane_state and a blend_mode_property to
> > >    drm_plane, and related support functions
> > >  - Defines three blend modes in drm_blend.h
> > >  - Rebased on current drm-next
> > > 
> > > Lowry Li (2):
> > >   drm/blend: Add per-plane pixel blend mode property
> > >   drm/mali-dp: Implement plane alpha and pixel blend on malidp
> > > 
> > >  drivers/gpu/drm/arm/malidp_planes.c |  76 ++++++++++++++-----------
> > >  drivers/gpu/drm/drm_atomic.c        |   4 ++
> > >  drivers/gpu/drm/drm_atomic_helper.c |   1 +
> > >  drivers/gpu/drm/drm_blend.c         | 110 ++++++++++++++++++++++++++++++++++++
> > >  include/drm/drm_blend.h             |   6 ++
> > >  include/drm/drm_plane.h             |   6 ++
> > >  6 files changed, 171 insertions(+), 32 deletions(-)
> > > 
> > > -- 
> > > 1.9.1
> > > 
> > 
> > -- 
> > Sean Paul, Software Engineer, Google / Chromium OS
> 
> -- 
> Regards,
> Lowry

-- 
Regards,
Lowry
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel