From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] net/vhost: Add function to retreive the 'vid' for a given port id. Date: Thu, 29 Sep 2016 11:30:43 +0200 Message-ID: <2712023.9XEuyBWnhG@xps13> References: <1473774463-26966-1-git-send-email-ciara.loftus@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: "Mcnamara, John" , "Loftus, Ciara" , "Liu, Yuanhan" Return-path: Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52]) by dpdk.org (Postfix) with ESMTP id 81FE637B4 for ; Thu, 29 Sep 2016 11:30:45 +0200 (CEST) Received: by mail-wm0-f52.google.com with SMTP id w84so285191583wmg.1 for ; Thu, 29 Sep 2016 02:30:45 -0700 (PDT) In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-09-29 09:21, Mcnamara, John: > > In some cases when using the vHost PMD, certain vHost library functions > > may still need to be accessed. One such example is the > > rte_vhost_get_queue_num function which returns the number of virtqueues > > reported by the guest - information which is not exposed by the PMD. > > > > This commit introduces a new rte_eth_vhost function that returns the 'vid' > > associated with a given port id. This allows the PMD user to call vHost > > library functions which require the 'vid' value. > > > > Signed-off-by: Ciara Loftus > > Acked-by: John McNamara A conclusion to this long thread: This patch can be helpful in many situations where we need vhost lib when using vhost PMD. And driver-specific API is acceptable. And this specific function is not a candidate to be promoted in ethdev. So it should go in release 16.11. When overlooking the OVS issue related, this solution seems to be a workaround. For next release, would it be possible to find a real fix for vhost PMD and/or ethdev API instead of relying on vhost lib?