From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] ethdev: rename folder to library name Date: Tue, 03 Apr 2018 14:20:30 +0200 Message-ID: <2713963.Nlhf7d0HAF@xps> References: <20180403092859.71589-1-ferruh.yigit@intel.com> <8464158.iTavIsMWKz@xps> <20180403105755.GB3544@bricha3-MOBL.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: Ferruh Yigit , John McNamara , Marko Kovacevic , dev@dpdk.org To: Bruce Richardson Return-path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id BBAEA1B6FA for ; Tue, 3 Apr 2018 14:20:56 +0200 (CEST) In-Reply-To: <20180403105755.GB3544@bricha3-MOBL.ger.corp.intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 03/04/2018 12:57, Bruce Richardson: > On Tue, Apr 03, 2018 at 12:24:15PM +0200, Thomas Monjalon wrote: > > 03/04/2018 11:28, Ferruh Yigit: > > > Library folder name and output library name are same except a few flaws > > > including librte_ether. > > > > > > This library is network device abstraction layer, the name "ethdev" fits > > > better than "ether", and library & header files already named as ethdev. > > > > > > Also there is a rte_ether.h in the net library which can cause confusion. > > > > > > Signed-off-by: Ferruh Yigit > > > --- > > > Not sure if the we are ready for this change J > > > > > > This is one the issues that the hassle of the change doesn't worth the > > > benefit and you may prefer to live with the flaw. > > > > > > Also a concern is this breaks the git history. > > > > Yes it breaks the git history. > > I am a big user of gitk. Do you know how to follow the history after rename > > with gitk? > > > > I think it is a good change but I would like to be sure it will not > > bother us every day. > > > For those of use with even slight OCD, having it the way it is bothers us > every day! :-) > I view this as something that we really should do some day - it's just > broken the way the way it is right now - and so the sooner we take the hit > and fix it, the better. Yes > If you do need to find the history of the file, would git blame work well > enough for you? No, blame is not enough, but it does not matter. When should we do this rename? 18.05-rc1?