From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 983CAC433ED for ; Thu, 22 Apr 2021 23:49:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5DBA76143B for ; Thu, 22 Apr 2021 23:49:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236949AbhDVXuB (ORCPT ); Thu, 22 Apr 2021 19:50:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47110 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230368AbhDVXuA (ORCPT ); Thu, 22 Apr 2021 19:50:00 -0400 Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C1DBFC061574; Thu, 22 Apr 2021 16:49:24 -0700 (PDT) Received: by mail-pl1-x632.google.com with SMTP id g16so7492759plq.3; Thu, 22 Apr 2021 16:49:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=IWfYoO0lSsj6QrdF4M9TVhiBQuuRKejv17Qbr6FkpHs=; b=POwfl7cE4Qcz1RenSpkCZiWAxw6lhRiLzZNY9Gg54NjNfXJSWLvpSa/LBmuIldfPHw nrr6RCnjKmzmZ3bWbdQmk8A/jbDyAEyaGPmcb421VfXnnY1L8pgTrNbnDBC/yuoDfgKz T3PNwP9pzPHw3dpSRe/tWnC7ubTOEenoqe0yDlJPATp5NlDzhXzUUTTUoEFW0d2M+X2B wOc1fh5jojyuGAhnrN8WrkDnKATakqCjzhwvLsKKUaYiQH7/lzozfDvO/xJ934r8VOPW 8Cf/PGPlNT8E4L8289BNJtNjJYwHp+RiNLLrSa2vXNz3lAY4Kxa0G40LmezScm5J2V/M gVQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=IWfYoO0lSsj6QrdF4M9TVhiBQuuRKejv17Qbr6FkpHs=; b=Pxw7pAmRdDSjEPdkpPuSF5XvxW4+RMspNRdB6NYUzbEXKI3bMdnHFarSU1zscNDgge bgMFU2GDnKNfrijMlc7QGvqiEIWQ1xVZVpA52RnjFSPMN5AcFLUy/G8tkAxHCz9g+CbM O2bjrVQ89AjITUnVKZ/AkyCNfcHteoaugF4lbWTAh8dOkk8iqaYVSBKF00c4ebdvJzQG FxRPgs0PA9szsM2/3SooiENtxAzksOFRCRrxZqvs6OLxRoaGK9NxKQNmHU7+L333VRW9 WeL7eAcI95ckFWTibT899Z/6vNVRmv2CT4VJ0UQefuJNGDtxsOppNEWIh8ZvTMGUsW07 M8Jw== X-Gm-Message-State: AOAM530RcYXZBOGMeombdwrkxnj3KFvpjRSZg2uKDVrLniAidN0rlJSn etMqC4r6prDU5ZjevSg8iG4= X-Google-Smtp-Source: ABdhPJyQ8CB6gfavGomE80wlX8RKriAm4NmmFeGRBR1BIbjZmGV4qhobzGGXuBVwCwVbP22GOXafIQ== X-Received: by 2002:a17:90a:8410:: with SMTP id j16mr1301384pjn.120.1619135364274; Thu, 22 Apr 2021 16:49:24 -0700 (PDT) Received: from [10.230.29.202] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id m20sm5615378pjq.40.2021.04.22.16.49.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Apr 2021 16:49:23 -0700 (PDT) Subject: Re: [PATCH] spi: bcm2835: Fix buffer overflow with CS able to go beyond limit. To: Joe Burmeister , Mark Brown , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, linux-spi@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, nsaenz@kernel.org References: <20210420083402.6950-1-joe.burmeister@devtank.co.uk> <7c9f9376-1a80-b624-7b9e-0f6d04437c02@devtank.co.uk> From: Florian Fainelli Message-ID: <271ad212-a606-620e-3f0c-d6bff272be3c@gmail.com> Date: Thu, 22 Apr 2021 16:49:19 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <7c9f9376-1a80-b624-7b9e-0f6d04437c02@devtank.co.uk> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/22/2021 1:10 PM, Joe Burmeister wrote: >> On 4/20/2021 1:34 AM, Joe Burmeister wrote: >>> It was previoulsy possible to have a device tree with more chips than >>> the driver supports and go off the end of CS arrays. >> Do you mind walking me through the code how that could have happened? We >> have spi_register_controller() call of_spi_get_gpio_numbers() which has >> the following: >> >> ctlr->num_chipselect = max_t(int, nb, ctlr->num_chipselect); >> >> such that what the controller has is the maximum between the number of >> 'cs-gpios' properties parsed and what was already populated in >> ctrl->num_chipselect during bcm2835_spi_probe(), which for this driver >> is BCM2835_SPI_NUM_CS (3). > > If you make a initial device tree (or add overlay in the rpi's > config.txt) with more on the bus than BCM2835_SPI_NUM_CS (in my case 8 > devices), you get into this trampling memory state. As the devices are > added, once the chip_select is equal to or greater than > BCM2835_SPI_NUM_CS, it's writing off the end of the arrays. OK. > > There is no protection from this happening. By the looks of it, this > isn't the only driver this could happen with, but it is the one I have > hardware for to test. There are also drivers that look like they don't > have a problem going well beyond the limit they gave. Right, which means that we should probably seek a solution within the SPI core itself, even if you can only test with spi-bcm2835.c chances are that the fix would be applicable for other controllers if done in the core. > > There is protection in spi_add_device, which will catch extra added > later, but not ones in the device tree when the spi controller was > registered. Not sure I follow you, if we have the overlay before spi_register_controller() is called, how can the check there not trigger? And if we load the overlay later when the SPI controller is already registered, why does not spi_add_device()'s check work? How would I go about reproducing this on a Pi4? > >>> This patches inforces CS limit but sets that limit to the max of the >>> default limit and what is in the device tree when driver is loaded. >>> >>> Signed-off-by: Joe Burmeister >> You have changed many more things that just enforcing a limit on >> BCM2835_SPI_NUM_CS you have now made all chip-select related data >> structuresd dynamically allocated and you have changed a number of >> prints to use the shorthand "dev" instead of &pdev->dev. > The change to dynamic allocated arrays is just to support what is given > in the device  tree rather than increase and enforce the CS limit just > for my case. > > The shorthand is of course not required. I'll drop it on resubmitting. > > Regards, > > Joe > > -- Florian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 780FEC433B4 for ; Thu, 22 Apr 2021 23:55:02 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C8D3161422 for ; Thu, 22 Apr 2021 23:55:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C8D3161422 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Cc:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hndtcM3/Rks8kY0AKq58C+h71eOCSpbmgZx8FaDa2tw=; b=mZOj21U5YtylS91QhuHosE5zr itHXiaHVbuxNJbl8l9ItPBNwyi8z1qKNf4sfYLkUm+yXyq9nlq1qkuAOvSeNrIj95uAgEC+kzFsy1 kupN4DHLC2aLcPxF7bIicBl82wEIT/qQMoaVz09gRE99zEFCxZh/rPhK9/dI9qBVCizsRETg+tcFP cVa5g/zih2bq30C2ieV/7hExJ0QfttXunpb/3WYRWMNG2pfGpPAn+M4r85YaOlXR8BRJ1ia6SZf/1 gfLDz23BFxnZ+6ne/pFqXTeWg53tXxW29Z2Rh7ZECVtdg0hDKWd3v4c/1kjjltq4x+IP4zQEYWjBm O5wf6RUgg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lZj4e-0008St-MC; Thu, 22 Apr 2021 23:49:32 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lZj4c-0008Sc-58; Thu, 22 Apr 2021 23:49:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:To: Subject:Sender:Reply-To:Cc:Content-ID:Content-Description; bh=IWfYoO0lSsj6QrdF4M9TVhiBQuuRKejv17Qbr6FkpHs=; b=nR0oc+FTDJCwWiHi3GVWyA5WGr BzjfEiM3BSRtXN/ZjEJ/yL96Hn+C70f6Bli/iUCcka4WfL9GjVSKbhsmN14fh3f/xG0mkkHT69pMu zt2R55dbzyZHVqhA/vPbRtSER9H+8GUS5c1zOb4Ax14O10wi6Dt4jAm/193MO3rdy1EN3Jn1Vbd5J tE8fMdwZs5TVQl1wEE9HuKY9RZWK9pFzj/hcdI1NszN00a38HTxt1xXxor7i62djns2yUFr3zhc/q rW8OSHHt/02kqCHnFkr89KeYKZXVXURQ1rIDfo/+qHxGGEy3YsfZGySvFxf1KKfQj8EOytQrG7q/a HwUFoo0g==; Received: from mail-pj1-x102e.google.com ([2607:f8b0:4864:20::102e]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lZj4X-00E2wt-6d; Thu, 22 Apr 2021 23:49:27 +0000 Received: by mail-pj1-x102e.google.com with SMTP id u14-20020a17090a1f0eb029014e38011b09so264503pja.5; Thu, 22 Apr 2021 16:49:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=IWfYoO0lSsj6QrdF4M9TVhiBQuuRKejv17Qbr6FkpHs=; b=POwfl7cE4Qcz1RenSpkCZiWAxw6lhRiLzZNY9Gg54NjNfXJSWLvpSa/LBmuIldfPHw nrr6RCnjKmzmZ3bWbdQmk8A/jbDyAEyaGPmcb421VfXnnY1L8pgTrNbnDBC/yuoDfgKz T3PNwP9pzPHw3dpSRe/tWnC7ubTOEenoqe0yDlJPATp5NlDzhXzUUTTUoEFW0d2M+X2B wOc1fh5jojyuGAhnrN8WrkDnKATakqCjzhwvLsKKUaYiQH7/lzozfDvO/xJ934r8VOPW 8Cf/PGPlNT8E4L8289BNJtNjJYwHp+RiNLLrSa2vXNz3lAY4Kxa0G40LmezScm5J2V/M gVQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=IWfYoO0lSsj6QrdF4M9TVhiBQuuRKejv17Qbr6FkpHs=; b=k9yD/E/dW/7BM70dzQgZWmbROk/ig7L9oZllk0UU/Z6Mph82VRYgYSsFLOqiSmlgu3 FtouCK87jxxFqBzGawPUWtOZUJOJjLBZpgbhn87wRG9ZJByA9ildV6Y5xdd/VjIyJjGs saNBBe/eO2/vGBjSidqvlNGz8iREEGiLmoaFMoy4CCs6v+zruBURANC2Lkg9G/ZD6b6E xu3FriDffO1Ux4thaOS/GZiH3ZTRBFkFWCynKiFUdo9QY52Z0FIaJn1pfOQQntmSBSJH bRN76W2NGEtW0wZ7Kc9SZv9A18lSm3elimId4PH1byJRaDHndX0naCrYvwLRhDYCW6FJ Y3xQ== X-Gm-Message-State: AOAM530FSvjyGeu+YUd467m2vyeVSBP8hhp+tUvO8RhjR6WvDuc5A3ol lZSxx4l1lTK3X62AtLJeEBY= X-Google-Smtp-Source: ABdhPJyQ8CB6gfavGomE80wlX8RKriAm4NmmFeGRBR1BIbjZmGV4qhobzGGXuBVwCwVbP22GOXafIQ== X-Received: by 2002:a17:90a:8410:: with SMTP id j16mr1301384pjn.120.1619135364274; Thu, 22 Apr 2021 16:49:24 -0700 (PDT) Received: from [10.230.29.202] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id m20sm5615378pjq.40.2021.04.22.16.49.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Apr 2021 16:49:23 -0700 (PDT) Subject: Re: [PATCH] spi: bcm2835: Fix buffer overflow with CS able to go beyond limit. To: Joe Burmeister , Mark Brown , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, linux-spi@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, nsaenz@kernel.org References: <20210420083402.6950-1-joe.burmeister@devtank.co.uk> <7c9f9376-1a80-b624-7b9e-0f6d04437c02@devtank.co.uk> From: Florian Fainelli Message-ID: <271ad212-a606-620e-3f0c-d6bff272be3c@gmail.com> Date: Thu, 22 Apr 2021 16:49:19 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <7c9f9376-1a80-b624-7b9e-0f6d04437c02@devtank.co.uk> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210422_164925_279584_ED7C7344 X-CRM114-Status: GOOD ( 30.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org CgpPbiA0LzIyLzIwMjEgMToxMCBQTSwgSm9lIEJ1cm1laXN0ZXIgd3JvdGU6Cj4+IE9uIDQvMjAv MjAyMSAxOjM0IEFNLCBKb2UgQnVybWVpc3RlciB3cm90ZToKPj4+IEl0IHdhcyBwcmV2aW91bHN5 IHBvc3NpYmxlIHRvIGhhdmUgYSBkZXZpY2UgdHJlZSB3aXRoIG1vcmUgY2hpcHMgdGhhbgo+Pj4g dGhlIGRyaXZlciBzdXBwb3J0cyBhbmQgZ28gb2ZmIHRoZSBlbmQgb2YgQ1MgYXJyYXlzLgo+PiBE byB5b3UgbWluZCB3YWxraW5nIG1lIHRocm91Z2ggdGhlIGNvZGUgaG93IHRoYXQgY291bGQgaGF2 ZSBoYXBwZW5lZD8gV2UKPj4gaGF2ZSBzcGlfcmVnaXN0ZXJfY29udHJvbGxlcigpIGNhbGwgb2Zf c3BpX2dldF9ncGlvX251bWJlcnMoKSB3aGljaCBoYXMKPj4gdGhlIGZvbGxvd2luZzoKPj4KPj4g Y3Rsci0+bnVtX2NoaXBzZWxlY3QgPSBtYXhfdChpbnQsIG5iLCBjdGxyLT5udW1fY2hpcHNlbGVj dCk7Cj4+Cj4+IHN1Y2ggdGhhdCB3aGF0IHRoZSBjb250cm9sbGVyIGhhcyBpcyB0aGUgbWF4aW11 bSBiZXR3ZWVuIHRoZSBudW1iZXIgb2YKPj4gJ2NzLWdwaW9zJyBwcm9wZXJ0aWVzIHBhcnNlZCBh bmQgd2hhdCB3YXMgYWxyZWFkeSBwb3B1bGF0ZWQgaW4KPj4gY3RybC0+bnVtX2NoaXBzZWxlY3Qg ZHVyaW5nIGJjbTI4MzVfc3BpX3Byb2JlKCksIHdoaWNoIGZvciB0aGlzIGRyaXZlcgo+PiBpcyBC Q00yODM1X1NQSV9OVU1fQ1MgKDMpLgo+IAo+IElmIHlvdSBtYWtlIGEgaW5pdGlhbCBkZXZpY2Ug dHJlZSAob3IgYWRkIG92ZXJsYXkgaW4gdGhlIHJwaSdzIAo+IGNvbmZpZy50eHQpIHdpdGggbW9y ZSBvbiB0aGUgYnVzIHRoYW4gQkNNMjgzNV9TUElfTlVNX0NTIChpbiBteSBjYXNlIDgKPiBkZXZp Y2VzKSwgeW91IGdldCBpbnRvIHRoaXMgdHJhbXBsaW5nIG1lbW9yeSBzdGF0ZS4gQXMgdGhlIGRl dmljZXMgYXJlCj4gYWRkZWQsIG9uY2UgdGhlIGNoaXBfc2VsZWN0IGlzIGVxdWFsIHRvIG9yIGdy ZWF0ZXIgdGhhbgo+IEJDTTI4MzVfU1BJX05VTV9DUywgaXQncyB3cml0aW5nIG9mZiB0aGUgZW5k IG9mIHRoZSBhcnJheXMuCgpPSy4KCj4gCj4gVGhlcmUgaXMgbm8gcHJvdGVjdGlvbiBmcm9tIHRo aXMgaGFwcGVuaW5nLiBCeSB0aGUgbG9va3Mgb2YgaXQsIHRoaXMKPiBpc24ndCB0aGUgb25seSBk cml2ZXIgdGhpcyBjb3VsZCBoYXBwZW4gd2l0aCwgYnV0IGl0IGlzIHRoZSBvbmUgSSBoYXZlCj4g aGFyZHdhcmUgZm9yIHRvIHRlc3QuIFRoZXJlIGFyZSBhbHNvIGRyaXZlcnMgdGhhdCBsb29rIGxp a2UgdGhleSBkb24ndAo+IGhhdmUgYSBwcm9ibGVtIGdvaW5nIHdlbGwgYmV5b25kIHRoZSBsaW1p dCB0aGV5IGdhdmUuCgpSaWdodCwgd2hpY2ggbWVhbnMgdGhhdCB3ZSBzaG91bGQgcHJvYmFibHkg c2VlayBhIHNvbHV0aW9uIHdpdGhpbiB0aGUKU1BJIGNvcmUgaXRzZWxmLCBldmVuIGlmIHlvdSBj YW4gb25seSB0ZXN0IHdpdGggc3BpLWJjbTI4MzUuYyBjaGFuY2VzCmFyZSB0aGF0IHRoZSBmaXgg d291bGQgYmUgYXBwbGljYWJsZSBmb3Igb3RoZXIgY29udHJvbGxlcnMgaWYgZG9uZSBpbgp0aGUg Y29yZS4KCj4gCj4gVGhlcmUgaXMgcHJvdGVjdGlvbiBpbiBzcGlfYWRkX2RldmljZSwgd2hpY2gg d2lsbCBjYXRjaCBleHRyYSBhZGRlZAo+IGxhdGVyLCBidXQgbm90IG9uZXMgaW4gdGhlIGRldmlj ZSB0cmVlIHdoZW4gdGhlIHNwaSBjb250cm9sbGVyIHdhcwo+IHJlZ2lzdGVyZWQuCgpOb3Qgc3Vy ZSBJIGZvbGxvdyB5b3UsIGlmIHdlIGhhdmUgdGhlIG92ZXJsYXkgYmVmb3JlCnNwaV9yZWdpc3Rl cl9jb250cm9sbGVyKCkgaXMgY2FsbGVkLCBob3cgY2FuIHRoZSBjaGVjayB0aGVyZSBub3QKdHJp Z2dlcj8gQW5kIGlmIHdlIGxvYWQgdGhlIG92ZXJsYXkgbGF0ZXIgd2hlbiB0aGUgU1BJIGNvbnRy b2xsZXIgaXMKYWxyZWFkeSByZWdpc3RlcmVkLCB3aHkgZG9lcyBub3Qgc3BpX2FkZF9kZXZpY2Uo KSdzIGNoZWNrIHdvcms/CgpIb3cgd291bGQgSSBnbyBhYm91dCByZXByb2R1Y2luZyB0aGlzIG9u IGEgUGk0PwoKPiAKPj4+IFRoaXMgcGF0Y2hlcyBpbmZvcmNlcyBDUyBsaW1pdCBidXQgc2V0cyB0 aGF0IGxpbWl0IHRvIHRoZSBtYXggb2YgdGhlCj4+PiBkZWZhdWx0IGxpbWl0IGFuZCB3aGF0IGlz IGluIHRoZSBkZXZpY2UgdHJlZSB3aGVuIGRyaXZlciBpcyBsb2FkZWQuCj4+Pgo+Pj4gU2lnbmVk LW9mZi1ieTogSm9lIEJ1cm1laXN0ZXIgPGpvZS5idXJtZWlzdGVyQGRldnRhbmsuY28udWs+Cj4+ IFlvdSBoYXZlIGNoYW5nZWQgbWFueSBtb3JlIHRoaW5ncyB0aGF0IGp1c3QgZW5mb3JjaW5nIGEg bGltaXQgb24KPj4gQkNNMjgzNV9TUElfTlVNX0NTIHlvdSBoYXZlIG5vdyBtYWRlIGFsbCBjaGlw LXNlbGVjdCByZWxhdGVkIGRhdGEKPj4gc3RydWN0dXJlc2QgZHluYW1pY2FsbHkgYWxsb2NhdGVk IGFuZCB5b3UgaGF2ZSBjaGFuZ2VkIGEgbnVtYmVyIG9mCj4+IHByaW50cyB0byB1c2UgdGhlIHNo b3J0aGFuZCAiZGV2IiBpbnN0ZWFkIG9mICZwZGV2LT5kZXYuCj4gVGhlIGNoYW5nZSB0byBkeW5h bWljIGFsbG9jYXRlZCBhcnJheXMgaXMganVzdCB0byBzdXBwb3J0IHdoYXQgaXMgZ2l2ZW4KPiBp biB0aGUgZGV2aWNlwqAgdHJlZSByYXRoZXIgdGhhbiBpbmNyZWFzZSBhbmQgZW5mb3JjZSB0aGUg Q1MgbGltaXQganVzdAo+IGZvciBteSBjYXNlLgo+IAo+IFRoZSBzaG9ydGhhbmQgaXMgb2YgY291 cnNlIG5vdCByZXF1aXJlZC4gSSdsbCBkcm9wIGl0IG9uIHJlc3VibWl0dGluZy4KPiAKPiBSZWdh cmRzLAo+IAo+IEpvZQo+IAo+IAoKLS0gCkZsb3JpYW4KCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0Cmxp bnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFk Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK