From mboxrd@z Thu Jan 1 00:00:00 1970 From: Milo Kim Subject: Re: [PATCH 4/5] firmware: add SmPL report for custom fallback mechanism Date: Wed, 14 Dec 2016 10:48:37 +0900 Message-ID: <271c9d23-d35e-252b-d03b-651457112d28@gmail.com> References: <20161213030828.17820-1-mcgrof@kernel.org> <20161213030828.17820-5-mcgrof@kernel.org> <10f8c7f7-a255-4830-65f0-a040d8236bf1@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-pf0-f195.google.com ([209.85.192.195]:35129 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753149AbcLNBu3 (ORCPT ); Tue, 13 Dec 2016 20:50:29 -0500 In-Reply-To: <10f8c7f7-a255-4830-65f0-a040d8236bf1@samsung.com> Sender: linux-leds-owner@vger.kernel.org List-Id: linux-leds@vger.kernel.org To: Jacek Anaszewski Cc: "Luis R. Rodriguez" , gregkh@linuxfoundation.org, ming.lei@canonical.com, daniel.wagner@bmw-carit.de, teg@jklm.no, mchehab@osg.samsung.com, zajec5@gmail.com, linux-kernel@vger.kernel.org, markivx@codeaurora.org, stephen.boyd@linaro.org, broonie@kernel.org, zohar@linux.vnet.ibm.com, tiwai@suse.de, johannes@sipsolutions.net, chunkeey@googlemail.com, hauke@hauke-m.de, jwboyer@fedoraproject.org, dmitry.torokhov@gmail.com, dwmw2@infradead.org, jslaby@suse.com, torvalds@linux-foundation.org, luto@amacapital.net, fengguang.wu@intel.com, rpurdie@rpsys.net, Abhay_Salunke@dell.com, Julia.Lawall@lip6.fr, Gilles.Muller@lip6.fr, nicolas.palix@imag.fr, dhowells@redhat.com, bjorn.andersson@linaro.org, arend.vanspriel@broadcom.com, kvalo@codeaurora.org, linux-leds@vger.k Hi Jacek, On 12/13/2016 06:44 PM, Jacek Anaszewski wrote: > > Could you please verify if leds-lp55xx-common.c driver > really needs a custom firmware loading fallback mechanism? Thanks for sharing this. The lp55xx-common uses this mechanism to load and run LED effect manually, so this could be a misuse case. I think the right solution is providing device attributes. At this moment, four drivers use lp55xx-common code. - lp5521, lp5523: OK if we do not support FW loading fallback mechanism - lp5562, lp8501: need to create additional sysfs alternatively. However, we should be careful because I'm not sure this modification will generate the regression (breaking the user-space) or not. Best regards, Milo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754661AbcLNBub (ORCPT ); Tue, 13 Dec 2016 20:50:31 -0500 Received: from mail-pf0-f195.google.com ([209.85.192.195]:35129 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753149AbcLNBu3 (ORCPT ); Tue, 13 Dec 2016 20:50:29 -0500 Subject: Re: [PATCH 4/5] firmware: add SmPL report for custom fallback mechanism To: Jacek Anaszewski References: <20161213030828.17820-1-mcgrof@kernel.org> <20161213030828.17820-5-mcgrof@kernel.org> <10f8c7f7-a255-4830-65f0-a040d8236bf1@samsung.com> Cc: "Luis R. Rodriguez" , gregkh@linuxfoundation.org, ming.lei@canonical.com, daniel.wagner@bmw-carit.de, teg@jklm.no, mchehab@osg.samsung.com, zajec5@gmail.com, linux-kernel@vger.kernel.org, markivx@codeaurora.org, stephen.boyd@linaro.org, broonie@kernel.org, zohar@linux.vnet.ibm.com, tiwai@suse.de, johannes@sipsolutions.net, chunkeey@googlemail.com, hauke@hauke-m.de, jwboyer@fedoraproject.org, dmitry.torokhov@gmail.com, dwmw2@infradead.org, jslaby@suse.com, torvalds@linux-foundation.org, luto@amacapital.net, fengguang.wu@intel.com, rpurdie@rpsys.net, Abhay_Salunke@dell.com, Julia.Lawall@lip6.fr, Gilles.Muller@lip6.fr, nicolas.palix@imag.fr, dhowells@redhat.com, bjorn.andersson@linaro.org, arend.vanspriel@broadcom.com, kvalo@codeaurora.org, linux-leds@vger.kernel.org From: Milo Kim Message-ID: <271c9d23-d35e-252b-d03b-651457112d28@gmail.com> Date: Wed, 14 Dec 2016 10:48:37 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <10f8c7f7-a255-4830-65f0-a040d8236bf1@samsung.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jacek, On 12/13/2016 06:44 PM, Jacek Anaszewski wrote: > > Could you please verify if leds-lp55xx-common.c driver > really needs a custom firmware loading fallback mechanism? Thanks for sharing this. The lp55xx-common uses this mechanism to load and run LED effect manually, so this could be a misuse case. I think the right solution is providing device attributes. At this moment, four drivers use lp55xx-common code. - lp5521, lp5523: OK if we do not support FW loading fallback mechanism - lp5562, lp8501: need to create additional sysfs alternatively. However, we should be careful because I'm not sure this modification will generate the regression (breaking the user-space) or not. Best regards, Milo