From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D44C4C433EF for ; Mon, 20 Jun 2022 09:33:27 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D3545803DF; Mon, 20 Jun 2022 11:33:25 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=weidmueller.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=weidmueller.onmicrosoft.com header.i=@weidmueller.onmicrosoft.com header.b="gEMHb2L+"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id BF2F780F7D; Mon, 20 Jun 2022 11:33:24 +0200 (CEST) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-am5eur03on0627.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe08::627]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 98F9F802F3 for ; Mon, 20 Jun 2022 11:33:22 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=weidmueller.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=stefan.herbrechtsmeier-oss@weidmueller.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B5fUlC86kqbWDR03ngQx142Jlrch5K234fl9cF+Zv4g8dmoU36Qv0vQOrLuLZkqhQWz5fpeUSQJwS0e78DTOqaJ15xxQzF3D5Fik5ITQUvnrfz+xCYGN7Ti4ks1Nltyi1js6yjJvHOoxPbGmDqbkF2lblryAmHXgGb7PGMvjD+tYjrjRU2pzueILoWajSkM4IUcRkASYxLEPfkt5cEssFKPBQwWXa13ObVb8EjOu8K2m3az4nsHU4VbufyjuhFey2xSyUSi7aForgo62XpHHTH7VM6tRNDtMIeVAdsMqfbR+GiTMZm+h031nhWfPq3Hy9ngg/jX4JoYpgVQVljUE5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WvP4H6XFwOsQXhfy/AR3Atye2wGcDjKt6sgum5Qb1jg=; b=cxnyIO7EL2eS+/6BpL9/meX7P65T3vW3RZEsG6nyFTzbn4fYbTt+QOOMTPvEVs0uhY4mrZfe8kvYk0lVgFAuWharRJyNq1DymmL44ub8HHswnhAHOZRDVvZJ2kGYmoyRovaNqBMuB8c9XRIKZP3nz2b/fLCwGHRNfCLsR6ASwRatbzla2jAPQ8hTfO7cF0fv34RgLlXf5Sg2uszdtudGGDTUkTZqRgSF30a1Y4Ihz/ryqM3xXNDvfB5aWwkI6+FHDgaj1BDofQLECQaDV08bPNjVYN+QsaYBaGzlrKbZpwiUWijkPXqLk7zutqCAZCWReSyOk+4qA9FIVUdOs+HXLA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=weidmueller.com; dmarc=pass action=none header.from=weidmueller.com; dkim=pass header.d=weidmueller.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=weidmueller.onmicrosoft.com; s=selector1-weidmueller-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WvP4H6XFwOsQXhfy/AR3Atye2wGcDjKt6sgum5Qb1jg=; b=gEMHb2L+mCsfkrdU7Drg2/nB71bcZbeX468zFHFZd5FfSGFpyF/6bsPxCjb8eU2wwMMyMwo9TI3GUMduaStjDceqrNhlgdWofnOQyTMKChZ3zFiFnYhLODFzXFpKAaafZTXxNolmGfYxWyAbRVFqcfYh+6PxEydVcX4TBWnBm3Y= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=weidmueller.com; Received: from PAXPR08MB6969.eurprd08.prod.outlook.com (2603:10a6:102:1d8::23) by AS8PR08MB6583.eurprd08.prod.outlook.com (2603:10a6:20b:33f::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.15; Mon, 20 Jun 2022 09:33:21 +0000 Received: from PAXPR08MB6969.eurprd08.prod.outlook.com ([fe80::49a6:e5ff:7f94:8787]) by PAXPR08MB6969.eurprd08.prod.outlook.com ([fe80::49a6:e5ff:7f94:8787%7]) with mapi id 15.20.5353.022; Mon, 20 Jun 2022 09:33:21 +0000 Message-ID: <271d770a-a69a-4438-d8a0-31c4b3784859@weidmueller.com> Date: Mon, 20 Jun 2022 11:33:20 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 02/10] firmware: firmware-zynqmp: Probe driver before use Content-Language: en-US To: Michal Simek , u-boot@lists.denx.de Cc: Stefan Herbrechtsmeier , Adrian Fiergolski , Ashok Reddy Soma , Jaehoon Chung , T Karthik Reddy References: <20220608162054.25641-1-stefan.herbrechtsmeier-oss@weidmueller.com> <20220608162054.25641-3-stefan.herbrechtsmeier-oss@weidmueller.com> <8140173f-3a64-7a34-94c0-d9965eec4821@amd.com> <7f28601d-5d2a-b65f-3b99-53a412e25664@weidmueller.com> From: Stefan Herbrechtsmeier In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0075.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::10) To PAXPR08MB6969.eurprd08.prod.outlook.com (2603:10a6:102:1d8::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 662867a9-b941-4fa5-765b-08da529fea8c X-MS-TrafficTypeDiagnostic: AS8PR08MB6583:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FmlzSf2K5F/1u9ctBe61ecbitNatDLgeVUMdH/9c1e5UX3vWz8zsk7ACvLLZAFrdNm7jZb1cXI2rCJsiQDEv/pO1EOmEanIyO6pCrOumerpyolTn3j63mwYQiecCquHkyNTGPVhyQHaXOBnTGfUiO5KUZlmMgpKH/Hg2nF5DaAO/8X0PkE0kNbTDxJX79f6IaQCXMG5oxrDdyOcrOLyhsNu0EAq8N4AUES8Wcqip2F3gxOQZD3BrJelUbm3N9x813iXUFaZGMDbq9dY03ndE8B3zplkQXFv2MzPQRCsUPp/3JcFMUmeMvQT8Sv/CgiY48VdJJYROGoOmeq/8gKdIeVC49iP1fDtnnhbnc+a/QAscRLblpBegJQFIGLlWOoqK3YdkokvDmMRFSP+WJbELNyjvHo6y8e5dwfVYQLZWslZfUrK8AcLzHy3Cg0Xkjpr2o93mYQV9kly7tAgfn4FLi3xkJHZXzPsoNJrz+1xQ882eayOiYXjfedbyTxe3GErSqsfQp09eTX4NJZV8UUCqtyvL9+4btDpfeuNOVIwlsjGP5DbRo6nFfJ0nCEAEgMcaYwoe/koobA49J4yTFsh4bfCUk4wiXwBh3ZuYJX/OuxNl/WMhe36AJWDqxF6W7/VUvMH8pqj4+dcXwdpwEsmltmDh4FioAgiz4zR2jcR9yFGx8vxA8NKKHU36DZAwROPn4xRq5QyU6qXp2BC/fSufjV+rCJJz6uzIo+3WU0ZxYQWKgVNXRDlYUzR3tqV9lf+a4smf79l3QCkoKREqWmJCXA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PAXPR08MB6969.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(366004)(6512007)(498600001)(53546011)(54906003)(316002)(36756003)(26005)(8936002)(8676002)(6486002)(6506007)(31686004)(52116002)(86362001)(66556008)(83380400001)(4326008)(66946007)(66476007)(186003)(38350700002)(5660300002)(2616005)(2906002)(31696002)(38100700002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?azZ3VjUxa1N5SXo0S2t3eTlqOHpjbU53ZElFWXVmVjBkSThDa0NBd3UxU25t?= =?utf-8?B?RHVOVkYwSUxOVmdhaVlXZ2RNV3FZTXlhNXNXdkNqeWVtUThmazVDK0VOQWVy?= =?utf-8?B?SzVlVmEvUG5FK0ZGN3paa0lCbXF3NkNwZWZuVGk1SHVJUDlNQldXdE5BSm1H?= =?utf-8?B?aGpqVzhMSlJCOFU5c0xnZUtERTBrRG96bWJXSGpwY1ZMZGRUMVg1TWxzWU1w?= =?utf-8?B?R2NVd09rRll6QkR1ekxUTGgvMGRaZGNFODg4WGNLY2liaXpkd1JzY2M4QVd1?= =?utf-8?B?Y3JhTGxwcjJLb0g5MXh6b3lha2JPclBDdXdCRXdBUHZqTis3Nlp2MmpxOEQx?= =?utf-8?B?ckdoQmRxNlQrTy9mMnZjRm9EaFRVdVlsSllCRTJRL2o1YldnRE55dTBHZ3pD?= =?utf-8?B?M3BQNmhJUTVrRkc0ZDhzd0JXUzljUzgwRjZHZlUwaTJLV0xwY2dmdSswUkdY?= =?utf-8?B?ZlRJQWNFdU02WWVMdWtYUE9ERll1Y2kxaWZkcmtjc2plWmpFM1g4TkpTUHZ4?= =?utf-8?B?ZCtNLzIvL1IyQS9YREh1cEFIZy9INS9td3ZDODlJSkNMaDlVZDBvRy9BTEFj?= =?utf-8?B?Vjhwd1VLWmczaTl1bzExSG1lWGRZdUF3UDd0V1RKQ3lFWjdwU0w1cXB2K3hL?= =?utf-8?B?Wll3cm5tTGNsOVg1UmFJNnJpbnRDdEI1ZXJ6aS9yZVBCd21IcXZNZHZmMDlS?= =?utf-8?B?THV5VlkvenBYNUNZaDgrNW81MmFDMklEaFFPbzlmdEV4bmJTRUdDVzJZbC9U?= =?utf-8?B?Z3d2cGkreXBTa3o2bUtBUlVML2hzbFlReU10a05Gb3p4SDVUaWVjUW03Z1cz?= =?utf-8?B?dW1sTlBlREk1T29WS2ZXZWd2SzFFT2s4YTRZenZwSG9sQVZ3b0pxVkZUV1Zj?= =?utf-8?B?M2l2bk9PeGgxQmFtYVVkbElmL2RralhLRWVXV2duY3NvSjlRUSttSXNDMU91?= =?utf-8?B?SmdaL0dSNk5Sb2xFcm5oT1YrOVdvVFUwTkxzaFpBYXFmZEp0WGlBRGw4dm1z?= =?utf-8?B?SkRIYUtwVCtreGJzMUVBN3hxNTBXZmxLMU5wT3haYjNXOHpUMlg4U3Mrb3M0?= =?utf-8?B?K2FyT09zRm9HTHJNdVhHZUhSWlk0aTN3Vk42ZU01ZzRtV09TZWs3Z2dPeENs?= =?utf-8?B?NGI1VnlseUIzQy9ia3dwdVZuM1NySnU2VkExc056T3BKWGd5bWFvajQybHNL?= =?utf-8?B?WlowakhyWFRtaTc3bjkvQUZ4SFp4Vzh5RnpsTkRSN0pHU2ZsLzdBSGR4YnBR?= =?utf-8?B?VVkyajlPZFJ5YTRTam1ySXJYRjZqT0lUbi9nQXJzK2YySW9QOFgxRjZDRGQv?= =?utf-8?B?ZTc5ZUx0K0QvdTltQWFJZEZ5azlFUnRhSWFMR1BYRkdsaGtIMTl0YVBxVTNp?= =?utf-8?B?NGlNMEkvQ2NHcnpVeGVpRGRWZ3dRZ1FJeG4yOW9jbFdxNVZaU0RwYkNzRGxX?= =?utf-8?B?RUl6UC92alNXdnozYm8wWXpqU3dsaUc4RDQ1ZDJEeGxKZENVUkRQemxLNTdH?= =?utf-8?B?ZVIrMTNLbGFMbFFwR0VaMGU0OHRIVGlDWkN4bS9zcVZMMkhlT0pwMGRlVmo0?= =?utf-8?B?VXBrWXp4Y0JiWkVJeXVWOVQvSzl4UndBS2pkUUh4Y0ZUQXdNN2VFMURLWmtN?= =?utf-8?B?K0hmS0Y1N2ZKWTZaaTgxSDlVcWx2dkRDc0VEdGo3dHNjcDd6VW1BVFhoNmZB?= =?utf-8?B?ak8yR2gvQVFPNzBQS09NMjd0Y2NMRFFlRXBWY0lVOTY0YWo1TXhjQ09aSDB1?= =?utf-8?B?N2prYXI1cFR6MEQvNnBQZGM4RTZoeTZvUVdlSG4rQ2JLL2ZwZ29NNGtFRmdM?= =?utf-8?B?TTBGU1VSYytaWWxnbkI4RFF5Mi9ONUtGdVNVcFplek1ZQUlLdFpTWGZCaVNK?= =?utf-8?B?SFRMVFNPeWlDaWlXS3BobjF0RDc0bDdEdERNR2VkYUJORExFZEExT20yMnZV?= =?utf-8?B?VXNpcC84UlFmVUZWOXF3RDRLRVVwcjhhZjJwRlQrbmw1WXljVUlnOGNxbDI4?= =?utf-8?B?WU1oUS9POGthSnZIcndiZ3FXbU1HdXJzNmRTdU1pUDFJMktMOWJKZGNVd1BR?= =?utf-8?B?U1VFaXR3clY0NGpiTVVWcW50d0R6cU9GNUk3WWd4aFloeE9LTXFzcTBtSFE2?= =?utf-8?B?RGtldWhlTWtoaGd1amRoQWhXQ2RBT0VxVms2N0orYnRFOE4vYUp5dGNHbkpI?= =?utf-8?B?VW9MWmFtUUdkdlhEQ1BxZ0h1Wm9TR0FvMGdxM2c2aDltYlRET2QrZCtNMWsy?= =?utf-8?B?R3V6UUVNamlhWWVaN2ZiUVN0Um1XUk9iQmlVaWhRc3c5L0ViV1kvcENRc1A0?= =?utf-8?B?amRKTnNXKy9tUFNMVkRpelF1Ly9XOTVBOUZaaUxGZzFvcGYzdTQ4czdDUHhm?= =?utf-8?Q?vPJIWG/93YIcPFfs=3D?= X-OriginatorOrg: weidmueller.com X-MS-Exchange-CrossTenant-Network-Message-Id: 662867a9-b941-4fa5-765b-08da529fea8c X-MS-Exchange-CrossTenant-AuthSource: PAXPR08MB6969.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jun 2022 09:33:21.5635 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: e4289438-1c5f-4c95-a51a-ee553b8b18ec X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5nDx8FXgOuW1WvMvq1ZGLAupPocyvv655TMMfTmA/NCcIx+SfSYCBelEyrOCBpF0rmuEtF8Ih1qQ33N7fvGjdw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6583 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Am 20.06.2022 um 08:51 schrieb Michal Simek: > Hi, > > On 6/20/22 08:40, Stefan Herbrechtsmeier wrote: >> Am 16.06.2022 um 16:22 schrieb Michal Simek: >>> On 6/8/22 18:20, Stefan Herbrechtsmeier wrote: >>>> [CAUTION: External Email] >>>> >>>> From: Stefan Herbrechtsmeier >>>> >>>> Probe the driver before use to ensure that the global data are valid. >>> >>> It is not clear what the issue is. And this function is called in SPL >>> or EL3 and likely multiple times. >>> Can you please clarify? >> >> The driver only works if it is used after u-boot,dm-pre-reloc. This >> change is needed to support a usage by other drivers like >> xlnx,zynqmp-firmware. > > Can you please describe the case, execution path where it is used before? I released the problem with the soc_xilinx_zynqmp driver. The driver was probed before the firmware-zynqmp driver. At the moment every user of xilinx_pm_request function have to ensure that the firmware-zynqmp driver was probed. > > Also that calling multiple times is just adding overhead for boot up > time. We should try to avoid it as much as possible. Should I zero zynqmp_power and only probe if it is zero? The solution is based on the psci driver. Regards Stefan