From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: "Leonardo Mörlein" <me@irrelefant.net>,
"Antonio Quartulli" <a@unstable.cc>
Subject: Re: [B.A.T.M.A.N.] [RFC PATCH] batman-adv: mitigate issue when empty vlan is received
Date: Mon, 07 May 2018 08:32:28 +0200 [thread overview]
Message-ID: <2722022.Z6qn7ThOV8@bentobox> (raw)
In-Reply-To: <20180506195559.32602-1-me@irrelefant.net>
[-- Attachment #1: Type: text/plain, Size: 1268 bytes --]
On Sonntag, 6. Mai 2018 21:55:59 CEST Leonardo Mörlein wrote:
> This patch is not a fix for the issue itself, but a fix for the
> other nodes, which are also influenced by the issue.
>
> - Some (affected) nodes send TT announcements for an empty vlan (for
> now only seen with vlan_id = 0).
> - This behaviour is a bug! Batman-adv nodes must not send TT
> announcements for empty vlans.
> - The receiving batman-adv can not handle incoming TT announcements
> with empty vlans. (The crc check routine batadv_tt_global_check_crc()
> fails.)
> - As the receiving node thinks, the crc is broken, it does a full
> table request then.
> - The announcing node sends a TT full table to the receiving node
> then, which also contains the empty vlan, so
> *batadv_tt_global_check_crc()* fails again on the receiver side.
> - This causes a lot of unneeded TT traffic. In Freifunk Hannover we
> decreased the amount of from ~20kpp/s to ~4kpp/s on our supernodes.
> We have ~800 nodes, which are connected via vpn to one of six
> supernodes. Those supernodes are connected with each other in a fully
> connected mesh.
Can you attach a (small) pcap of actual traffic which show a packet which
triggers this behavior?
Thanks,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-05-07 6:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-06 19:55 [B.A.T.M.A.N.] [RFC PATCH] batman-adv: mitigate issue when empty vlan is received Leonardo Mörlein
2018-05-07 6:32 ` Sven Eckelmann [this message]
2018-05-07 8:06 ` me
2018-05-07 10:23 ` Sven Eckelmann
2018-05-08 8:45 ` Sven Eckelmann
2018-05-09 14:08 ` Marek Lindner
2018-05-09 16:06 ` [B.A.T.M.A.N.] [RFC] batman-adv: prevent TT request storms by not sending inconsistent TT TLVLs Marek Lindner
2018-05-09 17:21 ` Sven Eckelmann
2018-05-09 18:20 ` Sven Eckelmann
2018-05-09 20:38 ` Sven Eckelmann
2018-05-09 21:34 ` lemoer
2018-05-10 9:12 ` Antonio Quartulli
2018-05-10 10:28 ` Marek Lindner
2018-05-10 14:41 ` [B.A.T.M.A.N.] [RFC v2] " Marek Lindner
2018-05-10 15:50 ` Sven Eckelmann
2018-05-11 15:58 ` Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2722022.Z6qn7ThOV8@bentobox \
--to=sven@narfation.org \
--cc=a@unstable.cc \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=me@irrelefant.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.