From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 880B2C4338F for ; Mon, 16 Aug 2021 12:17:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6C7F361BFD for ; Mon, 16 Aug 2021 12:17:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233204AbhHPMSZ (ORCPT ); Mon, 16 Aug 2021 08:18:25 -0400 Received: from mga01.intel.com ([192.55.52.88]:55811 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229836AbhHPMSZ (ORCPT ); Mon, 16 Aug 2021 08:18:25 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10077"; a="237911496" X-IronPort-AV: E=Sophos;i="5.84,324,1620716400"; d="scan'208";a="237911496" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Aug 2021 05:17:54 -0700 X-IronPort-AV: E=Sophos;i="5.84,324,1620716400"; d="scan'208";a="679076926" Received: from swatish2-mobl1.gar.corp.intel.com (HELO [10.215.193.217]) ([10.215.193.217]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Aug 2021 05:17:51 -0700 Subject: Re: [PATCH] drm/i915/display: Drop redundant debug print To: Jani Nikula , intel-gfx@lists.freedesktop.org Cc: Ankit Nautiyal , Uma Shankar , Ville Syrj_l_ , Imre Deak , Manasi Navare , Jos_ Roberto de Souza , Sean Paul , stable@vger.kernel.org References: <20210812125845.27787-1-swati2.sharma@intel.com> <871r6xn5wd.fsf@intel.com> <04e2728f-a5e3-a8ee-9fdc-9affe753b59e@intel.com> <87wnolio9x.fsf@intel.com> From: "Sharma, Swati2" Organization: Intel Message-ID: <27387edf-5b67-e361-325e-0a9600a28da2@intel.com> Date: Mon, 16 Aug 2021 17:47:48 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <87wnolio9x.fsf@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On 16-Aug-21 5:40 PM, Jani Nikula wrote: > On Mon, 16 Aug 2021, "Sharma, Swati2" wrote: >> On 13-Aug-21 1:16 PM, Jani Nikula wrote: >>> On Thu, 12 Aug 2021, Swati Sharma wrote: >>>> drm_dp_dpcd_read/write already has debug error message. >>>> Drop redundant error messages which gives false >>>> status even if correct value is read in drm_dp_dpcd_read(). >>> >>> I guess the only problem is it gets harder to associate the preceding >>> low level error messages with intel_dp_check_link_service_irq(). *shrug* >>> >>> Reviewed-by: Jani Nikula >>> >>> >> Thanks Jani for the review. Can you please merge? > > There was another version with open review? Yes. https://patchwork.freedesktop.org/series/93025/#rev3 Should I add debug prints how Imre suggested in other IRQ func to make it generic or should it be dropped from here too? Quoting imre "Yes, that's why I suggested to return for the '0 value read' case without any message printed, but still keep the message for the case when the drm_dp_dpcd_readb() fails." "Ok, it's good to keep them in sync at least, so I'm ok with removing the debug messages from here too." Please let me know what is the better approach. > > BR, > Jani. > > >> >>>> >>>> Fixes: 9488a030ac91 ("drm/i915: Add support for enabling link status and recovery") >>>> Cc: Swati Sharma >>>> Cc: Ankit Nautiyal >>>> Cc: Uma Shankar (v2) >>>> Cc: Jani Nikula >>>> Cc: "Ville Syrj_l_" >>>> Cc: Imre Deak >>>> Cc: Manasi Navare >>>> Cc: Uma Shankar >>>> Cc: "Jos_ Roberto de Souza" >>>> Cc: Sean Paul >>>> Cc: # v5.12+ >>>> >>>> Link: https://patchwork.freedesktop.org/patch/msgid/20201218103723.30844-12-ankit.k.nautiyal@intel.com >>>> Signed-off-by: Swati Sharma >>>> --- >>>> drivers/gpu/drm/i915/display/intel_dp.c | 8 ++------ >>>> 1 file changed, 2 insertions(+), 6 deletions(-) >>>> >>>> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c >>>> index c386ef8eb200..5c84f51ad41d 100644 >>>> --- a/drivers/gpu/drm/i915/display/intel_dp.c >>>> +++ b/drivers/gpu/drm/i915/display/intel_dp.c >>>> @@ -3871,16 +3871,12 @@ static void intel_dp_check_link_service_irq(struct intel_dp *intel_dp) >>>> return; >>>> >>>> if (drm_dp_dpcd_readb(&intel_dp->aux, >>>> - DP_LINK_SERVICE_IRQ_VECTOR_ESI0, &val) != 1 || !val) { >>>> - drm_dbg_kms(&i915->drm, "Error in reading link service irq vector\n"); >>>> + DP_LINK_SERVICE_IRQ_VECTOR_ESI0, &val) != 1 || !val) >>>> return; >>>> - } >>>> >>>> if (drm_dp_dpcd_writeb(&intel_dp->aux, >>>> - DP_LINK_SERVICE_IRQ_VECTOR_ESI0, val) != 1) { >>>> - drm_dbg_kms(&i915->drm, "Error in writing link service irq vector\n"); >>>> + DP_LINK_SERVICE_IRQ_VECTOR_ESI0, val) != 1) >>>> return; >>>> - } >>>> >>>> if (val & HDMI_LINK_STATUS_CHANGED) >>>> intel_dp_handle_hdmi_link_status_change(intel_dp); >>> > -- ~Swati Sharma From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 516AFC4320A for ; Mon, 16 Aug 2021 12:17:58 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1AC1D6324B for ; Mon, 16 Aug 2021 12:17:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1AC1D6324B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5717089E15; Mon, 16 Aug 2021 12:17:57 +0000 (UTC) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id C93CE89E15 for ; Mon, 16 Aug 2021 12:17:54 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10077"; a="237911497" X-IronPort-AV: E=Sophos;i="5.84,324,1620716400"; d="scan'208";a="237911497" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Aug 2021 05:17:54 -0700 X-IronPort-AV: E=Sophos;i="5.84,324,1620716400"; d="scan'208";a="679076926" Received: from swatish2-mobl1.gar.corp.intel.com (HELO [10.215.193.217]) ([10.215.193.217]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Aug 2021 05:17:51 -0700 To: Jani Nikula , intel-gfx@lists.freedesktop.org Cc: Ankit Nautiyal , Uma Shankar , Ville Syrj_l_ , Imre Deak , Manasi Navare , Jos_ Roberto de Souza , Sean Paul , stable@vger.kernel.org References: <20210812125845.27787-1-swati2.sharma@intel.com> <871r6xn5wd.fsf@intel.com> <04e2728f-a5e3-a8ee-9fdc-9affe753b59e@intel.com> <87wnolio9x.fsf@intel.com> From: "Sharma, Swati2" Organization: Intel Message-ID: <27387edf-5b67-e361-325e-0a9600a28da2@intel.com> Date: Mon, 16 Aug 2021 17:47:48 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <87wnolio9x.fsf@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Intel-gfx] [PATCH] drm/i915/display: Drop redundant debug print X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 16-Aug-21 5:40 PM, Jani Nikula wrote: > On Mon, 16 Aug 2021, "Sharma, Swati2" wrote: >> On 13-Aug-21 1:16 PM, Jani Nikula wrote: >>> On Thu, 12 Aug 2021, Swati Sharma wrote: >>>> drm_dp_dpcd_read/write already has debug error message. >>>> Drop redundant error messages which gives false >>>> status even if correct value is read in drm_dp_dpcd_read(). >>> >>> I guess the only problem is it gets harder to associate the preceding >>> low level error messages with intel_dp_check_link_service_irq(). *shrug* >>> >>> Reviewed-by: Jani Nikula >>> >>> >> Thanks Jani for the review. Can you please merge? > > There was another version with open review? Yes. https://patchwork.freedesktop.org/series/93025/#rev3 Should I add debug prints how Imre suggested in other IRQ func to make it generic or should it be dropped from here too? Quoting imre "Yes, that's why I suggested to return for the '0 value read' case without any message printed, but still keep the message for the case when the drm_dp_dpcd_readb() fails." "Ok, it's good to keep them in sync at least, so I'm ok with removing the debug messages from here too." Please let me know what is the better approach. > > BR, > Jani. > > >> >>>> >>>> Fixes: 9488a030ac91 ("drm/i915: Add support for enabling link status and recovery") >>>> Cc: Swati Sharma >>>> Cc: Ankit Nautiyal >>>> Cc: Uma Shankar (v2) >>>> Cc: Jani Nikula >>>> Cc: "Ville Syrj_l_" >>>> Cc: Imre Deak >>>> Cc: Manasi Navare >>>> Cc: Uma Shankar >>>> Cc: "Jos_ Roberto de Souza" >>>> Cc: Sean Paul >>>> Cc: # v5.12+ >>>> >>>> Link: https://patchwork.freedesktop.org/patch/msgid/20201218103723.30844-12-ankit.k.nautiyal@intel.com >>>> Signed-off-by: Swati Sharma >>>> --- >>>> drivers/gpu/drm/i915/display/intel_dp.c | 8 ++------ >>>> 1 file changed, 2 insertions(+), 6 deletions(-) >>>> >>>> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c >>>> index c386ef8eb200..5c84f51ad41d 100644 >>>> --- a/drivers/gpu/drm/i915/display/intel_dp.c >>>> +++ b/drivers/gpu/drm/i915/display/intel_dp.c >>>> @@ -3871,16 +3871,12 @@ static void intel_dp_check_link_service_irq(struct intel_dp *intel_dp) >>>> return; >>>> >>>> if (drm_dp_dpcd_readb(&intel_dp->aux, >>>> - DP_LINK_SERVICE_IRQ_VECTOR_ESI0, &val) != 1 || !val) { >>>> - drm_dbg_kms(&i915->drm, "Error in reading link service irq vector\n"); >>>> + DP_LINK_SERVICE_IRQ_VECTOR_ESI0, &val) != 1 || !val) >>>> return; >>>> - } >>>> >>>> if (drm_dp_dpcd_writeb(&intel_dp->aux, >>>> - DP_LINK_SERVICE_IRQ_VECTOR_ESI0, val) != 1) { >>>> - drm_dbg_kms(&i915->drm, "Error in writing link service irq vector\n"); >>>> + DP_LINK_SERVICE_IRQ_VECTOR_ESI0, val) != 1) >>>> return; >>>> - } >>>> >>>> if (val & HDMI_LINK_STATUS_CHANGED) >>>> intel_dp_handle_hdmi_link_status_change(intel_dp); >>> > -- ~Swati Sharma