From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Howells Date: Tue, 19 Sep 2017 15:38:25 +0000 Subject: Re: [PATCH v6] security/keys: rewrite all of big_key crypto Message-Id: <27444.1505835505@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit List-Id: References: <20170917115217.15805-1-Jason@zx2c4.com> In-Reply-To: <20170917115217.15805-1-Jason@zx2c4.com> To: "Jason A. Donenfeld" Cc: dhowells@redhat.com, linux-security-module@vger.kernel.org, keyrings@vger.kernel.org, kernel-hardening@lists.openwall.com, linux-kernel@vger.kernel.org, ebiggers3@gmail.com, Herbert Xu , Kirill Marinushkin , security@kernel.org, stable@vger.kernel.org Jason A. Donenfeld wrote: > And, some error paths forgot to zero out sensitive > material, so this patch changes a kfree into a kzfree. Can you split that out into a separate preparatory patch? Also, I recommend limiting the lines in your patch description to 75 chars lest you get people who run checkpatch on everything pestering you ;-) David From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751828AbdISPib (ORCPT ); Tue, 19 Sep 2017 11:38:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51304 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751377AbdISPi3 (ORCPT ); Tue, 19 Sep 2017 11:38:29 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com EC34A7EA93 Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=dhowells@redhat.com Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20170917115217.15805-1-Jason@zx2c4.com> References: <20170917115217.15805-1-Jason@zx2c4.com> To: "Jason A. Donenfeld" Cc: dhowells@redhat.com, linux-security-module@vger.kernel.org, keyrings@vger.kernel.org, kernel-hardening@lists.openwall.com, linux-kernel@vger.kernel.org, ebiggers3@gmail.com, Herbert Xu , Kirill Marinushkin , security@kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v6] security/keys: rewrite all of big_key crypto MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <27443.1505835505.1@warthog.procyon.org.uk> Date: Tue, 19 Sep 2017 16:38:25 +0100 Message-ID: <27444.1505835505@warthog.procyon.org.uk> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Tue, 19 Sep 2017 15:38:29 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jason A. Donenfeld wrote: > And, some error paths forgot to zero out sensitive > material, so this patch changes a kfree into a kzfree. Can you split that out into a separate preparatory patch? Also, I recommend limiting the lines in your patch description to 75 chars lest you get people who run checkpatch on everything pestering you ;-) David From mboxrd@z Thu Jan 1 00:00:00 1970 From: dhowells@redhat.com (David Howells) Date: Tue, 19 Sep 2017 16:38:25 +0100 Subject: [PATCH v6] security/keys: rewrite all of big_key crypto In-Reply-To: <20170917115217.15805-1-Jason@zx2c4.com> References: <20170917115217.15805-1-Jason@zx2c4.com> Message-ID: <27444.1505835505@warthog.procyon.org.uk> To: linux-security-module@vger.kernel.org List-Id: linux-security-module.vger.kernel.org Jason A. Donenfeld wrote: > And, some error paths forgot to zero out sensitive > material, so this patch changes a kfree into a kzfree. Can you split that out into a separate preparatory patch? Also, I recommend limiting the lines in your patch description to 75 chars lest you get people who run checkpatch on everything pestering you ;-) David -- To unsubscribe from this list: send the line "unsubscribe linux-security-module" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Howells In-Reply-To: <20170917115217.15805-1-Jason@zx2c4.com> References: <20170917115217.15805-1-Jason@zx2c4.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <27443.1505835505.1@warthog.procyon.org.uk> Date: Tue, 19 Sep 2017 16:38:25 +0100 Message-ID: <27444.1505835505@warthog.procyon.org.uk> Subject: [kernel-hardening] Re: [PATCH v6] security/keys: rewrite all of big_key crypto To: "Jason A. Donenfeld" Cc: dhowells@redhat.com, linux-security-module@vger.kernel.org, keyrings@vger.kernel.org, kernel-hardening@lists.openwall.com, linux-kernel@vger.kernel.org, ebiggers3@gmail.com, Herbert Xu , Kirill Marinushkin , security@kernel.org, stable@vger.kernel.org List-ID: Jason A. Donenfeld wrote: > And, some error paths forgot to zero out sensitive > material, so this patch changes a kfree into a kzfree. Can you split that out into a separate preparatory patch? Also, I recommend limiting the lines in your patch description to 75 chars lest you get people who run checkpatch on everything pestering you ;-) David