From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v15 4/7] bus/pci: implement sigbus handler ops
Date: Mon, 15 Oct 2018 16:16:31 +0200
Message-ID: <2747892.zUyjEnoVBZ@xps>
References: <1498711073-42917-1-git-send-email-jia.guo@intel.com>
 <1539602847-19220-5-git-send-email-jia.guo@intel.com>
 <4075531.4ZLKP4gcBB@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, stephen@networkplumber.org, bruce.richardson@intel.com,
 ferruh.yigit@intel.com, konstantin.ananyev@intel.com, gaetan.rivet@6wind.com,
 jingjing.wu@intel.com, motih@mellanox.com, matan@mellanox.com,
 harry.van.haaren@intel.com, qi.z.zhang@intel.com, shaopeng.he@intel.com,
 bernard.iremonger@intel.com, arybchenko@solarflare.com, wenzhuo.lu@intel.com,
 anatoly.burakov@intel.com, jerin.jacob@caviumnetworks.com,
 jblunck@infradead.org, shreyansh.jain@nxp.com, helin.zhang@intel.com
To: Jeff Guo <jia.guo@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id D07FF23D
 for <dev@dpdk.org>; Mon, 15 Oct 2018 16:16:35 +0200 (CEST)
In-Reply-To: <4075531.4ZLKP4gcBB@xps>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

15/10/2018 15:41, Thomas Monjalon:
> 15/10/2018 13:27, Jeff Guo:
> > This patch implements the ops for the PCI bus sigbus handler. It finds the
> > PCI device that is being hot-unplugged and calls the relevant ops of the
> > hot-unplug handler to handle the hot-unplug failure of the device.
> > 
> > Signed-off-by: Jeff Guo <jia.guo@intel.com>
> > Acked-by: Shaopeng He <shaopeng.he@intel.com>
> > Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> > ---
> > v15->v14:
> > fix compling issue.
> > ---
> > +static struct rte_pci_device *
> > +pci_find_device_by_addr(const void *failure_addr)
> > +{
> > +	struct rte_pci_device *pdev = NULL;
> > +	uint64_t check_point, start, end, len;
> > +	int i;
> > +
> > +	check_point = (uint64_t)(uintptr_t)failure_addr;
> > +
> > +	FOREACH_DEVICE_ON_PCIBUS(pdev) {
> > +		for (i = 0; i != RTE_DIM(pdev->mem_resource); i++) {
> > +			start = (uint64_t)(uintptr_t)pdev->mem_resource[i].addr;
> > +			len = pdev->mem_resource[i].len;
> > +			end = (uint64_t)(uintptr_t)RTE_PTR_ADD(start, len);
> 
> When compiling for 32-bit, there is an error:
> cast to pointer from integer of different size
> 
> start is not a pointer.
> I think it must be replaced by a simple addition.
> 	end = start + len;

I will fix it on apply.