From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>,
Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH 3/4] tools/libxc: Avoid generating inappropriate zero-length records
Date: Mon, 25 Jul 2016 10:57:13 +0100 [thread overview]
Message-ID: <2748eba0-fd1b-a554-02a9-262b401ec561@citrix.com> (raw)
In-Reply-To: <20160725094553.GE1008@citrix.com>
On 25/07/16 10:45, Wei Liu wrote:
> On Thu, Jul 21, 2016 at 06:17:36PM +0100, Andrew Cooper wrote:
>> It was never intended for records such as these to be sent with zero content.
>>
> Wouldn't it be better to modify write_split_record to ignore zero
> content instead of patching up different places?
That would catch the HVM_PARAMS, but not the other 3, which have an
extra 8 byte header.
However, having write_split_record() conditionally drop records is a
violation of the principle of least surprise. Choosing to skip a record
is an important decision and needs to be easy to spot in the code.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-07-25 9:57 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-21 17:17 [PATCH RFC 0/4] Fix issues with zero-length records in migration v2 Andrew Cooper
2016-07-21 17:17 ` [PATCH 1/4] docs: Clarify the expected behaviour of zero length records Andrew Cooper
2016-07-25 9:45 ` Wei Liu
2016-07-25 10:21 ` David Vrabel
2016-07-25 10:25 ` Andrew Cooper
2016-07-25 10:35 ` David Vrabel
2016-07-25 10:38 ` Andrew Cooper
2016-07-25 10:44 ` David Vrabel
2016-07-25 10:45 ` Andrew Cooper
2016-07-25 11:18 ` Ian Jackson
2016-07-21 17:17 ` [PATCH 2/4] tools/libxc: Tolerate zero-length records in migration v2 streams Andrew Cooper
2016-07-25 9:46 ` Wei Liu
2016-07-25 12:21 ` David Vrabel
2016-07-25 12:46 ` Andrew Cooper
2016-07-25 13:00 ` David Vrabel
2016-07-21 17:17 ` [PATCH 3/4] tools/libxc: Avoid generating inappropriate zero-length records Andrew Cooper
2016-07-25 9:45 ` Wei Liu
2016-07-25 9:57 ` Andrew Cooper [this message]
2016-07-25 10:14 ` Wei Liu
2016-07-25 10:32 ` David Vrabel
2016-07-25 11:44 ` Ian Jackson
2016-07-25 17:15 ` Ian Jackson
2016-07-26 9:23 ` Wei Liu
2016-07-26 13:37 ` Ian Jackson
2016-07-21 17:17 ` [PATCH 4/4] tools/python: Adjust migration v2 library to warn about " Andrew Cooper
2016-07-25 9:46 ` Wei Liu
2017-03-14 13:20 ` [PATCH RFC 0/4] Fix issues with zero-length records in migration v2 Julien Grall
2017-03-14 13:50 ` Andrew Cooper
2017-03-14 14:21 ` Wei Liu
2017-03-28 18:24 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2748eba0-fd1b-a554-02a9-262b401ec561@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.