From: Arcadiy Ivanov <arcadiy@ivanov.biz>
To: "Pali Rohár" <pali.rohar@gmail.com>
Cc: Matthew Garrett <mjg59@srcf.ucam.org>,
platform-driver-x86@vger.kernel.org,
Mario Limonciello <mario.limonciello@dell.com>
Subject: Re: [PATCH] Keyboard backlight on Dell E7470 not adjustable from /sys entry
Date: Sun, 23 Apr 2017 16:54:33 -0400 [thread overview]
Message-ID: <274da9d5-187a-6bb5-35c7-c39d396ad14a@ivanov.biz> (raw)
In-Reply-To: <201704232141.23690@pali>
On 2017-04-23 15:41, Pali Rohár wrote:
> Such macros are not needed in mainline code. They are probably useful
> in time of writing patch, but not later to have them present in final
> driver code.
>
> I sent a new patch (you are in recipients list too) which fixes getting
> and setting timeout value when on AC. It also handles detection of
> timeout AC value based on existence of 0x0451 SMBIOS token like Mario
> suggested.
>
Your patch is great, thanks!
Regarding the debug macros: there are quite a few additional reserved
bits still left in the relevant data structures that may cause trouble
in the future. IMO having those macros available may speed up developing
fixes in the future.
Thanks again,
--
Arcadiy Ivanov
arcadiy@ivanov.biz | @arcivanov | https://ivanov.biz
https://github.com/arcivanov
prev parent reply other threads:[~2017-04-23 20:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-23 5:56 [PATCH] Keyboard backlight on Dell E7470 not adjustable from /sys entry Arcadiy Ivanov
2017-04-23 19:41 ` Pali Rohár
2017-04-23 20:54 ` Arcadiy Ivanov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=274da9d5-187a-6bb5-35c7-c39d396ad14a@ivanov.biz \
--to=arcadiy@ivanov.biz \
--cc=mario.limonciello@dell.com \
--cc=mjg59@srcf.ucam.org \
--cc=pali.rohar@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.