From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74EFAC11F67 for ; Wed, 14 Jul 2021 08:28:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5C038613AB for ; Wed, 14 Jul 2021 08:28:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238464AbhGNIbp (ORCPT ); Wed, 14 Jul 2021 04:31:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34238 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229940AbhGNIbo (ORCPT ); Wed, 14 Jul 2021 04:31:44 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BAD3FC06175F; Wed, 14 Jul 2021 01:28:52 -0700 (PDT) Received: from [IPv6:2a02:810a:880:f54:e49e:3ed0:1a77:5623] (unknown [IPv6:2a02:810a:880:f54:e49e:3ed0:1a77:5623]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: dafna) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id C8B601F42822; Wed, 14 Jul 2021 09:28:48 +0100 (BST) Subject: Re: [PATCH v6 04/11] media: mtk-jpeg: Get rid of mtk_smi_larb_get/put To: Yong Wu , Matthias Brugger , Joerg Roedel , Rob Herring , Krzysztof Kozlowski , David Airlie , Mauro Carvalho Chehab Cc: Evan Green , Robin Murphy , Tomasz Figa , Will Deacon , linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux-foundation.org, youlin.pei@mediatek.com, Nicolas Boichat , Matthias Kaehlcke , anan.sun@mediatek.com, ming-fan.chen@mediatek.com, yi.kuo@mediatek.com, acourbot@chromium.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, Daniel Vetter , Chun-Kuang Hu , Philipp Zabel , Xia Jiang , Tiffany Lin , Hsin-Yi Wang , Eizan Miyamoto , anthony.huang@mediatek.com, Rick Chang References: <20210714025626.5528-1-yong.wu@mediatek.com> <20210714025626.5528-5-yong.wu@mediatek.com> From: Dafna Hirschfeld Message-ID: <2753c4b1-76e7-9acd-ca1c-62e6017ed971@collabora.com> Date: Wed, 14 Jul 2021 10:28:46 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210714025626.5528-5-yong.wu@mediatek.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14.07.21 04:56, Yong Wu wrote: > MediaTek IOMMU has already added device_link between the consumer > and smi-larb device. If the jpg device call the pm_runtime_get_sync, > the smi-larb's pm_runtime_get_sync also be called automatically. > > After removing the larb_get operations, then mtk_jpeg_clk_init is > also unnecessary. Remove it too. > > CC: Rick Chang > CC: Xia Jiang > Signed-off-by: Yong Wu > Reviewed-by: Evan Green > Acked-by: Rick Chang Reviewed-by: Dafna Hirschfeld > --- > .../media/platform/mtk-jpeg/mtk_jpeg_core.c | 45 +------------------ > .../media/platform/mtk-jpeg/mtk_jpeg_core.h | 2 - > 2 files changed, 2 insertions(+), 45 deletions(-) > > diff --git a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c > index a89c7b206eef..4fea2c512434 100644 > --- a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c > +++ b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c > @@ -22,7 +22,6 @@ > #include > #include > #include > -#include > > #include "mtk_jpeg_enc_hw.h" > #include "mtk_jpeg_dec_hw.h" > @@ -1055,10 +1054,6 @@ static void mtk_jpeg_clk_on(struct mtk_jpeg_dev *jpeg) > { > int ret; > > - ret = mtk_smi_larb_get(jpeg->larb); > - if (ret) > - dev_err(jpeg->dev, "mtk_smi_larb_get larbvdec fail %d\n", ret); > - > ret = clk_bulk_prepare_enable(jpeg->variant->num_clks, > jpeg->variant->clks); > if (ret) > @@ -1069,7 +1064,6 @@ static void mtk_jpeg_clk_off(struct mtk_jpeg_dev *jpeg) > { > clk_bulk_disable_unprepare(jpeg->variant->num_clks, > jpeg->variant->clks); > - mtk_smi_larb_put(jpeg->larb); > } > > static irqreturn_t mtk_jpeg_enc_done(struct mtk_jpeg_dev *jpeg) > @@ -1284,35 +1278,6 @@ static struct clk_bulk_data mtk_jpeg_clocks[] = { > { .id = "jpgenc" }, > }; > > -static int mtk_jpeg_clk_init(struct mtk_jpeg_dev *jpeg) > -{ > - struct device_node *node; > - struct platform_device *pdev; > - int ret; > - > - node = of_parse_phandle(jpeg->dev->of_node, "mediatek,larb", 0); > - if (!node) > - return -EINVAL; > - pdev = of_find_device_by_node(node); > - if (WARN_ON(!pdev)) { > - of_node_put(node); > - return -EINVAL; > - } > - of_node_put(node); > - > - jpeg->larb = &pdev->dev; > - > - ret = devm_clk_bulk_get(jpeg->dev, jpeg->variant->num_clks, > - jpeg->variant->clks); > - if (ret) { > - dev_err(&pdev->dev, "failed to get jpeg clock:%d\n", ret); > - put_device(&pdev->dev); > - return ret; > - } > - > - return 0; > -} > - > static void mtk_jpeg_job_timeout_work(struct work_struct *work) > { > struct mtk_jpeg_dev *jpeg = container_of(work, struct mtk_jpeg_dev, > @@ -1333,11 +1298,6 @@ static void mtk_jpeg_job_timeout_work(struct work_struct *work) > v4l2_m2m_job_finish(jpeg->m2m_dev, ctx->fh.m2m_ctx); > } > > -static inline void mtk_jpeg_clk_release(struct mtk_jpeg_dev *jpeg) > -{ > - put_device(jpeg->larb); > -} > - > static int mtk_jpeg_probe(struct platform_device *pdev) > { > struct mtk_jpeg_dev *jpeg; > @@ -1376,7 +1336,8 @@ static int mtk_jpeg_probe(struct platform_device *pdev) > goto err_req_irq; > } > > - ret = mtk_jpeg_clk_init(jpeg); > + ret = devm_clk_bulk_get(jpeg->dev, jpeg->variant->num_clks, > + jpeg->variant->clks); > if (ret) { > dev_err(&pdev->dev, "Failed to init clk, err %d\n", ret); > goto err_clk_init; > @@ -1442,7 +1403,6 @@ static int mtk_jpeg_probe(struct platform_device *pdev) > v4l2_device_unregister(&jpeg->v4l2_dev); > > err_dev_register: > - mtk_jpeg_clk_release(jpeg); > > err_clk_init: > > @@ -1460,7 +1420,6 @@ static int mtk_jpeg_remove(struct platform_device *pdev) > video_device_release(jpeg->vdev); > v4l2_m2m_release(jpeg->m2m_dev); > v4l2_device_unregister(&jpeg->v4l2_dev); > - mtk_jpeg_clk_release(jpeg); > > return 0; > } > diff --git a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.h b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.h > index 595f7f10c9fd..3e4811a41ba2 100644 > --- a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.h > +++ b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.h > @@ -85,7 +85,6 @@ struct mtk_jpeg_variant { > * @alloc_ctx: videobuf2 memory allocator's context > * @vdev: video device node for jpeg mem2mem mode > * @reg_base: JPEG registers mapping > - * @larb: SMI device > * @job_timeout_work: IRQ timeout structure > * @variant: driver variant to be used > */ > @@ -99,7 +98,6 @@ struct mtk_jpeg_dev { > void *alloc_ctx; > struct video_device *vdev; > void __iomem *reg_base; > - struct device *larb; > struct delayed_work job_timeout_work; > const struct mtk_jpeg_variant *variant; > }; > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22562C11F68 for ; Wed, 14 Jul 2021 08:28:56 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C3AEF613D7 for ; Wed, 14 Jul 2021 08:28:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C3AEF613D7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 8C36B60726; Wed, 14 Jul 2021 08:28:55 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0Z9ylv4j2TCM; Wed, 14 Jul 2021 08:28:54 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp3.osuosl.org (Postfix) with ESMTPS id 647BE60662; Wed, 14 Jul 2021 08:28:54 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 46D0BC001A; Wed, 14 Jul 2021 08:28:54 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 502B8C000E for ; Wed, 14 Jul 2021 08:28:53 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 3DBEF401F1 for ; Wed, 14 Jul 2021 08:28:53 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pnZy62ByPEkJ for ; Wed, 14 Jul 2021 08:28:52 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by smtp2.osuosl.org (Postfix) with ESMTPS id 43E8C40114 for ; Wed, 14 Jul 2021 08:28:52 +0000 (UTC) Received: from [IPv6:2a02:810a:880:f54:e49e:3ed0:1a77:5623] (unknown [IPv6:2a02:810a:880:f54:e49e:3ed0:1a77:5623]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: dafna) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id C8B601F42822; Wed, 14 Jul 2021 09:28:48 +0100 (BST) Subject: Re: [PATCH v6 04/11] media: mtk-jpeg: Get rid of mtk_smi_larb_get/put To: Yong Wu , Matthias Brugger , Joerg Roedel , Rob Herring , Krzysztof Kozlowski , David Airlie , Mauro Carvalho Chehab References: <20210714025626.5528-1-yong.wu@mediatek.com> <20210714025626.5528-5-yong.wu@mediatek.com> From: Dafna Hirschfeld Message-ID: <2753c4b1-76e7-9acd-ca1c-62e6017ed971@collabora.com> Date: Wed, 14 Jul 2021 10:28:46 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210714025626.5528-5-yong.wu@mediatek.com> Content-Language: en-US Cc: Xia Jiang , Chun-Kuang Hu , Will Deacon , dri-devel@lists.freedesktop.org, anthony.huang@mediatek.com, youlin.pei@mediatek.com, Nicolas Boichat , Rick Chang , Evan Green , Eizan Miyamoto , Matthias Kaehlcke , linux-media@vger.kernel.org, devicetree@vger.kernel.org, Philipp Zabel , yi.kuo@mediatek.com, linux-mediatek@lists.infradead.org, Hsin-Yi Wang , ming-fan.chen@mediatek.com, Tiffany Lin , linux-arm-kernel@lists.infradead.org, anan.sun@mediatek.com, srv_heupstream@mediatek.com, acourbot@chromium.org, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, Daniel Vetter , Robin Murphy X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On 14.07.21 04:56, Yong Wu wrote: > MediaTek IOMMU has already added device_link between the consumer > and smi-larb device. If the jpg device call the pm_runtime_get_sync, > the smi-larb's pm_runtime_get_sync also be called automatically. > > After removing the larb_get operations, then mtk_jpeg_clk_init is > also unnecessary. Remove it too. > > CC: Rick Chang > CC: Xia Jiang > Signed-off-by: Yong Wu > Reviewed-by: Evan Green > Acked-by: Rick Chang Reviewed-by: Dafna Hirschfeld > --- > .../media/platform/mtk-jpeg/mtk_jpeg_core.c | 45 +------------------ > .../media/platform/mtk-jpeg/mtk_jpeg_core.h | 2 - > 2 files changed, 2 insertions(+), 45 deletions(-) > > diff --git a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c > index a89c7b206eef..4fea2c512434 100644 > --- a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c > +++ b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c > @@ -22,7 +22,6 @@ > #include > #include > #include > -#include > > #include "mtk_jpeg_enc_hw.h" > #include "mtk_jpeg_dec_hw.h" > @@ -1055,10 +1054,6 @@ static void mtk_jpeg_clk_on(struct mtk_jpeg_dev *jpeg) > { > int ret; > > - ret = mtk_smi_larb_get(jpeg->larb); > - if (ret) > - dev_err(jpeg->dev, "mtk_smi_larb_get larbvdec fail %d\n", ret); > - > ret = clk_bulk_prepare_enable(jpeg->variant->num_clks, > jpeg->variant->clks); > if (ret) > @@ -1069,7 +1064,6 @@ static void mtk_jpeg_clk_off(struct mtk_jpeg_dev *jpeg) > { > clk_bulk_disable_unprepare(jpeg->variant->num_clks, > jpeg->variant->clks); > - mtk_smi_larb_put(jpeg->larb); > } > > static irqreturn_t mtk_jpeg_enc_done(struct mtk_jpeg_dev *jpeg) > @@ -1284,35 +1278,6 @@ static struct clk_bulk_data mtk_jpeg_clocks[] = { > { .id = "jpgenc" }, > }; > > -static int mtk_jpeg_clk_init(struct mtk_jpeg_dev *jpeg) > -{ > - struct device_node *node; > - struct platform_device *pdev; > - int ret; > - > - node = of_parse_phandle(jpeg->dev->of_node, "mediatek,larb", 0); > - if (!node) > - return -EINVAL; > - pdev = of_find_device_by_node(node); > - if (WARN_ON(!pdev)) { > - of_node_put(node); > - return -EINVAL; > - } > - of_node_put(node); > - > - jpeg->larb = &pdev->dev; > - > - ret = devm_clk_bulk_get(jpeg->dev, jpeg->variant->num_clks, > - jpeg->variant->clks); > - if (ret) { > - dev_err(&pdev->dev, "failed to get jpeg clock:%d\n", ret); > - put_device(&pdev->dev); > - return ret; > - } > - > - return 0; > -} > - > static void mtk_jpeg_job_timeout_work(struct work_struct *work) > { > struct mtk_jpeg_dev *jpeg = container_of(work, struct mtk_jpeg_dev, > @@ -1333,11 +1298,6 @@ static void mtk_jpeg_job_timeout_work(struct work_struct *work) > v4l2_m2m_job_finish(jpeg->m2m_dev, ctx->fh.m2m_ctx); > } > > -static inline void mtk_jpeg_clk_release(struct mtk_jpeg_dev *jpeg) > -{ > - put_device(jpeg->larb); > -} > - > static int mtk_jpeg_probe(struct platform_device *pdev) > { > struct mtk_jpeg_dev *jpeg; > @@ -1376,7 +1336,8 @@ static int mtk_jpeg_probe(struct platform_device *pdev) > goto err_req_irq; > } > > - ret = mtk_jpeg_clk_init(jpeg); > + ret = devm_clk_bulk_get(jpeg->dev, jpeg->variant->num_clks, > + jpeg->variant->clks); > if (ret) { > dev_err(&pdev->dev, "Failed to init clk, err %d\n", ret); > goto err_clk_init; > @@ -1442,7 +1403,6 @@ static int mtk_jpeg_probe(struct platform_device *pdev) > v4l2_device_unregister(&jpeg->v4l2_dev); > > err_dev_register: > - mtk_jpeg_clk_release(jpeg); > > err_clk_init: > > @@ -1460,7 +1420,6 @@ static int mtk_jpeg_remove(struct platform_device *pdev) > video_device_release(jpeg->vdev); > v4l2_m2m_release(jpeg->m2m_dev); > v4l2_device_unregister(&jpeg->v4l2_dev); > - mtk_jpeg_clk_release(jpeg); > > return 0; > } > diff --git a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.h b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.h > index 595f7f10c9fd..3e4811a41ba2 100644 > --- a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.h > +++ b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.h > @@ -85,7 +85,6 @@ struct mtk_jpeg_variant { > * @alloc_ctx: videobuf2 memory allocator's context > * @vdev: video device node for jpeg mem2mem mode > * @reg_base: JPEG registers mapping > - * @larb: SMI device > * @job_timeout_work: IRQ timeout structure > * @variant: driver variant to be used > */ > @@ -99,7 +98,6 @@ struct mtk_jpeg_dev { > void *alloc_ctx; > struct video_device *vdev; > void __iomem *reg_base; > - struct device *larb; > struct delayed_work job_timeout_work; > const struct mtk_jpeg_variant *variant; > }; > _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E54D9C07E9C for ; Wed, 14 Jul 2021 08:29:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BC93D613AB for ; Wed, 14 Jul 2021 08:29:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BC93D613AB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MvAR0I1sZYgItKgLuri9Yje1Feu9x6AKKMPn4F1bRRA=; b=of1D8BRxKtcLEbmKo/mcUbzIol Dta8MBTqugID6rHg1fdZYx4Rh0Jzbx1XNJ5/IvuBYkevpke+XwgbeTm6030yydSrbMgOVp+VK7DUy UZxiE6+vEtSyg8jharjASeJj70hhknAAQzdTBP4IkE0ey1BsOeVkt2w00iB9OsziJBVLg5ykr8cE2 Yjcd+2A2NRQFP/rf0tgGWFMGQ70AtTN/adI0AgfmJM9H6oJoTnMJvfJSXCe9nFHlU/3fz+NzDqfyB Ne6cMAnZlZSaO47TVDKBeOgLn2oP0A0+K3pYbX9P4quKhnZWL3CzoUHdQ3VNc+1R+Oz3TZ0+xxlk4 MDK/IyLg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m3aGS-00CecT-KZ; Wed, 14 Jul 2021 08:29:08 +0000 Received: from bhuna.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e3e3]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m3aGB-00CeVn-Sz; Wed, 14 Jul 2021 08:28:53 +0000 Received: from [IPv6:2a02:810a:880:f54:e49e:3ed0:1a77:5623] (unknown [IPv6:2a02:810a:880:f54:e49e:3ed0:1a77:5623]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: dafna) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id C8B601F42822; Wed, 14 Jul 2021 09:28:48 +0100 (BST) Subject: Re: [PATCH v6 04/11] media: mtk-jpeg: Get rid of mtk_smi_larb_get/put To: Yong Wu , Matthias Brugger , Joerg Roedel , Rob Herring , Krzysztof Kozlowski , David Airlie , Mauro Carvalho Chehab Cc: Evan Green , Robin Murphy , Tomasz Figa , Will Deacon , linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux-foundation.org, youlin.pei@mediatek.com, Nicolas Boichat , Matthias Kaehlcke , anan.sun@mediatek.com, ming-fan.chen@mediatek.com, yi.kuo@mediatek.com, acourbot@chromium.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, Daniel Vetter , Chun-Kuang Hu , Philipp Zabel , Xia Jiang , Tiffany Lin , Hsin-Yi Wang , Eizan Miyamoto , anthony.huang@mediatek.com, Rick Chang References: <20210714025626.5528-1-yong.wu@mediatek.com> <20210714025626.5528-5-yong.wu@mediatek.com> From: Dafna Hirschfeld Message-ID: <2753c4b1-76e7-9acd-ca1c-62e6017ed971@collabora.com> Date: Wed, 14 Jul 2021 10:28:46 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210714025626.5528-5-yong.wu@mediatek.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210714_012852_281577_94FD9B5A X-CRM114-Status: GOOD ( 28.46 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On 14.07.21 04:56, Yong Wu wrote: > MediaTek IOMMU has already added device_link between the consumer > and smi-larb device. If the jpg device call the pm_runtime_get_sync, > the smi-larb's pm_runtime_get_sync also be called automatically. > > After removing the larb_get operations, then mtk_jpeg_clk_init is > also unnecessary. Remove it too. > > CC: Rick Chang > CC: Xia Jiang > Signed-off-by: Yong Wu > Reviewed-by: Evan Green > Acked-by: Rick Chang Reviewed-by: Dafna Hirschfeld > --- > .../media/platform/mtk-jpeg/mtk_jpeg_core.c | 45 +------------------ > .../media/platform/mtk-jpeg/mtk_jpeg_core.h | 2 - > 2 files changed, 2 insertions(+), 45 deletions(-) > > diff --git a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c > index a89c7b206eef..4fea2c512434 100644 > --- a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c > +++ b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c > @@ -22,7 +22,6 @@ > #include > #include > #include > -#include > > #include "mtk_jpeg_enc_hw.h" > #include "mtk_jpeg_dec_hw.h" > @@ -1055,10 +1054,6 @@ static void mtk_jpeg_clk_on(struct mtk_jpeg_dev *jpeg) > { > int ret; > > - ret = mtk_smi_larb_get(jpeg->larb); > - if (ret) > - dev_err(jpeg->dev, "mtk_smi_larb_get larbvdec fail %d\n", ret); > - > ret = clk_bulk_prepare_enable(jpeg->variant->num_clks, > jpeg->variant->clks); > if (ret) > @@ -1069,7 +1064,6 @@ static void mtk_jpeg_clk_off(struct mtk_jpeg_dev *jpeg) > { > clk_bulk_disable_unprepare(jpeg->variant->num_clks, > jpeg->variant->clks); > - mtk_smi_larb_put(jpeg->larb); > } > > static irqreturn_t mtk_jpeg_enc_done(struct mtk_jpeg_dev *jpeg) > @@ -1284,35 +1278,6 @@ static struct clk_bulk_data mtk_jpeg_clocks[] = { > { .id = "jpgenc" }, > }; > > -static int mtk_jpeg_clk_init(struct mtk_jpeg_dev *jpeg) > -{ > - struct device_node *node; > - struct platform_device *pdev; > - int ret; > - > - node = of_parse_phandle(jpeg->dev->of_node, "mediatek,larb", 0); > - if (!node) > - return -EINVAL; > - pdev = of_find_device_by_node(node); > - if (WARN_ON(!pdev)) { > - of_node_put(node); > - return -EINVAL; > - } > - of_node_put(node); > - > - jpeg->larb = &pdev->dev; > - > - ret = devm_clk_bulk_get(jpeg->dev, jpeg->variant->num_clks, > - jpeg->variant->clks); > - if (ret) { > - dev_err(&pdev->dev, "failed to get jpeg clock:%d\n", ret); > - put_device(&pdev->dev); > - return ret; > - } > - > - return 0; > -} > - > static void mtk_jpeg_job_timeout_work(struct work_struct *work) > { > struct mtk_jpeg_dev *jpeg = container_of(work, struct mtk_jpeg_dev, > @@ -1333,11 +1298,6 @@ static void mtk_jpeg_job_timeout_work(struct work_struct *work) > v4l2_m2m_job_finish(jpeg->m2m_dev, ctx->fh.m2m_ctx); > } > > -static inline void mtk_jpeg_clk_release(struct mtk_jpeg_dev *jpeg) > -{ > - put_device(jpeg->larb); > -} > - > static int mtk_jpeg_probe(struct platform_device *pdev) > { > struct mtk_jpeg_dev *jpeg; > @@ -1376,7 +1336,8 @@ static int mtk_jpeg_probe(struct platform_device *pdev) > goto err_req_irq; > } > > - ret = mtk_jpeg_clk_init(jpeg); > + ret = devm_clk_bulk_get(jpeg->dev, jpeg->variant->num_clks, > + jpeg->variant->clks); > if (ret) { > dev_err(&pdev->dev, "Failed to init clk, err %d\n", ret); > goto err_clk_init; > @@ -1442,7 +1403,6 @@ static int mtk_jpeg_probe(struct platform_device *pdev) > v4l2_device_unregister(&jpeg->v4l2_dev); > > err_dev_register: > - mtk_jpeg_clk_release(jpeg); > > err_clk_init: > > @@ -1460,7 +1420,6 @@ static int mtk_jpeg_remove(struct platform_device *pdev) > video_device_release(jpeg->vdev); > v4l2_m2m_release(jpeg->m2m_dev); > v4l2_device_unregister(&jpeg->v4l2_dev); > - mtk_jpeg_clk_release(jpeg); > > return 0; > } > diff --git a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.h b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.h > index 595f7f10c9fd..3e4811a41ba2 100644 > --- a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.h > +++ b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.h > @@ -85,7 +85,6 @@ struct mtk_jpeg_variant { > * @alloc_ctx: videobuf2 memory allocator's context > * @vdev: video device node for jpeg mem2mem mode > * @reg_base: JPEG registers mapping > - * @larb: SMI device > * @job_timeout_work: IRQ timeout structure > * @variant: driver variant to be used > */ > @@ -99,7 +98,6 @@ struct mtk_jpeg_dev { > void *alloc_ctx; > struct video_device *vdev; > void __iomem *reg_base; > - struct device *larb; > struct delayed_work job_timeout_work; > const struct mtk_jpeg_variant *variant; > }; > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A8F7C11F67 for ; Wed, 14 Jul 2021 08:30:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6E691613AB for ; Wed, 14 Jul 2021 08:30:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6E691613AB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=X+FX/KAiwAay09cLVO2ngvN3az+9aQWUYuEa9I4HTSs=; b=VY771GmArwidXOw2Zxs7UfA+Nm qentEhZMa1F8Hgck3IgnBAH2E3i5QxlrmAh4zBM3ZRiUMkK32kDUGB0CkJgIF575l9eLdFJax8X4e m7noN+vj285bAUVki0IcSy7IhJLaef5OP8TJ8c4AZobxl1PimY/5ICZJ99Iycuwm4MJ40pYWtIINj MPis0HJLjME4HpORYaBSY5RoApVYEJCth07sZZtKcUNKBW/fQSk9RYxVz4IMYjYoQYwBFsnKpovAQ wTUi2X/S40InOL4S5OMKWlGV0gtDdDpiqceWT2kjMKjPQ9epo1DbgsgwQQ4FsBp3hF/+miSX71GPM jPKcPTwQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m3aGH-00CeYB-MA; Wed, 14 Jul 2021 08:28:57 +0000 Received: from bhuna.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e3e3]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m3aGB-00CeVn-Sz; Wed, 14 Jul 2021 08:28:53 +0000 Received: from [IPv6:2a02:810a:880:f54:e49e:3ed0:1a77:5623] (unknown [IPv6:2a02:810a:880:f54:e49e:3ed0:1a77:5623]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: dafna) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id C8B601F42822; Wed, 14 Jul 2021 09:28:48 +0100 (BST) Subject: Re: [PATCH v6 04/11] media: mtk-jpeg: Get rid of mtk_smi_larb_get/put To: Yong Wu , Matthias Brugger , Joerg Roedel , Rob Herring , Krzysztof Kozlowski , David Airlie , Mauro Carvalho Chehab Cc: Evan Green , Robin Murphy , Tomasz Figa , Will Deacon , linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux-foundation.org, youlin.pei@mediatek.com, Nicolas Boichat , Matthias Kaehlcke , anan.sun@mediatek.com, ming-fan.chen@mediatek.com, yi.kuo@mediatek.com, acourbot@chromium.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, Daniel Vetter , Chun-Kuang Hu , Philipp Zabel , Xia Jiang , Tiffany Lin , Hsin-Yi Wang , Eizan Miyamoto , anthony.huang@mediatek.com, Rick Chang References: <20210714025626.5528-1-yong.wu@mediatek.com> <20210714025626.5528-5-yong.wu@mediatek.com> From: Dafna Hirschfeld Message-ID: <2753c4b1-76e7-9acd-ca1c-62e6017ed971@collabora.com> Date: Wed, 14 Jul 2021 10:28:46 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210714025626.5528-5-yong.wu@mediatek.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210714_012852_281577_94FD9B5A X-CRM114-Status: GOOD ( 28.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 14.07.21 04:56, Yong Wu wrote: > MediaTek IOMMU has already added device_link between the consumer > and smi-larb device. If the jpg device call the pm_runtime_get_sync, > the smi-larb's pm_runtime_get_sync also be called automatically. > > After removing the larb_get operations, then mtk_jpeg_clk_init is > also unnecessary. Remove it too. > > CC: Rick Chang > CC: Xia Jiang > Signed-off-by: Yong Wu > Reviewed-by: Evan Green > Acked-by: Rick Chang Reviewed-by: Dafna Hirschfeld > --- > .../media/platform/mtk-jpeg/mtk_jpeg_core.c | 45 +------------------ > .../media/platform/mtk-jpeg/mtk_jpeg_core.h | 2 - > 2 files changed, 2 insertions(+), 45 deletions(-) > > diff --git a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c > index a89c7b206eef..4fea2c512434 100644 > --- a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c > +++ b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c > @@ -22,7 +22,6 @@ > #include > #include > #include > -#include > > #include "mtk_jpeg_enc_hw.h" > #include "mtk_jpeg_dec_hw.h" > @@ -1055,10 +1054,6 @@ static void mtk_jpeg_clk_on(struct mtk_jpeg_dev *jpeg) > { > int ret; > > - ret = mtk_smi_larb_get(jpeg->larb); > - if (ret) > - dev_err(jpeg->dev, "mtk_smi_larb_get larbvdec fail %d\n", ret); > - > ret = clk_bulk_prepare_enable(jpeg->variant->num_clks, > jpeg->variant->clks); > if (ret) > @@ -1069,7 +1064,6 @@ static void mtk_jpeg_clk_off(struct mtk_jpeg_dev *jpeg) > { > clk_bulk_disable_unprepare(jpeg->variant->num_clks, > jpeg->variant->clks); > - mtk_smi_larb_put(jpeg->larb); > } > > static irqreturn_t mtk_jpeg_enc_done(struct mtk_jpeg_dev *jpeg) > @@ -1284,35 +1278,6 @@ static struct clk_bulk_data mtk_jpeg_clocks[] = { > { .id = "jpgenc" }, > }; > > -static int mtk_jpeg_clk_init(struct mtk_jpeg_dev *jpeg) > -{ > - struct device_node *node; > - struct platform_device *pdev; > - int ret; > - > - node = of_parse_phandle(jpeg->dev->of_node, "mediatek,larb", 0); > - if (!node) > - return -EINVAL; > - pdev = of_find_device_by_node(node); > - if (WARN_ON(!pdev)) { > - of_node_put(node); > - return -EINVAL; > - } > - of_node_put(node); > - > - jpeg->larb = &pdev->dev; > - > - ret = devm_clk_bulk_get(jpeg->dev, jpeg->variant->num_clks, > - jpeg->variant->clks); > - if (ret) { > - dev_err(&pdev->dev, "failed to get jpeg clock:%d\n", ret); > - put_device(&pdev->dev); > - return ret; > - } > - > - return 0; > -} > - > static void mtk_jpeg_job_timeout_work(struct work_struct *work) > { > struct mtk_jpeg_dev *jpeg = container_of(work, struct mtk_jpeg_dev, > @@ -1333,11 +1298,6 @@ static void mtk_jpeg_job_timeout_work(struct work_struct *work) > v4l2_m2m_job_finish(jpeg->m2m_dev, ctx->fh.m2m_ctx); > } > > -static inline void mtk_jpeg_clk_release(struct mtk_jpeg_dev *jpeg) > -{ > - put_device(jpeg->larb); > -} > - > static int mtk_jpeg_probe(struct platform_device *pdev) > { > struct mtk_jpeg_dev *jpeg; > @@ -1376,7 +1336,8 @@ static int mtk_jpeg_probe(struct platform_device *pdev) > goto err_req_irq; > } > > - ret = mtk_jpeg_clk_init(jpeg); > + ret = devm_clk_bulk_get(jpeg->dev, jpeg->variant->num_clks, > + jpeg->variant->clks); > if (ret) { > dev_err(&pdev->dev, "Failed to init clk, err %d\n", ret); > goto err_clk_init; > @@ -1442,7 +1403,6 @@ static int mtk_jpeg_probe(struct platform_device *pdev) > v4l2_device_unregister(&jpeg->v4l2_dev); > > err_dev_register: > - mtk_jpeg_clk_release(jpeg); > > err_clk_init: > > @@ -1460,7 +1420,6 @@ static int mtk_jpeg_remove(struct platform_device *pdev) > video_device_release(jpeg->vdev); > v4l2_m2m_release(jpeg->m2m_dev); > v4l2_device_unregister(&jpeg->v4l2_dev); > - mtk_jpeg_clk_release(jpeg); > > return 0; > } > diff --git a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.h b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.h > index 595f7f10c9fd..3e4811a41ba2 100644 > --- a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.h > +++ b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.h > @@ -85,7 +85,6 @@ struct mtk_jpeg_variant { > * @alloc_ctx: videobuf2 memory allocator's context > * @vdev: video device node for jpeg mem2mem mode > * @reg_base: JPEG registers mapping > - * @larb: SMI device > * @job_timeout_work: IRQ timeout structure > * @variant: driver variant to be used > */ > @@ -99,7 +98,6 @@ struct mtk_jpeg_dev { > void *alloc_ctx; > struct video_device *vdev; > void __iomem *reg_base; > - struct device *larb; > struct delayed_work job_timeout_work; > const struct mtk_jpeg_variant *variant; > }; > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13107C07E9A for ; Wed, 14 Jul 2021 08:28:54 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D2862613AB for ; Wed, 14 Jul 2021 08:28:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D2862613AB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5CC1D899A3; Wed, 14 Jul 2021 08:28:53 +0000 (UTC) Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by gabe.freedesktop.org (Postfix) with ESMTPS id CA180899A3 for ; Wed, 14 Jul 2021 08:28:51 +0000 (UTC) Received: from [IPv6:2a02:810a:880:f54:e49e:3ed0:1a77:5623] (unknown [IPv6:2a02:810a:880:f54:e49e:3ed0:1a77:5623]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: dafna) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id C8B601F42822; Wed, 14 Jul 2021 09:28:48 +0100 (BST) Subject: Re: [PATCH v6 04/11] media: mtk-jpeg: Get rid of mtk_smi_larb_get/put To: Yong Wu , Matthias Brugger , Joerg Roedel , Rob Herring , Krzysztof Kozlowski , David Airlie , Mauro Carvalho Chehab References: <20210714025626.5528-1-yong.wu@mediatek.com> <20210714025626.5528-5-yong.wu@mediatek.com> From: Dafna Hirschfeld Message-ID: <2753c4b1-76e7-9acd-ca1c-62e6017ed971@collabora.com> Date: Wed, 14 Jul 2021 10:28:46 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210714025626.5528-5-yong.wu@mediatek.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Xia Jiang , Chun-Kuang Hu , Will Deacon , dri-devel@lists.freedesktop.org, anthony.huang@mediatek.com, youlin.pei@mediatek.com, Nicolas Boichat , Rick Chang , Evan Green , Eizan Miyamoto , Matthias Kaehlcke , linux-media@vger.kernel.org, devicetree@vger.kernel.org, yi.kuo@mediatek.com, linux-mediatek@lists.infradead.org, Hsin-Yi Wang , ming-fan.chen@mediatek.com, Tiffany Lin , linux-arm-kernel@lists.infradead.org, anan.sun@mediatek.com, srv_heupstream@mediatek.com, acourbot@chromium.org, linux-kernel@vger.kernel.org, Tomasz Figa , iommu@lists.linux-foundation.org, Robin Murphy Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 14.07.21 04:56, Yong Wu wrote: > MediaTek IOMMU has already added device_link between the consumer > and smi-larb device. If the jpg device call the pm_runtime_get_sync, > the smi-larb's pm_runtime_get_sync also be called automatically. > > After removing the larb_get operations, then mtk_jpeg_clk_init is > also unnecessary. Remove it too. > > CC: Rick Chang > CC: Xia Jiang > Signed-off-by: Yong Wu > Reviewed-by: Evan Green > Acked-by: Rick Chang Reviewed-by: Dafna Hirschfeld > --- > .../media/platform/mtk-jpeg/mtk_jpeg_core.c | 45 +------------------ > .../media/platform/mtk-jpeg/mtk_jpeg_core.h | 2 - > 2 files changed, 2 insertions(+), 45 deletions(-) > > diff --git a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c > index a89c7b206eef..4fea2c512434 100644 > --- a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c > +++ b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c > @@ -22,7 +22,6 @@ > #include > #include > #include > -#include > > #include "mtk_jpeg_enc_hw.h" > #include "mtk_jpeg_dec_hw.h" > @@ -1055,10 +1054,6 @@ static void mtk_jpeg_clk_on(struct mtk_jpeg_dev *jpeg) > { > int ret; > > - ret = mtk_smi_larb_get(jpeg->larb); > - if (ret) > - dev_err(jpeg->dev, "mtk_smi_larb_get larbvdec fail %d\n", ret); > - > ret = clk_bulk_prepare_enable(jpeg->variant->num_clks, > jpeg->variant->clks); > if (ret) > @@ -1069,7 +1064,6 @@ static void mtk_jpeg_clk_off(struct mtk_jpeg_dev *jpeg) > { > clk_bulk_disable_unprepare(jpeg->variant->num_clks, > jpeg->variant->clks); > - mtk_smi_larb_put(jpeg->larb); > } > > static irqreturn_t mtk_jpeg_enc_done(struct mtk_jpeg_dev *jpeg) > @@ -1284,35 +1278,6 @@ static struct clk_bulk_data mtk_jpeg_clocks[] = { > { .id = "jpgenc" }, > }; > > -static int mtk_jpeg_clk_init(struct mtk_jpeg_dev *jpeg) > -{ > - struct device_node *node; > - struct platform_device *pdev; > - int ret; > - > - node = of_parse_phandle(jpeg->dev->of_node, "mediatek,larb", 0); > - if (!node) > - return -EINVAL; > - pdev = of_find_device_by_node(node); > - if (WARN_ON(!pdev)) { > - of_node_put(node); > - return -EINVAL; > - } > - of_node_put(node); > - > - jpeg->larb = &pdev->dev; > - > - ret = devm_clk_bulk_get(jpeg->dev, jpeg->variant->num_clks, > - jpeg->variant->clks); > - if (ret) { > - dev_err(&pdev->dev, "failed to get jpeg clock:%d\n", ret); > - put_device(&pdev->dev); > - return ret; > - } > - > - return 0; > -} > - > static void mtk_jpeg_job_timeout_work(struct work_struct *work) > { > struct mtk_jpeg_dev *jpeg = container_of(work, struct mtk_jpeg_dev, > @@ -1333,11 +1298,6 @@ static void mtk_jpeg_job_timeout_work(struct work_struct *work) > v4l2_m2m_job_finish(jpeg->m2m_dev, ctx->fh.m2m_ctx); > } > > -static inline void mtk_jpeg_clk_release(struct mtk_jpeg_dev *jpeg) > -{ > - put_device(jpeg->larb); > -} > - > static int mtk_jpeg_probe(struct platform_device *pdev) > { > struct mtk_jpeg_dev *jpeg; > @@ -1376,7 +1336,8 @@ static int mtk_jpeg_probe(struct platform_device *pdev) > goto err_req_irq; > } > > - ret = mtk_jpeg_clk_init(jpeg); > + ret = devm_clk_bulk_get(jpeg->dev, jpeg->variant->num_clks, > + jpeg->variant->clks); > if (ret) { > dev_err(&pdev->dev, "Failed to init clk, err %d\n", ret); > goto err_clk_init; > @@ -1442,7 +1403,6 @@ static int mtk_jpeg_probe(struct platform_device *pdev) > v4l2_device_unregister(&jpeg->v4l2_dev); > > err_dev_register: > - mtk_jpeg_clk_release(jpeg); > > err_clk_init: > > @@ -1460,7 +1420,6 @@ static int mtk_jpeg_remove(struct platform_device *pdev) > video_device_release(jpeg->vdev); > v4l2_m2m_release(jpeg->m2m_dev); > v4l2_device_unregister(&jpeg->v4l2_dev); > - mtk_jpeg_clk_release(jpeg); > > return 0; > } > diff --git a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.h b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.h > index 595f7f10c9fd..3e4811a41ba2 100644 > --- a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.h > +++ b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.h > @@ -85,7 +85,6 @@ struct mtk_jpeg_variant { > * @alloc_ctx: videobuf2 memory allocator's context > * @vdev: video device node for jpeg mem2mem mode > * @reg_base: JPEG registers mapping > - * @larb: SMI device > * @job_timeout_work: IRQ timeout structure > * @variant: driver variant to be used > */ > @@ -99,7 +98,6 @@ struct mtk_jpeg_dev { > void *alloc_ctx; > struct video_device *vdev; > void __iomem *reg_base; > - struct device *larb; > struct delayed_work job_timeout_work; > const struct mtk_jpeg_variant *variant; > }; >